x2go-dev

x2go-dev@lists.x2go.org

5400 discussions

Re: [X2Go-Dev] [X2Go-Commits] [x2goclient] 01/01: Client now sends "login" parameter to the broker when executing task "selectsession". Before client just sent a username on the broker and it was imposiible to find out user name on X2Go server, which is not always the same as broker username. This won't break a compatibility with previous broker as they just will ignore this parameter.
by Mike Gabriel 21 Dec '18

21 Dec '18

Hi Alex, please explain the reasoning behind this API change in the SSH broker call. This commit currently breaks SSH brokerage in X2Go Session Broker and I would like to fix it. So, what do you intend with the additional --login option? How is the broker supposed to react? Mike On Mi 05 Sep 2018 14:25:44 CEST, git-admin wrote: > This is an automated email from the git hooks/post-receive script. > > x2go pushed a commit to branch master > in repository x2goclient. > > commit e7e74df029a1bd7d86a03c7f72f5b555eb6c5b0e > Author: Oleksandr Shneyder <o.shneyder(a)phoca-gmbh.de> > Date: Wed Sep 5 14:25:33 2018 +0200 > > Client now sends "login" parameter to the broker when executing > task "selectsession". Before client just sent a username on the > broker and it was imposiible to find out user name on X2Go server, > which is not always the same as broker username. This won't break a > compatibility with previous broker as they just will ignore this > parameter. > --- > debian/changelog | 5 +++++ > src/httpbrokerclient.cpp | 23 +++++++++++++++-------- > src/httpbrokerclient.h | 2 +- > src/onmainwindow.cpp | 2 +- > 4 files changed, 22 insertions(+), 10 deletions(-) > > diff --git a/debian/changelog b/debian/changelog > index dc01147..0a43c2d 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -17,6 +17,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium > - Broker can send to client command to suspend or terminate the > session as an > answer to the client event message. For this broker should > send to client > SUSPEND ID or TERMINATE ID. > + - Client now sends "login" parameter to the broker when executing task > + "selectsession". Before client just sent a username on the > broker and it was > + imposiible to find out user name on X2Go server, which is not > always the > + same as broker username. This won't break a compatibility > with previous > + broker as they just will ignore this parameter. > > [ Mihai Moldovan ] > * New upstream version (4.1.2.2): > diff --git a/src/httpbrokerclient.cpp b/src/httpbrokerclient.cpp > index 6110866..02a69c9 100644 > --- a/src/httpbrokerclient.cpp > +++ b/src/httpbrokerclient.cpp > @@ -313,9 +313,9 @@ void HttpBrokerClient::getUserSessions() > } > } > > -void HttpBrokerClient::selectUserSession(const QString& session) > +void HttpBrokerClient::selectUserSession(const QString& session, > const QString& loginName) > { > - x2goDebug<<"Called selectUserSession for session "<<session<<"."; > + x2goDebug<<"Called selectUserSession for session "<<session<<", > "<<"loginName "<<loginName; > QString brokerUser=config->brokerUser; > if(mainWindow->getUsePGPCard()) > brokerUser=mainWindow->getCardLogin(); > @@ -329,6 +329,10 @@ void HttpBrokerClient::selectUserSession(const > QString& session) > > "user="<<QUrl::toPercentEncoding(brokerUser)<<"&"<< > > "password="<<QUrl::toPercentEncoding(config->brokerPass)<<"&"<< > "authid="<<nextAuthId; > + if(loginName.length()>0) > + { > + QTextStream ( &req ) > <<"&login="<<QUrl::toPercentEncoding(loginName); > + } > x2goDebug << "Sending request: "<< req.toUtf8(); > QNetworkRequest request(QUrl(config->brokerurl)); > request.setHeader(QNetworkRequest::ContentTypeHeader, > "application/x-www-form-urlencoded"); > @@ -337,13 +341,16 @@ void HttpBrokerClient::selectUserSession(const > QString& session) > } > else > { > - if (nextAuthId.length() > 0) { > - sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser +" --authid "+nextAuthId+ " --task > selectsession --sid \""+session+"\"", > - this,SLOT ( > slotSelectSession(bool,QString,int))); > - } else { > - sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser +" --task selectsession --sid \""+session+"\"", > - this,SLOT ( > slotSelectSession(bool,QString,int))); > + QString sshCmd=config->sshBrokerBin+" --user "+ brokerUser > + " --task selectsession --sid \""+session+"\""; > + if(nextAuthId.length() > 0) > + { > + sshCmd+=" --authid "+nextAuthId; > + } > + if(loginName.length() > 0) > + { > + sshCmd+=" --login " + loginName; > } > + sshConnection->executeCommand (sshCmd, this,SLOT ( > slotSelectSession(bool,QString,int))); > } > > } > diff --git a/src/httpbrokerclient.h b/src/httpbrokerclient.h > index 24f52f3..73ae2ef 100644 > --- a/src/httpbrokerclient.h > +++ b/src/httpbrokerclient.h > @@ -41,7 +41,7 @@ class HttpBrokerClient: public QObject > public: > HttpBrokerClient ( ONMainWindow* wnd, ConfigFile* cfg ); > ~HttpBrokerClient(); > - void selectUserSession(const QString& session ); > + void selectUserSession(const QString& session, const QString& > loginName); > void changePassword(QString newPass); > void testConnection(); > void closeSSHInteractionDialog(); > diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp > index 8aa5078..52e765c 100644 > --- a/src/onmainwindow.cpp > +++ b/src/onmainwindow.cpp > @@ -3325,7 +3325,7 @@ void ONMainWindow::slotSessEnter() > return; > } > #endif > - broker->selectUserSession(sessionExplorer->getLastSession()->id()); > + > broker->selectUserSession(sessionExplorer->getLastSession()->id(),login->text()); > config.session=sessionExplorer->getLastSession()->id(); > setStatStatus ( tr ( "Connecting to broker" ) ); > stInfo->insertPlainText ( "broker url: "+config.brokerurl ); > > -- > Alioth's > /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on > /srv/git/code.x2go.org/x2goclient.git > _______________________________________________ > x2go-commits mailing list > x2go-commits(a)lists.x2go.org > https://lists.x2go.org/listinfo/x2go-commits -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de

2 5

Re: [X2Go-Dev] [X2Go-Commits] [x2goclient] 01/01: Add new brocker feature. Broker can send to client some configuration in the section START_CLIENT_CONFIG - END_CLIENT_CONFIG. For the moment is supported option events=bool. If true, client sending to broker events: CONNECTING, CONNECTED, SUSPENDING, TERMINATING, FINISHED. It's not a real session state, but rather the state of X2Go Client.
by Mike Gabriel 21 Dec '18

21 Dec '18

Hi Alex, how well is the below feature tested with current x2gobroker that does not yet understand this feature? I guess this patch is part of a paid project. Do you have budget for adapting x2gobroker on git.x2go.org, too? Otherwise, I'd much prefer this commit on an extra branch for now, until the x2gobroker is adapted to this, too. Ideally, your patch supports legacy brokers, which I assume it does... Greets, Mike On Di 21 Aug 2018 15:43:05 CEST, git-admin wrote: > This is an automated email from the git hooks/post-receive script. > > x2go pushed a commit to branch master > in repository x2goclient. > > commit 539e0a4268df3d78f88f6908506c18222743d84f > Author: Oleksandr Shneyder <o.shneyder(a)phoca-gmbh.de> > Date: Tue Aug 21 15:42:52 2018 +0200 > > Add new brocker feature. Broker can send to client some > configuration in the section START_CLIENT_CONFIG - > END_CLIENT_CONFIG. For the moment is supported option events=bool. > If true, client sending to broker events: CONNECTING, CONNECTED, > SUSPENDING, TERMINATING, FINISHED. It's not a real session state, > but rather the state of X2Go Client. > --- > debian/changelog | 5 +++ > src/httpbrokerclient.cpp | 86 > ++++++++++++++++++++++++++++++++++++++++++++++++ > src/httpbrokerclient.h | 5 +++ > src/onmainwindow.cpp | 86 > +++++++++++++++++++++++++++++++++++++++++++----- > src/onmainwindow.h | 15 ++++++++- > 5 files changed, 187 insertions(+), 10 deletions(-) > > diff --git a/debian/changelog b/debian/changelog > index 5e22cd3..b0c0449 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -3,6 +3,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium > [ Oleksandr Shneyder ] > * New upstream version (4.1.2.2): > - Add SSH instruction to list of errors if keyboard-interactive > auth has failed. > + - Add new brocker feature. Broker can send to client some > configuration in > + the section START_CLIENT_CONFIG - END_CLIENT_CONFIG. For the > moment is supported > + option events=bool. If true, client sending to broker events: > CONNECTING, > + CONNECTED, SUSPENDING, TERMINATING, FINISHED. It's not a real > session state, > + but rather the state of X2Go Client. > > [ Mihai Moldovan ] > * New upstream version (4.1.2.2): > diff --git a/src/httpbrokerclient.cpp b/src/httpbrokerclient.cpp > index f7fbaf1..ea5158e 100644 > --- a/src/httpbrokerclient.cpp > +++ b/src/httpbrokerclient.cpp > @@ -270,6 +270,7 @@ void > HttpBrokerClient::slotSshUserAuthError(QString error) > return; > } > > + > void HttpBrokerClient::getUserSessions() > { > QString brokerUser=config->brokerUser; > @@ -347,6 +348,66 @@ void HttpBrokerClient::selectUserSession(const > QString& session) > > } > > +void HttpBrokerClient::sendEvent(const QString& ev, const QString& > id, const QString& server, const QString& client, const QString& > login, const QString& cmd, const QString& display, const QString& > start) > +{ > + x2goDebug<<"Called sendEvent."; > + QString brokerUser=config->brokerUser; > + if(mainWindow->getUsePGPCard()) > + brokerUser=mainWindow->getCardLogin(); > + > + if(!sshBroker) > + { > + QString req; > + QTextStream ( &req ) << > + "task=clientevent&"<< > + > "user="<<QUrl::toPercentEncoding(brokerUser)<<"&"<< > + "sid="<<id<<"&"<< > + "event="<<ev<<"&"<< > + > "server="<<QUrl::toPercentEncoding(server)<<"&"<< > + > "client="<<QUrl::toPercentEncoding(client)<<"&"<< > + "login="<<QUrl::toPercentEncoding(login)<<"&"<< > + "cmd="<<QUrl::toPercentEncoding(cmd)<<"&"<< > + > "display="<<QUrl::toPercentEncoding(display)<<"&"<< > + "start="<<QUrl::toPercentEncoding(start)<<"&"<< > + "authid="<<nextAuthId; > + x2goDebug << "Sending request: "<< req.toUtf8(); > + QNetworkRequest request(QUrl(config->brokerurl)); > + request.setHeader(QNetworkRequest::ContentTypeHeader, > "application/x-www-form-urlencoded"); > + eventRequest=http->post (request, req.toUtf8() ); > + > + } > + else > + { > + if (nextAuthId.length() > 0) { > + sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser +" --authid "+nextAuthId+ > + " --task clientevent --sid \""+id+"\" --event "+ev+" > --server \""+server+"\" --client \""+client+"\" --login "+"\""+ > + login+"\" --cmd \""+cmd+"\" --display \""+display+"\" > --start \""+start+"\"", > + this,SLOT ( slotEventSent(bool,QString,int))); > + } else { > + sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser + > + " --task clientevent --sid \""+id+"\" --event "+ev+" > --server \""+server+"\" --client \""+client+"\" --login "+"\""+ > + login+"\" --cmd \""+cmd+"\" --display\" "+display+" \" > --start \""+start+"\"", > + this,SLOT ( slotEventSent(bool,QString,int))); > + } > + } > +} > + > + > +void HttpBrokerClient::slotEventSent(bool success, QString answer, int) > +{ > + if(!success) > + { > + x2goDebug<<answer; > + QMessageBox::critical(0,tr("Error"),answer); > + emit fatalHttpError(); > + return; > + } > + if(!checkAccess(answer)) > + return; > + x2goDebug<<"event sent:"<<answer; > +} > + > + > void HttpBrokerClient::changePassword(QString newPass) > { > newBrokerPass=newPass; > @@ -405,6 +466,16 @@ void HttpBrokerClient::testConnection() > } > } > > +void HttpBrokerClient::processClientConfig(const QString& raw_content) > +{ > + X2goSettings st(raw_content, QSettings::IniFormat); > + > mainWindow->config.brokerEvents=st.setting()->value("events",false).toBool(); > + if(mainWindow->config.brokerEvents) > + { > + x2goDebug<<"sending client events to broker"; > + } > +} > + > > void HttpBrokerClient::createIniFile(const QString& raw_content) > { > @@ -420,6 +491,17 @@ void HttpBrokerClient::createIniFile(const > QString& raw_content) > cont=cont.split("END_USER_SESSIONS\n")[0]; > } > mainWindow->config.iniFile=cont; > + lines=content.split("START_CLIENT_CONFIG\n"); > + if (lines.count()>1) > + { > + cont=lines[1]; > + cont=cont.split("END_CLIENT_CONFIG\n")[0]; > + processClientConfig(cont); > + } > + else > + { > + x2goDebug<<"no client config from broker"; > + } > } > > > @@ -540,6 +622,10 @@ void HttpBrokerClient::slotRequestFinished ( > QNetworkReply* reply ) > { > slotPassChanged(true,answer,0); > } > + if (reply == eventRequest) > + { > + slotEventSent(true,answer,0); > + } > > // We receive ownership of the reply object > // and therefore need to handle deletion. > diff --git a/src/httpbrokerclient.h b/src/httpbrokerclient.h > index 0a307e1..4e0098e 100644 > --- a/src/httpbrokerclient.h > +++ b/src/httpbrokerclient.h > @@ -45,6 +45,8 @@ public: > void changePassword(QString newPass); > void testConnection(); > void closeSSHInteractionDialog(); > + void sendEvent(const QString& ev, const QString& id, const > QString& server, const QString& client, > + const QString& login, const QString& cmd, const > QString& display, const QString& start); > private: > QNetworkAccessManager* http; > QNetworkRequest* netRequest; > @@ -53,6 +55,7 @@ private: > QNetworkReply* selSessRequest; > QNetworkReply* chPassRequest; > QNetworkReply* testConRequest; > + QNetworkReply* eventRequest; > QString nextAuthId; > QString newBrokerPass; > ConfigFile* config; > @@ -62,6 +65,7 @@ private: > SshMasterConnection* sshConnection; > private: > void createIniFile(const QString& raw_content); > + void processClientConfig(const QString& raw_content); > void parseSession(QString sInfo); > void createSshConnection(); > bool checkAccess(QString answer); > @@ -78,6 +82,7 @@ private slots: > void slotListSessions ( bool success, QString answer, int pid); > void slotSelectSession ( bool success, QString answer, int pid); > void slotPassChanged ( bool success, QString answer, int pid); > + void slotEventSent ( bool success, QString answer, int pid); > void slotConnectionTest( bool success, QString answer, int pid); > void slotSshIoErr(SshProcess* caller, QString error, QString > lastSessionError); > > diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp > index 405b124..d547248 100644 > --- a/src/onmainwindow.cpp > +++ b/src/onmainwindow.cpp > @@ -3548,6 +3548,12 @@ void ONMainWindow::startDirectRDP() > resumingSession.sessionId=sessionExplorer->getLastSession()->name(); > > resumingSession.crTime=QDateTime::currentDateTime().toString("dd.MM.yy > HH:mm:ss"); > showSessionStatus(); > + if(brokerMode) > + { > + > sendEventToBroker(CONNECTING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > + > // QTimer::singleShot ( 30000,this,SLOT ( slotRestartProxy() ) ); > proxyRunning=true; > delete st; > @@ -3991,6 +3997,31 @@ x2goSession > ONMainWindow::getSessionFromString ( const QString& string ) > } > > > +void ONMainWindow::sendEventToBroker(ONMainWindow::client_events > ev, const QString& id, const QString& server, const QString& client, > const QString& login, const QString& cmd, const QString& display, > const QString& start) > +{ > + if(!config.brokerEvents) > + { > + return; > + } > + if(ev <= lastBrokerEvent && id == lastBrokerEventSession ) > + { > + return; > + } > + lastBrokerEvent=ev; > + lastBrokerEventSession=id; > + QString event; > + switch(ev) > + { > + case CONNECTING: event="CONNECTING";break; > + case CONNECTED: event="CONNECTED";break; > + case SUSPENDING: event="SUSPENDING";break; > + case TERMINATING: event="TERMINATING";break; > + case FINISHED: event="FINISHED";break; > + } > + broker->sendEvent(event, id, server, client, login, cmd, > display, start); > +} > + > + > void ONMainWindow::startNewSession() > { > newSession=true; > @@ -5025,6 +5056,11 @@ void ONMainWindow::slotSuspendSess() > void ONMainWindow::slotSuspendSessFromSt() > { > > + if(brokerMode) > + { > + > sendEventToBroker(SUSPENDING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > #ifdef Q_OS_LINUX > if (directRDP) > { > @@ -5053,6 +5089,11 @@ void ONMainWindow::slotTermSessFromSt() > if (directRDP) > { > > + if(brokerMode) > + { > + > sendEventToBroker(TERMINATING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > x2goDebug<<"Terminating direct RDP session."; > > nxproxy->terminate(); > @@ -5061,20 +5102,30 @@ void ONMainWindow::slotTermSessFromSt() > } > #endif > > - x2goDebug<<"Disconnect export."; > - > - /* > - disconnect ( sbExp,SIGNAL ( clicked() ),this, > - SLOT ( slot_exportDirectory() ) );*/ > - sbExp->setEnabled ( false ); > > if ( !shadowSession ) > { > if ( termSession ( resumingSession.sessionId ) ) > + { > + sbExp->setEnabled ( false ); > + if(brokerMode) > + { > + > sendEventToBroker(TERMINATING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > setStatStatus ( tr ( "terminating" ) ); > + } > } > else > + { > + sbExp->setEnabled ( false ); > + if(brokerMode) > + { > + > sendEventToBroker(TERMINATING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > termSession ( resumingSession.sessionId,false ); > + } > } > > > @@ -5812,6 +5863,12 @@ void ONMainWindow::slotTunnelOk(int) > > nxproxy->start ( proxyCmd ); > proxyRunning=true; > + if(brokerMode) > + { > + > sendEventToBroker(CONNECTING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > + > // always search for proxy window on linux. On Windows only in window mode > #ifdef Q_OS_WIN > if (xorgMode==WIN) { > @@ -6087,7 +6144,11 @@ void ONMainWindow::slotProxyError ( > QProcess::ProcessError err ) > > void ONMainWindow::slotProxyFinished ( int,QProcess::ExitStatus ) > { > - > + if(brokerMode) > + { > + > sendEventToBroker(FINISHED,resumingSession.sessionId,resumingSession.server, > resumingSession.clientIp, getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > #ifdef Q_OS_DARWIN > if (modMapTimer) { > disconnect (modMapTimer, SIGNAL (timeout ()), this, SLOT > (slotSetModMap ())); > @@ -6288,9 +6349,11 @@ void ONMainWindow::slotProxyStderr() > stInfo->insertPlainText ( reserr ); > stInfo->ensureCursorVisible(); > if ( stInfo->toPlainText().indexOf ( > - "Connecting to remote host 'localhost:"+ > - /*resumingSession.grPort*/ localGraphicPort ) !=-1 ) > + "Connecting to remote host 'localhost:"+ > + /*resumingSession.grPort*/ localGraphicPort ) !=-1 ) > + { > setStatStatus ( tr ( "connecting" ) ); > + } > > if ( stInfo->toPlainText().indexOf ( > "Connection to remote proxy 'localhost:"+ > @@ -6310,6 +6373,11 @@ void ONMainWindow::slotProxyStderr() > if ( stInfo->toPlainText().indexOf ( > "Established X server connection" ) !=-1 ) > { > + if(brokerMode) > + { > + > sendEventToBroker(CONNECTED,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > setStatStatus ( tr ( "running" ) ); > if (trayEnabled) > { > diff --git a/src/onmainwindow.h b/src/onmainwindow.h > index 47eaa5e..a1fab35 100644 > --- a/src/onmainwindow.h > +++ b/src/onmainwindow.h > @@ -169,6 +169,7 @@ struct ConfigFile > bool brokerAutologin; > bool brokerAutologoff; > bool brokerKrbLogin; > + bool brokerEvents; //Send events to broker and get control commands > QString brokerSshKey; > QString brokerCaCertFile; > QString iniFile; > @@ -300,6 +301,14 @@ public: > UNKNOWN_KEY_TYPE > }; > > + enum client_events { > + CONNECTING, > + CONNECTED, > + SUSPENDING, > + TERMINATING, > + FINISHED > + }; > + > static bool debugging; > > static bool portable; > @@ -859,6 +868,8 @@ private: > int lastUid; > bool cardReady; > HttpBrokerClient* broker; > + client_events lastBrokerEvent; > + QString lastBrokerEventSession; > > > #if defined ( Q_OS_WIN) //&& defined (CFGCLIENT ) > @@ -899,7 +910,9 @@ private: > bool trayMinCon; > bool trayMaxDiscon; > bool trayAutoHidden; > - > + void sendEventToBroker(client_events ev, const QString& id, > const QString& server, const QString& client, > + const QString& login, const QString& cmd, > + const QString& display, const QString& start); > QString findSshKeyForServer(QString user, QString server, QString port); > void loadSettings(); > void showPass ( UserButton* user ); > > -- > Alioth's > /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on > /srv/git/code.x2go.org/x2goclient.git > _______________________________________________ > x2go-commits mailing list > x2go-commits(a)lists.x2go.org > https://lists.x2go.org/listinfo/x2go-commits -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de

2 4

Bug#1355: x2godesktopsharing applet starts multiple times in KDE Plasma if restore desktop is set
by Mike Gabriel 15 Dec '18

15 Dec '18

Package: x2godesktopsharing Severity: important Version: 3.2.0.0 X-Debbugs-Cc: josesan(a)gmail.com Hi, I turn this thread into an official bug report... On So 09 Dez 2018 13:59:02 CET, Víctor J. Sánchez E. wrote: > > El mié., 5 dic. 2018 a las 15:09, Víctor J. Sánchez (<vjosesan(a)gmail.com>) > escribió: > >> Hi all, >> >> I recently installed x2godesktopsharing via X2Go repositories for Debian. >> The installation asked me about activate the auto-start feature (I said >> yes) and enable shared desktop (I said no). When I reboot the machine in >> KDE Plasma desktop I see two x2godesktopsharing applets in system tray and >> the next error message is displayed (translated into english): >> >> *The application X2Go DesktopSharing is already active for this screen* >> >> *if it doesn't run remove /tmp/x2godesktopsharing.lock_USER@:0 and start >> it up again* >> >> I don't know about x2godesktopsharing is started because I can't find >> anything in the documentation about it. I only see the file >> /etc/xdg/autostart/x2godesktopsharing.desktop but I don't see any system >> service (systemctl) nor KDE Plasma desktop's startup service or script. >> >> How could I resolve this issue? >> >> Some data about my system: >> >> - Debian testing (amd64), kernel 4.18.0-3-amd64 >> >> - KDE Plasma 5.14.3 >> >> - x2godesktopsharing 3.2.0.0 >> >> Thanks in advance. >> > Hi all again, > > after investigate deeper about this issue I noted that every log in in KDE > Plasma session the number of x2godesktopsharing applets were increasing in > system tray (until 5 applets or more!!). > I discovered that the restore of KDE Plasma session setting was inexplicably > resetted (may due to an update). I set it again to starts an empty session > and the problem has gone. Now it only starts only one x2godesktopsharing > system tray applet. > The setting is in KDE System Settings -> Startup and Shutdown -> Desktop > Session -> On Login switch to "Start with an empty session" instead of > "Restore previous session". > > Regards. > > ---- This looks like we should hinder x2godesktopsharing from starting a second instance when there is one already running for the same $DISPLAY. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de

1 0

Bug#1313: there is still a problem in getting a correct value for loadavgXX with loadchecker
by Walid MOGHRABI 14 Dec '18

14 Dec '18

package: x2gobroker-agent version: 0.0.4.0-0~1038~ubuntu16.04.1 priority: bug I don't have a "0" value anymore since latest fixes so the loadchecker process don't crash anymore but still, there is something strange. Here is a fragment of my loadchecker logs from this morning. Just to give you the context, I have 22 servers which are all automaticaly started at 6 AM (wake on lan) and they are absolutely the same (blade servers with same CPU, memory amount, bios version, ...). I checked our monitoring to see if users were correctly distributed over the farm and at 7:30AM, I had about 7 or 8 users connected but 4 of them were on tce-server-21 where I should have had 1 user on 8 servers. Here is the loadchecker log fragment : root@tce-manager-01 [~] # grep -B 1 'loadavgXX:1;' /var/log/x2gobroker/loadchecker.log ... 2018-07-24 07:15:01,200 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:15:01,622 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23684; myMemAvail:23810; numCPU:16; typeCPU:2400; -- 2018-07-24 07:17:50,354 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:17:50,779 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23686; myMemAvail:23812; numCPU:16; typeCPU:2400; -- 2018-07-24 07:20:32,550 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:20:32,964 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23683; myMemAvail:23809; numCPU:16; typeCPU:2400; -- 2018-07-24 07:23:21,610 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:23:22,034 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23685; myMemAvail:23811; numCPU:16; typeCPU:2400; -- 2018-07-24 07:26:03,872 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:26:04,286 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23684; myMemAvail:23809; numCPU:16; typeCPU:2400; -- 2018-07-24 07:28:52,917 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:28:53,338 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23684; myMemAvail:23809; numCPU:16; typeCPU:2400; -- 2018-07-24 07:31:35,252 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:31:35,670 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23685; myMemAvail:23811; numCPU:16; typeCPU:2400; -- 2018-07-24 07:34:24,424 - loadchecker - INFO - Executing agent command on remote host tce-server-21 (10.50.0.221): sh -c '/usr/lib/x2go/x2gobroker-agent foo checkload' 2018-07-24 07:34:24,842 - loadchecker - INFO - Broker agent answered: OK; loadavgXX:1; memAvail:23683; myMemAvail:23809; numCPU:16; typeCPU:2400; As you can see, there is only 1 server with a loadavgXX = 1 (which means that in fact, we got a zero value from the broker agent). This is not normal, at 7:34, there were 4 users already connected to this server and most of my other servers were empty. Restarting x2gobroker-loadchecker service fixed the issue. I think there is a problem in retrieving this informations ... even memAvail seem strange on this server to me ... with 4 connected users, it should have been lower than that. I also think the number of connected users should be taken into account when calculating the load factor (maybe this is already the case, not sure about that). --- DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you

3 3

Bug#1353: with dash as default shell, x2goagent.options are not being parsed correctly
by Stefan Baur 13 Dec '18

13 Dec '18

package: x2goserver-x2goagent version: 4.1.0.3 According to a user, when dash is set as the default shell, x2goagent.options are not being parsed correctly, as dash does not understand the "+=" syntax used in this file to concatenate various options. The particular piece of code that sources/runs this file should be calling bash explicitly to avoid this. -Stefan -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243

2 5

Bug#1354: Auto-update on CentOS did not work for nx-libs.x86_64 0:3.5.99.16-1.el7
by Franz Lückl 11 Dec '18

11 Dec '18

Package: nx-libs Version: 3.5.99.16-1.el7.x86_64 On this system auto-update for CentOS is enabled. The system is CentOS Linux release 7.5.1804. For some unknown reason auto-update did not work on this system. It worked on other systems. Here are the errors when updating with yum: ---> Package nx-libs.x86_64 0:3.5.99.16-1.el7 will be updated --> Processing Dependency: nx-libs(x86-64) = 3.5.99.16-1.el7 for package: libNX_X11-3.5.99.16-1.el7.x86_64 --> Processing Dependency: nx-libs(x86-64) = 3.5.99.16-1.el7 for package: libXcomp-3.5.99.16-1.el7.x86_64 --> Processing Dependency: nx-libs(x86-64) = 3.5.99.16-1.el7 for package: libXcompshad-3.5.99.16-1.el7.x86_64 --> Finished Dependency Resolution Error: Package: libXcompshad-3.5.99.16-1.el7.x86_64 (@epel) Requires: nx-libs(x86-64) = 3.5.99.16-1.el7 Removing: nx-libs-3.5.99.16-1.el7.x86_64 (@epel) nx-libs(x86-64) = 3.5.99.16-1.el7 Updated By: nx-libs-3.5.99.17-0.0build1.1.git20181127.3188.main.el7.x86_64 (x2go-release-epel) nx-libs(x86-64) = 3.5.99.17-0.0build1.1.git20181127.3188.main.el7 Error: Package: libXcomp-3.5.99.16-1.el7.x86_64 (@epel) Requires: nx-libs(x86-64) = 3.5.99.16-1.el7 Removing: nx-libs-3.5.99.16-1.el7.x86_64 (@epel) nx-libs(x86-64) = 3.5.99.16-1.el7 Updated By: nx-libs-3.5.99.17-0.0build1.1.git20181127.3188.main.el7.x86_64 (x2go-release-epel) nx-libs(x86-64) = 3.5.99.17-0.0build1.1.git20181127.3188.main.el7 Error: Package: libNX_X11-3.5.99.16-1.el7.x86_64 (@epel) Requires: nx-libs(x86-64) = 3.5.99.16-1.el7 Removing: nx-libs-3.5.99.16-1.el7.x86_64 (@epel) nx-libs(x86-64) = 3.5.99.16-1.el7 Updated By: nx-libs-3.5.99.17-0.0build1.1.git20181127.3188.main.el7.x86_64 (x2go-release-epel) nx-libs(x86-64) = 3.5.99.17-0.0build1.1.git20181127.3188.main.el7 The solution to this is to uninstall all of x2go and then reinstalling the x2go-server. Have a nice day, Franz Lückl

1 0

Processed: Bug#1351: x2gothinclient-common: File conflict w/ x2gothinclient
by owner＠bugs.x2go.org 06 Dec '18

06 Dec '18

Processing commands for control(a)bugs.x2go.org: > severity 1351 important Bug #1351 [x2gothinclient] x2gothinclient-common: File conflict w/ x2gothinclient Severity set to 'important' from 'normal' > stop Stopping processing here. Please contact me if you need assistance. -- 1351: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1351 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Re: [X2Go-Dev] X2Go Desktop Sharing (3.2.0.0) released
by Orion Poplawski 06 Dec '18

06 Dec '18

On 11/27/18 10:49 PM, Mihai Moldovan wrote: > Dear all > > The X2Go project is proud to announce a new release of the X2Go > component ,,x2godesktopsharing''. > ... > > *** IMPORTANT NOTE *** > Since some functionality has been moved into X2Go Server, please wait for the > X2Go Server 4.1.0.3 (or higher) release BEFORE you update this package. > > This package now contains the graphical interface only. It will be more or less > useless without the proper x2goserver integration. > *** IMPORTANT NOTE *** Should the x2godesktopsharing spec file require x2goserver >= 4.1.0.3? -- Orion Poplawski Manager of NWRA Technical Systems 720-772-5637 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane orion(a)nwra.com Boulder, CO 80301 https://www.nwra.com/

2 1

Processed: Re: Bug#1351: x2gothinclient-common: File conflict w/ x2gothinclient
by owner＠bugs.x2go.org 04 Dec '18

04 Dec '18

Processing commands for control(a)bugs.x2go.org: > reassign 1351 x2gothinclient Bug #1351 [x2gothinclient-common] x2gothinclient-common: File conflict w/ x2gothinclient Warning: Unknown package 'x2gothinclient-common' Bug reassigned from package 'x2gothinclient-common' to 'x2gothinclient'. No longer marked as found in versions 1.5.0.0-0x2go1+git20181202.691+9. Ignoring request to alter fixed versions of bug #1351 to the same values previously set > stop Stopping processing here. Please contact me if you need assistance. -- 1351: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1351 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#1352: x2gosetkeyboard does not use setxkbmap -config
by Ulrich Sibiller 04 Dec '18

04 Dec '18

Package: x2goserver Version: 4.1.0.3-0~1708~ubuntu16.04.1 x2gosetkeyboard has a complicated parsing loop for the keyboard file that x2goagent created. Instead of using that loop to build a command line for setxkbmap it should simply run "setxkbmap -config ${X2GO_CLIENT_KBD_FILE}"

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev