x2go-dev

x2go-dev@lists.x2go.org

5397 discussions

Bug#1361: Fwd: [Bug 1665366] New: Cannot run AttributeError: module 'wx' has no attribute 'TaskBarIcon'
by Orion Poplawski 11 Jan '19

11 Jan '19

Package: pyhoca-gui -------- Forwarded Message -------- Subject: [Bug 1665366] New: Cannot run AttributeError: module 'wx' has no attribute 'TaskBarIcon' Date: Fri, 11 Jan 2019 07:15:55 +0000 From: bugzilla(a)redhat.com To: orion(a)nwra.com https://bugzilla.redhat.com/show_bug.cgi?id=1665366 Bug ID: 1665366 Summary: Cannot run AttributeError: module 'wx' has no attribute 'TaskBarIcon' Product: Fedora Version: 29 Hardware: x86_64 OS: Linux Status: NEW Component: pyhoca-gui Severity: high Assignee: orion(a)nwra.com Reporter: rastislav.janci(a)gmail.com QA Contact: extras-qa(a)fedoraproject.org CC: orion(a)nwra.com Target Milestone: --- Classification: Fedora Description of problem: Cannot execute puhoca-gui application because of the changes in wxpython4 - wx.TaskBarIcon is moved to wx.adv.TaskBarIcon Version-Release number of selected component (if applicable): pyhoca-gui-0.5.0.7-6.fc29.noarch python3-cups-1.9.72-22.fc29.x86_64 python3-setproctitle-1.1.10-9.fc29.x86_64 python3-gobject-base-3.30.4-1.fc29.x86_64 python3-wxpython4-4.0.1-9.fc29.x86_64 python3-x2go-0.6.0.2-1.fc29.noarch How reproducible: run pyhoca-gui Steps to Reproduce: 1. Open command line 2. run pyhoca-gui Actual results: Traceback (most recent call last): File "/usr/bin/pyhoca-gui", line 35, in <module> from pyhoca.wxgui.launcher import PyHocaGUI_Launcher File "/usr/lib/python3.7/site-packages/pyhoca/wxgui/launcher.py", line 44, in <module> from .frontend import PyHocaGUI File "/usr/lib/python3.7/site-packages/pyhoca/wxgui/frontend.py", line 42, in <module> from . import taskbar File "/usr/lib/python3.7/site-packages/pyhoca/wxgui/taskbar.py", line 83, in <module> class PyHocaGUI_TaskBarIcon(wx.TaskBarIcon): AttributeError: module 'wx' has no attribute 'TaskBarIcon' Expected results: executed -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

1 0

Bug#1357: X2Go issue (in src:x2goserver) has been marked as pending for release
by Mike Gabriel 11 Jan '19

11 Jan '19

tag #1357 pending fixed #1357 4.1.0.4 thanks Hello, X2Go issue #1357 (src:x2goserver) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=d7c4222 The issue will most likely be fixed in src:x2goserver (4.1.0.4). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit d7c42225b52d42111b1220888c024ed4efe3b061 Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Date: Fri Jan 11 12:34:39 2019 +0100 debian/changelog: add bug closure for #1357 diff --git a/debian/changelog b/debian/changelog index 0526008..2547462 100644 --- a/debian/changelog +++ b/debian/changelog @@ -5,7 +5,7 @@ x2goserver (4.1.0.4-0x2go1) UNRELEASED; urgency=medium - Fix version number in VERSION.x2goserver-desktopsharing. - x2goserver-x2goagent: Drop x2goagent.keyboard file. - x2goversion: Fix situations where ${compfile} contains a - non-absolute path (e.g. it contains '../'). + non-absolute path (e.g. it contains '../'). (Fixes: #1357). * debian/x2goserver.postinst: + Drop duplicate sourcing of debconf includes.

2 1

Processed: tags 1358 rpm-packages
by owner＠bugs.x2go.org 09 Jan '19

09 Jan '19

Processing commands for control(a)bugs.x2go.org: > tags 1358 rpm-packages Bug #1358 [x2goclient] x2goclient for openSUSE 15.0 is missing Added tag(s) rpm-packages. > End of message, stopping processing here. Please contact me if you need assistance. -- 1358: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1358 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#1360: openSUSE RPM depends on obsolete (and nowadays missing) Perl
by Tristan Miller 09 Jan '19

09 Jan '19

Package: x2goserver Version: 4.1.0.4 Tag: rpm-packages The openSUSE Tumbleweed packages for x2goserver at <https://wiki.x2go.org/doku.php/wiki:repositories:suse> are not compatible with the version of Perl currently distributed by Tumbleweed. This makes it impossible to install them on Tumbleweed; if they are already installed then it makes it impossible to update Tumbleweed without uninstalling x2goserver. For example: $ sudo zypper update perl Loading repository data... Reading installed packages... There is an update candidate for 'perl', but it is from a different vendor. Use 'zypper install perl-5.28.1-169.5.x86_64' to install this candidate. Resolving package dependencies... Problem: x2goserver-xsession-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 requires perl(:MODULE_COMPAT_5.26.2), but this requirement cannot be provided deleted providers: perl-5.26.2-1.4.x86_64 Solution 1: Following actions will be done: deinstallation of x2goserver-xsession-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 deinstallation of x2goserver-common-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 deinstallation of x2goserver-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 deinstallation of perl-X2Go-Server-DB-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 deinstallation of perl-X2Go-Server-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 deinstallation of perl-X2Go-Log-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 deinstallation of x2goserver-extensions-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 Solution 2: do not install perl-5.28.1-1.1.x86_64 Solution 3: break x2goserver-xsession-4.1.0.4-0.0x2go1.0.git20181213.1753.heuler.x86_64 by ignoring some of its dependencies Choose from above solutions by number or cancel [1/2/3/c] (c):

1 0

Processed: tags 1338 rpm-packages
by owner＠bugs.x2go.org 09 Jan '19

09 Jan '19

Processing commands for control(a)bugs.x2go.org: > tags 1338 rpm-packages Bug #1338 [x2goclient] openSUSE Tumbleweed RPM builds against obsolete (and nowadays missing) libssh Added tag(s) rpm-packages. > End of message, stopping processing here. Please contact me if you need assistance. -- 1338: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1338 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#1338: Works for me now
by Tristan Miller 09 Jan '19

09 Jan '19

The official RPM has been working for me for a while now. Either someone applied my patch, or they applied a different patch with the same effect. Either way, if no one else is still experiencing this problem, then this bug can be closed.

1 0

Bug#1349: x2goclient not connecting after upgrade
by Javier Almasoft 03 Jan '19

03 Jan '19

Package: x2goclient Version: 4.1.2.1-3 x2goclient fails to connect to a working xgoserver, no matter the server version. The client machine is Archlinux 64, upgraded to the latest version (as of yesterday). I have downloaded and compiled from git the x2goclient sourcecode, but this compiled version don't work either. This is the log generated by x2goclient: --------------------------------------------------------------------------------------------- Copyright (c) 2014-2016 Mihai Moldovan <ionic(a)ionic.de> Copyright (c) 2011-2016 Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Copyright (c) 2015-2016 Qindel Group (http://www.qindel.com) NXCOMP, NX protocol compression and NX extensions to this software are copyright of the aforementioned persons and companies. Redistribution and use of the present software is allowed according to terms specified in the file LICENSE.nxcomp which comes in the source distribution. All rights reserved. NOTE: This software has received contributions from various other contributors, only the core maintainers and supporters are listed as copyright holders. Please contact us, if you feel you should be listed as copyright holder, as well. NX protocol compression is derived from DXPC project. Copyright (c) 1995,1996 Brian Pane Copyright (c) 1996,1997 Zachary Vonler and Brian Pane Copyright (c) 1999 Kevin Vigor and Brian Pane Copyright (c) 2000,2003 Gian Filippo Pinzari and Brian Pane All rights reserved. See https://github.com/ArcticaProject/nx-libs for more information. Info: Proxy running in server mode with pid '14626'. Session: Starting session at 'Fri Nov 23 13:26:45 2018'. Info: Using errors file '/home/xxxxx/.x2go/S-xxxxxxx-50-1542975996_stDLXDE_dp24/sessions'. Info: Using stats file '/home/xxxxx/.x2go/S-50/stats'. Loop: WARNING! Overriding auxiliary X11 port with new value '1'. Warning: Overriding auxiliary X11 port with new value '1'. Info: Using abstract X11 socket in kernel namespace for accessing DISPLAY=:0. Info: Connecting to remote host 'localhost:31001'. Info: Connected to remote proxy on FD#5. Loop: PANIC! Parse error in remote options string 'SSH-2.0-OpenSSH_6.7p1 '. Error: Parse error in remote options string 'SSH-2.0-OpenSSH_6.7p1 '. Loop: PANIC! Failure negotiating the session in stage '7'. Error: Failure negotiating the session in stage '7'. Loop: PANIC! Wrong version or invalid session authentication cookie. Error: Wrong version or invalid session authentication cookie. Session: Terminating session at 'Fri Nov 23 13:26:45 2018'. Versions of the relevant packages: nx3-all 3.5.0-4 nxproxy 3.5.99.16-2 x2goclient 4.1.2.1-3 libssh 0.8.5-1 libssh2 1.8.0-3 openssh 7.9p1-1 qt4 4.8.7-26 I can ssh the remote machines without problem, and pyhoca-cli also works correctly. Greetings, Javier Martínez

2 1

Re: [X2Go-Dev] [X2Go-Commits] [x2goclient] 01/01: Client now sends "login" parameter to the broker when executing task "selectsession". Before client just sent a username on the broker and it was imposiible to find out user name on X2Go server, which is not always the same as broker username. This won't break a compatibility with previous broker as they just will ignore this parameter.
by Mike Gabriel 21 Dec '18

21 Dec '18

Hi Alex, please explain the reasoning behind this API change in the SSH broker call. This commit currently breaks SSH brokerage in X2Go Session Broker and I would like to fix it. So, what do you intend with the additional --login option? How is the broker supposed to react? Mike On Mi 05 Sep 2018 14:25:44 CEST, git-admin wrote: > This is an automated email from the git hooks/post-receive script. > > x2go pushed a commit to branch master > in repository x2goclient. > > commit e7e74df029a1bd7d86a03c7f72f5b555eb6c5b0e > Author: Oleksandr Shneyder <o.shneyder(a)phoca-gmbh.de> > Date: Wed Sep 5 14:25:33 2018 +0200 > > Client now sends "login" parameter to the broker when executing > task "selectsession". Before client just sent a username on the > broker and it was imposiible to find out user name on X2Go server, > which is not always the same as broker username. This won't break a > compatibility with previous broker as they just will ignore this > parameter. > --- > debian/changelog | 5 +++++ > src/httpbrokerclient.cpp | 23 +++++++++++++++-------- > src/httpbrokerclient.h | 2 +- > src/onmainwindow.cpp | 2 +- > 4 files changed, 22 insertions(+), 10 deletions(-) > > diff --git a/debian/changelog b/debian/changelog > index dc01147..0a43c2d 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -17,6 +17,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium > - Broker can send to client command to suspend or terminate the > session as an > answer to the client event message. For this broker should > send to client > SUSPEND ID or TERMINATE ID. > + - Client now sends "login" parameter to the broker when executing task > + "selectsession". Before client just sent a username on the > broker and it was > + imposiible to find out user name on X2Go server, which is not > always the > + same as broker username. This won't break a compatibility > with previous > + broker as they just will ignore this parameter. > > [ Mihai Moldovan ] > * New upstream version (4.1.2.2): > diff --git a/src/httpbrokerclient.cpp b/src/httpbrokerclient.cpp > index 6110866..02a69c9 100644 > --- a/src/httpbrokerclient.cpp > +++ b/src/httpbrokerclient.cpp > @@ -313,9 +313,9 @@ void HttpBrokerClient::getUserSessions() > } > } > > -void HttpBrokerClient::selectUserSession(const QString& session) > +void HttpBrokerClient::selectUserSession(const QString& session, > const QString& loginName) > { > - x2goDebug<<"Called selectUserSession for session "<<session<<"."; > + x2goDebug<<"Called selectUserSession for session "<<session<<", > "<<"loginName "<<loginName; > QString brokerUser=config->brokerUser; > if(mainWindow->getUsePGPCard()) > brokerUser=mainWindow->getCardLogin(); > @@ -329,6 +329,10 @@ void HttpBrokerClient::selectUserSession(const > QString& session) > > "user="<<QUrl::toPercentEncoding(brokerUser)<<"&"<< > > "password="<<QUrl::toPercentEncoding(config->brokerPass)<<"&"<< > "authid="<<nextAuthId; > + if(loginName.length()>0) > + { > + QTextStream ( &req ) > <<"&login="<<QUrl::toPercentEncoding(loginName); > + } > x2goDebug << "Sending request: "<< req.toUtf8(); > QNetworkRequest request(QUrl(config->brokerurl)); > request.setHeader(QNetworkRequest::ContentTypeHeader, > "application/x-www-form-urlencoded"); > @@ -337,13 +341,16 @@ void HttpBrokerClient::selectUserSession(const > QString& session) > } > else > { > - if (nextAuthId.length() > 0) { > - sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser +" --authid "+nextAuthId+ " --task > selectsession --sid \""+session+"\"", > - this,SLOT ( > slotSelectSession(bool,QString,int))); > - } else { > - sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser +" --task selectsession --sid \""+session+"\"", > - this,SLOT ( > slotSelectSession(bool,QString,int))); > + QString sshCmd=config->sshBrokerBin+" --user "+ brokerUser > + " --task selectsession --sid \""+session+"\""; > + if(nextAuthId.length() > 0) > + { > + sshCmd+=" --authid "+nextAuthId; > + } > + if(loginName.length() > 0) > + { > + sshCmd+=" --login " + loginName; > } > + sshConnection->executeCommand (sshCmd, this,SLOT ( > slotSelectSession(bool,QString,int))); > } > > } > diff --git a/src/httpbrokerclient.h b/src/httpbrokerclient.h > index 24f52f3..73ae2ef 100644 > --- a/src/httpbrokerclient.h > +++ b/src/httpbrokerclient.h > @@ -41,7 +41,7 @@ class HttpBrokerClient: public QObject > public: > HttpBrokerClient ( ONMainWindow* wnd, ConfigFile* cfg ); > ~HttpBrokerClient(); > - void selectUserSession(const QString& session ); > + void selectUserSession(const QString& session, const QString& > loginName); > void changePassword(QString newPass); > void testConnection(); > void closeSSHInteractionDialog(); > diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp > index 8aa5078..52e765c 100644 > --- a/src/onmainwindow.cpp > +++ b/src/onmainwindow.cpp > @@ -3325,7 +3325,7 @@ void ONMainWindow::slotSessEnter() > return; > } > #endif > - broker->selectUserSession(sessionExplorer->getLastSession()->id()); > + > broker->selectUserSession(sessionExplorer->getLastSession()->id(),login->text()); > config.session=sessionExplorer->getLastSession()->id(); > setStatStatus ( tr ( "Connecting to broker" ) ); > stInfo->insertPlainText ( "broker url: "+config.brokerurl ); > > -- > Alioth's > /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on > /srv/git/code.x2go.org/x2goclient.git > _______________________________________________ > x2go-commits mailing list > x2go-commits(a)lists.x2go.org > https://lists.x2go.org/listinfo/x2go-commits -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de

2 5

Re: [X2Go-Dev] [X2Go-Commits] [x2goclient] 01/01: Add new brocker feature. Broker can send to client some configuration in the section START_CLIENT_CONFIG - END_CLIENT_CONFIG. For the moment is supported option events=bool. If true, client sending to broker events: CONNECTING, CONNECTED, SUSPENDING, TERMINATING, FINISHED. It's not a real session state, but rather the state of X2Go Client.
by Mike Gabriel 21 Dec '18

21 Dec '18

Hi Alex, how well is the below feature tested with current x2gobroker that does not yet understand this feature? I guess this patch is part of a paid project. Do you have budget for adapting x2gobroker on git.x2go.org, too? Otherwise, I'd much prefer this commit on an extra branch for now, until the x2gobroker is adapted to this, too. Ideally, your patch supports legacy brokers, which I assume it does... Greets, Mike On Di 21 Aug 2018 15:43:05 CEST, git-admin wrote: > This is an automated email from the git hooks/post-receive script. > > x2go pushed a commit to branch master > in repository x2goclient. > > commit 539e0a4268df3d78f88f6908506c18222743d84f > Author: Oleksandr Shneyder <o.shneyder(a)phoca-gmbh.de> > Date: Tue Aug 21 15:42:52 2018 +0200 > > Add new brocker feature. Broker can send to client some > configuration in the section START_CLIENT_CONFIG - > END_CLIENT_CONFIG. For the moment is supported option events=bool. > If true, client sending to broker events: CONNECTING, CONNECTED, > SUSPENDING, TERMINATING, FINISHED. It's not a real session state, > but rather the state of X2Go Client. > --- > debian/changelog | 5 +++ > src/httpbrokerclient.cpp | 86 > ++++++++++++++++++++++++++++++++++++++++++++++++ > src/httpbrokerclient.h | 5 +++ > src/onmainwindow.cpp | 86 > +++++++++++++++++++++++++++++++++++++++++++----- > src/onmainwindow.h | 15 ++++++++- > 5 files changed, 187 insertions(+), 10 deletions(-) > > diff --git a/debian/changelog b/debian/changelog > index 5e22cd3..b0c0449 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -3,6 +3,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium > [ Oleksandr Shneyder ] > * New upstream version (4.1.2.2): > - Add SSH instruction to list of errors if keyboard-interactive > auth has failed. > + - Add new brocker feature. Broker can send to client some > configuration in > + the section START_CLIENT_CONFIG - END_CLIENT_CONFIG. For the > moment is supported > + option events=bool. If true, client sending to broker events: > CONNECTING, > + CONNECTED, SUSPENDING, TERMINATING, FINISHED. It's not a real > session state, > + but rather the state of X2Go Client. > > [ Mihai Moldovan ] > * New upstream version (4.1.2.2): > diff --git a/src/httpbrokerclient.cpp b/src/httpbrokerclient.cpp > index f7fbaf1..ea5158e 100644 > --- a/src/httpbrokerclient.cpp > +++ b/src/httpbrokerclient.cpp > @@ -270,6 +270,7 @@ void > HttpBrokerClient::slotSshUserAuthError(QString error) > return; > } > > + > void HttpBrokerClient::getUserSessions() > { > QString brokerUser=config->brokerUser; > @@ -347,6 +348,66 @@ void HttpBrokerClient::selectUserSession(const > QString& session) > > } > > +void HttpBrokerClient::sendEvent(const QString& ev, const QString& > id, const QString& server, const QString& client, const QString& > login, const QString& cmd, const QString& display, const QString& > start) > +{ > + x2goDebug<<"Called sendEvent."; > + QString brokerUser=config->brokerUser; > + if(mainWindow->getUsePGPCard()) > + brokerUser=mainWindow->getCardLogin(); > + > + if(!sshBroker) > + { > + QString req; > + QTextStream ( &req ) << > + "task=clientevent&"<< > + > "user="<<QUrl::toPercentEncoding(brokerUser)<<"&"<< > + "sid="<<id<<"&"<< > + "event="<<ev<<"&"<< > + > "server="<<QUrl::toPercentEncoding(server)<<"&"<< > + > "client="<<QUrl::toPercentEncoding(client)<<"&"<< > + "login="<<QUrl::toPercentEncoding(login)<<"&"<< > + "cmd="<<QUrl::toPercentEncoding(cmd)<<"&"<< > + > "display="<<QUrl::toPercentEncoding(display)<<"&"<< > + "start="<<QUrl::toPercentEncoding(start)<<"&"<< > + "authid="<<nextAuthId; > + x2goDebug << "Sending request: "<< req.toUtf8(); > + QNetworkRequest request(QUrl(config->brokerurl)); > + request.setHeader(QNetworkRequest::ContentTypeHeader, > "application/x-www-form-urlencoded"); > + eventRequest=http->post (request, req.toUtf8() ); > + > + } > + else > + { > + if (nextAuthId.length() > 0) { > + sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser +" --authid "+nextAuthId+ > + " --task clientevent --sid \""+id+"\" --event "+ev+" > --server \""+server+"\" --client \""+client+"\" --login "+"\""+ > + login+"\" --cmd \""+cmd+"\" --display \""+display+"\" > --start \""+start+"\"", > + this,SLOT ( slotEventSent(bool,QString,int))); > + } else { > + sshConnection->executeCommand ( config->sshBrokerBin+" > --user "+ brokerUser + > + " --task clientevent --sid \""+id+"\" --event "+ev+" > --server \""+server+"\" --client \""+client+"\" --login "+"\""+ > + login+"\" --cmd \""+cmd+"\" --display\" "+display+" \" > --start \""+start+"\"", > + this,SLOT ( slotEventSent(bool,QString,int))); > + } > + } > +} > + > + > +void HttpBrokerClient::slotEventSent(bool success, QString answer, int) > +{ > + if(!success) > + { > + x2goDebug<<answer; > + QMessageBox::critical(0,tr("Error"),answer); > + emit fatalHttpError(); > + return; > + } > + if(!checkAccess(answer)) > + return; > + x2goDebug<<"event sent:"<<answer; > +} > + > + > void HttpBrokerClient::changePassword(QString newPass) > { > newBrokerPass=newPass; > @@ -405,6 +466,16 @@ void HttpBrokerClient::testConnection() > } > } > > +void HttpBrokerClient::processClientConfig(const QString& raw_content) > +{ > + X2goSettings st(raw_content, QSettings::IniFormat); > + > mainWindow->config.brokerEvents=st.setting()->value("events",false).toBool(); > + if(mainWindow->config.brokerEvents) > + { > + x2goDebug<<"sending client events to broker"; > + } > +} > + > > void HttpBrokerClient::createIniFile(const QString& raw_content) > { > @@ -420,6 +491,17 @@ void HttpBrokerClient::createIniFile(const > QString& raw_content) > cont=cont.split("END_USER_SESSIONS\n")[0]; > } > mainWindow->config.iniFile=cont; > + lines=content.split("START_CLIENT_CONFIG\n"); > + if (lines.count()>1) > + { > + cont=lines[1]; > + cont=cont.split("END_CLIENT_CONFIG\n")[0]; > + processClientConfig(cont); > + } > + else > + { > + x2goDebug<<"no client config from broker"; > + } > } > > > @@ -540,6 +622,10 @@ void HttpBrokerClient::slotRequestFinished ( > QNetworkReply* reply ) > { > slotPassChanged(true,answer,0); > } > + if (reply == eventRequest) > + { > + slotEventSent(true,answer,0); > + } > > // We receive ownership of the reply object > // and therefore need to handle deletion. > diff --git a/src/httpbrokerclient.h b/src/httpbrokerclient.h > index 0a307e1..4e0098e 100644 > --- a/src/httpbrokerclient.h > +++ b/src/httpbrokerclient.h > @@ -45,6 +45,8 @@ public: > void changePassword(QString newPass); > void testConnection(); > void closeSSHInteractionDialog(); > + void sendEvent(const QString& ev, const QString& id, const > QString& server, const QString& client, > + const QString& login, const QString& cmd, const > QString& display, const QString& start); > private: > QNetworkAccessManager* http; > QNetworkRequest* netRequest; > @@ -53,6 +55,7 @@ private: > QNetworkReply* selSessRequest; > QNetworkReply* chPassRequest; > QNetworkReply* testConRequest; > + QNetworkReply* eventRequest; > QString nextAuthId; > QString newBrokerPass; > ConfigFile* config; > @@ -62,6 +65,7 @@ private: > SshMasterConnection* sshConnection; > private: > void createIniFile(const QString& raw_content); > + void processClientConfig(const QString& raw_content); > void parseSession(QString sInfo); > void createSshConnection(); > bool checkAccess(QString answer); > @@ -78,6 +82,7 @@ private slots: > void slotListSessions ( bool success, QString answer, int pid); > void slotSelectSession ( bool success, QString answer, int pid); > void slotPassChanged ( bool success, QString answer, int pid); > + void slotEventSent ( bool success, QString answer, int pid); > void slotConnectionTest( bool success, QString answer, int pid); > void slotSshIoErr(SshProcess* caller, QString error, QString > lastSessionError); > > diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp > index 405b124..d547248 100644 > --- a/src/onmainwindow.cpp > +++ b/src/onmainwindow.cpp > @@ -3548,6 +3548,12 @@ void ONMainWindow::startDirectRDP() > resumingSession.sessionId=sessionExplorer->getLastSession()->name(); > > resumingSession.crTime=QDateTime::currentDateTime().toString("dd.MM.yy > HH:mm:ss"); > showSessionStatus(); > + if(brokerMode) > + { > + > sendEventToBroker(CONNECTING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > + > // QTimer::singleShot ( 30000,this,SLOT ( slotRestartProxy() ) ); > proxyRunning=true; > delete st; > @@ -3991,6 +3997,31 @@ x2goSession > ONMainWindow::getSessionFromString ( const QString& string ) > } > > > +void ONMainWindow::sendEventToBroker(ONMainWindow::client_events > ev, const QString& id, const QString& server, const QString& client, > const QString& login, const QString& cmd, const QString& display, > const QString& start) > +{ > + if(!config.brokerEvents) > + { > + return; > + } > + if(ev <= lastBrokerEvent && id == lastBrokerEventSession ) > + { > + return; > + } > + lastBrokerEvent=ev; > + lastBrokerEventSession=id; > + QString event; > + switch(ev) > + { > + case CONNECTING: event="CONNECTING";break; > + case CONNECTED: event="CONNECTED";break; > + case SUSPENDING: event="SUSPENDING";break; > + case TERMINATING: event="TERMINATING";break; > + case FINISHED: event="FINISHED";break; > + } > + broker->sendEvent(event, id, server, client, login, cmd, > display, start); > +} > + > + > void ONMainWindow::startNewSession() > { > newSession=true; > @@ -5025,6 +5056,11 @@ void ONMainWindow::slotSuspendSess() > void ONMainWindow::slotSuspendSessFromSt() > { > > + if(brokerMode) > + { > + > sendEventToBroker(SUSPENDING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > #ifdef Q_OS_LINUX > if (directRDP) > { > @@ -5053,6 +5089,11 @@ void ONMainWindow::slotTermSessFromSt() > if (directRDP) > { > > + if(brokerMode) > + { > + > sendEventToBroker(TERMINATING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > x2goDebug<<"Terminating direct RDP session."; > > nxproxy->terminate(); > @@ -5061,20 +5102,30 @@ void ONMainWindow::slotTermSessFromSt() > } > #endif > > - x2goDebug<<"Disconnect export."; > - > - /* > - disconnect ( sbExp,SIGNAL ( clicked() ),this, > - SLOT ( slot_exportDirectory() ) );*/ > - sbExp->setEnabled ( false ); > > if ( !shadowSession ) > { > if ( termSession ( resumingSession.sessionId ) ) > + { > + sbExp->setEnabled ( false ); > + if(brokerMode) > + { > + > sendEventToBroker(TERMINATING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > setStatStatus ( tr ( "terminating" ) ); > + } > } > else > + { > + sbExp->setEnabled ( false ); > + if(brokerMode) > + { > + > sendEventToBroker(TERMINATING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > termSession ( resumingSession.sessionId,false ); > + } > } > > > @@ -5812,6 +5863,12 @@ void ONMainWindow::slotTunnelOk(int) > > nxproxy->start ( proxyCmd ); > proxyRunning=true; > + if(brokerMode) > + { > + > sendEventToBroker(CONNECTING,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > + > // always search for proxy window on linux. On Windows only in window mode > #ifdef Q_OS_WIN > if (xorgMode==WIN) { > @@ -6087,7 +6144,11 @@ void ONMainWindow::slotProxyError ( > QProcess::ProcessError err ) > > void ONMainWindow::slotProxyFinished ( int,QProcess::ExitStatus ) > { > - > + if(brokerMode) > + { > + > sendEventToBroker(FINISHED,resumingSession.sessionId,resumingSession.server, > resumingSession.clientIp, getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > #ifdef Q_OS_DARWIN > if (modMapTimer) { > disconnect (modMapTimer, SIGNAL (timeout ()), this, SLOT > (slotSetModMap ())); > @@ -6288,9 +6349,11 @@ void ONMainWindow::slotProxyStderr() > stInfo->insertPlainText ( reserr ); > stInfo->ensureCursorVisible(); > if ( stInfo->toPlainText().indexOf ( > - "Connecting to remote host 'localhost:"+ > - /*resumingSession.grPort*/ localGraphicPort ) !=-1 ) > + "Connecting to remote host 'localhost:"+ > + /*resumingSession.grPort*/ localGraphicPort ) !=-1 ) > + { > setStatStatus ( tr ( "connecting" ) ); > + } > > if ( stInfo->toPlainText().indexOf ( > "Connection to remote proxy 'localhost:"+ > @@ -6310,6 +6373,11 @@ void ONMainWindow::slotProxyStderr() > if ( stInfo->toPlainText().indexOf ( > "Established X server connection" ) !=-1 ) > { > + if(brokerMode) > + { > + > sendEventToBroker(CONNECTED,resumingSession.sessionId,resumingSession.server, resumingSession.clientIp, > getCurrentUname(), > + resumingSession.command, > resumingSession.display, resumingSession.crTime); > + } > setStatStatus ( tr ( "running" ) ); > if (trayEnabled) > { > diff --git a/src/onmainwindow.h b/src/onmainwindow.h > index 47eaa5e..a1fab35 100644 > --- a/src/onmainwindow.h > +++ b/src/onmainwindow.h > @@ -169,6 +169,7 @@ struct ConfigFile > bool brokerAutologin; > bool brokerAutologoff; > bool brokerKrbLogin; > + bool brokerEvents; //Send events to broker and get control commands > QString brokerSshKey; > QString brokerCaCertFile; > QString iniFile; > @@ -300,6 +301,14 @@ public: > UNKNOWN_KEY_TYPE > }; > > + enum client_events { > + CONNECTING, > + CONNECTED, > + SUSPENDING, > + TERMINATING, > + FINISHED > + }; > + > static bool debugging; > > static bool portable; > @@ -859,6 +868,8 @@ private: > int lastUid; > bool cardReady; > HttpBrokerClient* broker; > + client_events lastBrokerEvent; > + QString lastBrokerEventSession; > > > #if defined ( Q_OS_WIN) //&& defined (CFGCLIENT ) > @@ -899,7 +910,9 @@ private: > bool trayMinCon; > bool trayMaxDiscon; > bool trayAutoHidden; > - > + void sendEventToBroker(client_events ev, const QString& id, > const QString& server, const QString& client, > + const QString& login, const QString& cmd, > + const QString& display, const QString& start); > QString findSshKeyForServer(QString user, QString server, QString port); > void loadSettings(); > void showPass ( UserButton* user ); > > -- > Alioth's > /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on > /srv/git/code.x2go.org/x2goclient.git > _______________________________________________ > x2go-commits mailing list > x2go-commits(a)lists.x2go.org > https://lists.x2go.org/listinfo/x2go-commits -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de

2 4

Bug#1355: x2godesktopsharing applet starts multiple times in KDE Plasma if restore desktop is set
by Mike Gabriel 15 Dec '18

15 Dec '18

Package: x2godesktopsharing Severity: important Version: 3.2.0.0 X-Debbugs-Cc: josesan(a)gmail.com Hi, I turn this thread into an official bug report... On So 09 Dez 2018 13:59:02 CET, Víctor J. Sánchez E. wrote: > > El mié., 5 dic. 2018 a las 15:09, Víctor J. Sánchez (<vjosesan(a)gmail.com>) > escribió: > >> Hi all, >> >> I recently installed x2godesktopsharing via X2Go repositories for Debian. >> The installation asked me about activate the auto-start feature (I said >> yes) and enable shared desktop (I said no). When I reboot the machine in >> KDE Plasma desktop I see two x2godesktopsharing applets in system tray and >> the next error message is displayed (translated into english): >> >> *The application X2Go DesktopSharing is already active for this screen* >> >> *if it doesn't run remove /tmp/x2godesktopsharing.lock_USER@:0 and start >> it up again* >> >> I don't know about x2godesktopsharing is started because I can't find >> anything in the documentation about it. I only see the file >> /etc/xdg/autostart/x2godesktopsharing.desktop but I don't see any system >> service (systemctl) nor KDE Plasma desktop's startup service or script. >> >> How could I resolve this issue? >> >> Some data about my system: >> >> - Debian testing (amd64), kernel 4.18.0-3-amd64 >> >> - KDE Plasma 5.14.3 >> >> - x2godesktopsharing 3.2.0.0 >> >> Thanks in advance. >> > Hi all again, > > after investigate deeper about this issue I noted that every log in in KDE > Plasma session the number of x2godesktopsharing applets were increasing in > system tray (until 5 applets or more!!). > I discovered that the restore of KDE Plasma session setting was inexplicably > resetted (may due to an update). I set it again to starts an empty session > and the problem has gone. Now it only starts only one x2godesktopsharing > system tray applet. > The setting is in KDE System Settings -> Startup and Shutdown -> Desktop > Session -> On Login switch to "Start with an empty session" instead of > "Restore previous session". > > Regards. > > ---- This looks like we should hinder x2godesktopsharing from starting a second instance when there is one already running for the same $DISPLAY. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev