x2go-dev

x2go-dev@lists.x2go.org

2 participants
5403 discussions

Bug#182: x2gobroker-authservice: missing imports
by Anders Bruun Olsen 19 Apr '13

19 Apr '13

Package: x2gobroker-authservice Version: git/master x2gobroker-authservice uses getpwnam() and getgrnam() but does not import them. from pwd import getpwnam from grp import getgrnam -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature)

3 2

Bug#177: New patch for this feature
by Ricardo Díaz Martín 19 Apr '13

19 Apr '13

This patch fix the bug when x2goclient setting show in trayicon is setted to false. I introduce extra feature: a trayicon message is showed while x2go session selectors are minimized to trayicon and x2go session has not window yet. If somebody thinks it's not a good idea please let me know. Regards, --

1 0

autologin with x2goclient in broker-mode: analysis and fix for "enter passphrase"-bug
by Anders Bruun Olsen 19 Apr '13

19 Apr '13

Hi guys, I just spent most of the day digging through source code for x2goclient (reminds my why I code Python rather than C++ :) ), trying to understand why the "enter passphrase" dialog box appears when the broker is set to do autologin. Summary of the bug: x2gobroker can be setup to do autologin of users, to avoid users having to enter their credentials twice. This is accomplished by the broker placing a temporary SSH public key in $HOME/.x2go/authorized_keys and handing the matching private key to the client. This temporary key is then removed after a short while. Unfortunately, on all machines I have tested with, including thinclients, x2goclient pops up a dialog box with the text "Enter passphrase to decrypt a key" after authenticating against the broker and choosing a session with autologin enabled. Pressing cancel on this dialog box will on my desktop machine result in the autologin completing and getting logged in. However on the x2gothinclient I tested with, the dialog box would just pop up again and again and login would never occur. Analysis of the bug: When autologin is enabled, SshMasterConnection::userAuth() will react by calling userAuthAuto(), which will look for ssh keys and if you, like me, have an ssh key with a passphrase, it will want to try out this key by asking for the passphrase (despite having ssh-agent running). If it does not find a key, it also asks for a passphrase, at least on my system. The reasons for this aren't really important here, in my oppinion. The important question here is why it even looks for other keys when the nice broker has provided a key. Further analysis and testing showed me that after userAuthAuto() exists without having gotten a proper key loaded (by pressing Cancel on the dialog box), userAuth() will then test if a key is loaded. And because httpbrokerclient has recieved a key and put it into the config-variable, a key IS available. This key is then used for login and all is good. Looking closer at the code revealed that setting config->autologin to true was actually not needed at all, and is the culprit here. If autologin is false, then userAuth() will still see that there is a key loaded, and happily log in the user. My naive fix for this bug: In ONMainWindow::startSession(), make setting the autologin variable dependent upon not being in brokerMode: diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 31dbc17..bc2b70f 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -3249,8 +3249,9 @@ bool ONMainWindow::startSession ( const QString& sid ) QString cmd=st->setting()->value ( sid+"/command", ( QVariant ) QString::null ).toString(); - autologin=st->setting()->value ( sid+"/autologin", - ( QVariant ) false ).toBool(); + if (!brokerMode) + autologin=st->setting()->value ( sid+"/autologin", + ( QVariant ) false ).toBool(); krblogin=st->setting()->value ( sid+"/krblogin", ( QVariant ) false ).toBool(); #ifdef Q_OS_LINUX I can't say what other consequences this might have, not knowing the code well enough, but initial tests on my system shows that it works. This patch is against git/master btw. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature)

1 0

Processed: your mail
by owner＠bugs.x2go.org 19 Apr '13

19 Apr '13

Processing commands for control(a)bugs.x2go.org: > reassign #178 x2goclient Bug #178 [x2go client] X2Go client on Windows reports: Couldn't create pid file "/var/run/sshd.pid": No such file or directory Warning: Unknown package 'x2go' Warning: Unknown package 'client' Bug reassigned from package 'x2go client' to 'x2goclient'. No longer marked as found in versions 4.0.0.3. Ignoring request to alter fixed versions of bug #178 to the same values previously set > found #178 4.0.0.3 Bug #178 [x2goclient] X2Go client on Windows reports: Couldn't create pid file "/var/run/sshd.pid": No such file or directory There is no source info for the package 'x2goclient' at version '4.0.0.3' with architecture '' Unable to make a source version for version '4.0.0.3' Marked as found in versions 4.0.0.3. > thanks Stopping processing here. Please contact me if you need assistance. -- 178: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=178 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#179: x2goclient in broker-mode does not allow logout
by Anders Bruun Olsen 19 Apr '13

19 Apr '13

Package: x2goclient Version: 4.0.1.0 When you have logged in to a server in broker-mode, there is no way to de-authenticate from the broker, other than closing x2goclient. This is not a problem on a normal desktop machine, but on thinclients, it is not really possible to close x2goclient, other than rebooting/shutting down the machine. This means that users can't go to a thinclient, login and work, logout and walk away from the machine to allow a different user to use it, without rebooting the machine after having logged out. This is not acceptable behavior for a thinclient setup. I think logging out of an x2goserver should also trigger a deauthenticate from the broker, as this mimicks the way x2goclient works when not in broker-mode. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature)

3 2

Bug#180: x2gobroker-authservice needs missing conf
by Anders Bruun Olsen 19 Apr '13

19 Apr '13

Package: x2gobroker Version: git/master After moving x2gobroker-authservice logging away from x2gobroker-daemon logging, authservice now wants it's own logger config, by default called /etc/x2go/broker/x2gobroker-authservice-logger.conf, but this file is not installed by the deb-package and does not exist anywhere in git. This hinders authservice from starting. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature)

3 2

Bug#161: Redhat's bugzilla mentions a similar issue...
by Mike Gabriel 19 Apr '13

19 Apr '13

tag #161 moreinfo thanks Hi Orion, May the issue be related to this bug report? https://bugzilla.redhat.com/show_bug.cgi?id=830406 Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

4 5

Bug#177: Fwd: x2goclient new trayicon feature
by Ricardo Díaz Martín 18 Apr '13

18 Apr '13

Package: x2goclient Severity: wishlist Tag: patch For users with multiple server connections it will be nice if x2goclient tray icon show the session icon. So I attach a patch to do it.

1 0

Bug#176: x2gobroker: error 405 when accessing /pubkeys/
by Anders Bruun Olsen 18 Apr '13

18 Apr '13

Package: x2gobroker Version: 0.0.1.0-0~334~precise1 When adding x2gobroker public keys to x2goservers you run x2gobroker-pubkeyauthorizer, which is supposed to grab public keys from http://broker.intern:8080/pubkeys/, but that url returns "405 Method Not Allowed". Probably something went wrong when porting code to Tornado. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature)

3 2

Bug#173: Issues already fixed in Vcs
by Mike Gabriel 18 Apr '13

18 Apr '13

tag #173 pending tag #174 pending fixed #173 0.0.1.1 fixed #174 0.0.1.1 thanks Hi Anders, both dependency issues are already fixed in Vcs. It would be good if you could cross check the issues you find in the broker's Git repository [1] (checking of master branch should suffice). Greets, Mike [1] http://code.x2go.org/gitweb?p=x2gobroker.git;a=summary -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev