x2go-dev

x2go-dev@lists.x2go.org

5399 discussions

Automatic pending tags for X2Go bug fixing via Git commits
by Mike Gabriel 22 Apr '13

22 Apr '13

Hi All, I have added an automation mechanism for tagging bugs as pending. That is: o fix a bug o add your debian/changelog entry (as most of you know, the X2Go upstream abuses debian/changelog as upstream changelog because of the nice changelog tools in Debian) o add (Fixes: #nnn) at the end of a changelog entry with #nnn as the bug number you have fixed o push your changes to git.x2go.org On the Git server there is a post-receive hook waiting for such changelog entries and if one is spotted, it will generate a mail likes this [1]. light+love, Mike [1] http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=164#15 -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 1

Bug#164: X2Go issue #164 (x2goclient) has been marked as pending for release
by Mike Gabriel 22 Apr '13

22 Apr '13

tag #164 pending fixed #164 4.0.1.1 thanks Hello, X2Go issue #164 (project: x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=/x2goclient.git;a=commitdiff;h=56c9d3a The issue will be most probably be fixed in x2goclient (4.0.1.1). light+love X2Go Git Admin --- commit 56c9d3ab2021549fc2fede7f5bceac0af342fc73 Author: Orion Poplawski <orion(a)cora.nwra.com> Date: Mon Apr 22 16:25:48 2013 +0200 Instead of using a hard-code DPI of 96, use local DPI settings for new sessions if not explicitly set in session profile (Fixes: #164). diff --git a/debian/changelog b/debian/changelog index 9be4d80..94d57e2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -12,6 +12,11 @@ x2goclient (4.0.1.1-0~x2go1) UNRELEASED; urgency=low Let's consider a given SSH private key that fails to log the user in as an overall login failure. (Fixes: 141). + [ Orion Poplawski ] + * New upstream version (4.0.1.0): + - Instead of using a hard-code DPI of 96, use local DPI settings for new + sessions if not explicitly set in session profile (Fixes: #164). + -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Fri, 22 Mar 2013 23:21:11 +0100 x2goclient (4.0.1.0-0~x2go1) unstable; urgency=low

2 1

Bug#164: X2Go issue #164 (/x2goclient) has been marked as pending for release
by Mike Gabriel 22 Apr '13

22 Apr '13

tag #164 pending fixed #164 4.0.1.1 thanks Hello, X2Go issue #164 (project: /x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=/x2goclient.git;a=commitdiff;h=56c9d3a The issue will be most probably be fixed in /x2goclient (4.0.1.1). light+love X2Go Git Admin --- commit 56c9d3ab2021549fc2fede7f5bceac0af342fc73 Author: Orion Poplawski <orion(a)cora.nwra.com> Date: Mon Apr 22 16:25:48 2013 +0200 Instead of using a hard-code DPI of 96, use local DPI settings for new sessions if not explicitly set in session profile (Fixes: #164). diff --git a/debian/changelog b/debian/changelog index 9be4d80..94d57e2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -12,6 +12,11 @@ x2goclient (4.0.1.1-0~x2go1) UNRELEASED; urgency=low Let's consider a given SSH private key that fails to log the user in as an overall login failure. (Fixes: 141). + [ Orion Poplawski ] + * New upstream version (4.0.1.0): + - Instead of using a hard-code DPI of 96, use local DPI settings for new + sessions if not explicitly set in session profile (Fixes: #164). + -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Fri, 22 Mar 2013 23:21:11 +0100 x2goclient (4.0.1.0-0~x2go1) unstable; urgency=low

2 1

State of bug #179
by Anders Bruun Olsen 22 Apr '13

22 Apr '13

Hi guys, As some of you may know, I am currently testing out an x2go setup with x2gobroker and two x2goservers, with users on thinclients. Thanks to fast and very competent bugfixing from, amongst others, Mike, this setup is now in a usable state. However, bug #179 is keeping me from rolling out to my test-users. So now my question is, is there anybody actively working on this bug? I am expecting to write a guide/case study to running an x2go setup like mine, but I can't write such a guide until I have everything tested by real users. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature)

2 1

Processed: Bug#164 marked as pending
by owner＠bugs.x2go.org 22 Apr '13

22 Apr '13

Processing commands for control(a)bugs.x2go.org: > tag 164 pending Bug #164 [x2goclient] Set DPI to same as local display by default Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 164: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=164 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

x2goclient git/master does not compile
by Anders Bruun Olsen 22 Apr '13

22 Apr '13

Hi Mike, Your latest commit defines the file debian/upstream/changelog, which does not exist. Build therefore fails. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature)

2 1

Processed: your mail
by owner＠bugs.x2go.org 21 Apr '13

21 Apr '13

Processing commands for control(a)bugs.x2go.org: > tag #177 patch Bug #177 [x2goclient] Fwd: x2goclient new trayicon feature Added tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 177: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=177 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Processed: your mail
by owner＠bugs.x2go.org 21 Apr '13

21 Apr '13

Processing commands for control(a)bugs.x2go.org: > tag #142 patch Bug #142 [x2goclient] x2goclient output on stdout Added tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 142: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=142 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#184: x2goclient behaviour in cases where SSH pubkeys are not found
by Mike Gabriel 21 Apr '13

21 Apr '13

Hi Alex, hi Devs, But #184 is a clone of #141 with a different topic now: x2goclient behaviour in cases where SSH pubkeys are not found during the investigation of a fix for #141 [1] I found out this: o in session profile, specify a key file that does not exist o start a session -> x2goclient will ask you for the (non-existent) keys passphrase Better: an error message should be thrown that informs the user correctly Something similar happens if autologin==true and the user does not have a key loaded in ssh-agent nor does he have some default SSH key files in his $HOME/.ssh: o start a session -> x2goclient will ask you for the (non-existent) keys passphrase Better: an error message should be thrown that informs the user correctly [1] http://bugs.x2go.org/141 Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

Bug#141: Fwd: autologin with x2goclient in broker-mode: analysis and fix for "enter passphrase"-bug
by Mike Gabriel 21 Apr '13

21 Apr '13

tag #141 - moreinfo thanks Detailed analysis from Anders below... ----- Weitergeleitete Nachricht von abo(a)dsl.dk ----- Datum: Fri, 19 Apr 2013 16:16:47 +0200 Von: Anders Bruun Olsen <abo(a)dsl.dk> Antwort an: x2go-dev(a)lists.berlios.de Betreff: [X2Go-Dev] autologin with x2goclient in broker-mode: analysis and fix for "enter passphrase"-bug An: x2go-dev <x2go-dev(a)lists.berlios.de> Hi guys, I just spent most of the day digging through source code for x2goclient (reminds my why I code Python rather than C++ :) ), trying to understand why the "enter passphrase" dialog box appears when the broker is set to do autologin. Summary of the bug: x2gobroker can be setup to do autologin of users, to avoid users having to enter their credentials twice. This is accomplished by the broker placing a temporary SSH public key in $HOME/.x2go/authorized_keys and handing the matching private key to the client. This temporary key is then removed after a short while. Unfortunately, on all machines I have tested with, including thinclients, x2goclient pops up a dialog box with the text "Enter passphrase to decrypt a key" after authenticating against the broker and choosing a session with autologin enabled. Pressing cancel on this dialog box will on my desktop machine result in the autologin completing and getting logged in. However on the x2gothinclient I tested with, the dialog box would just pop up again and again and login would never occur. Analysis of the bug: When autologin is enabled, SshMasterConnection::userAuth() will react by calling userAuthAuto(), which will look for ssh keys and if you, like me, have an ssh key with a passphrase, it will want to try out this key by asking for the passphrase (despite having ssh-agent running). If it does not find a key, it also asks for a passphrase, at least on my system. The reasons for this aren't really important here, in my oppinion. The important question here is why it even looks for other keys when the nice broker has provided a key. Further analysis and testing showed me that after userAuthAuto() exists without having gotten a proper key loaded (by pressing Cancel on the dialog box), userAuth() will then test if a key is loaded. And because httpbrokerclient has recieved a key and put it into the config-variable, a key IS available. This key is then used for login and all is good. Looking closer at the code revealed that setting config->autologin to true was actually not needed at all, and is the culprit here. If autologin is false, then userAuth() will still see that there is a key loaded, and happily log in the user. My naive fix for this bug: In ONMainWindow::startSession(), make setting the autologin variable dependent upon not being in brokerMode: diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 31dbc17..bc2b70f 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -3249,8 +3249,9 @@ bool ONMainWindow::startSession ( const QString& sid ) QString cmd=st->setting()->value ( sid+"/command", ( QVariant ) QString::null ).toString(); - autologin=st->setting()->value ( sid+"/autologin", - ( QVariant ) false ).toBool(); + if (!brokerMode) + autologin=st->setting()->value ( sid+"/autologin", + ( QVariant ) false ).toBool(); krblogin=st->setting()->value ( sid+"/krblogin", ( QVariant ) false ).toBool(); #ifdef Q_OS_LINUX I can't say what other consequences this might have, not knowing the code well enough, but initial tests on my system shows that it works. This patch is against git/master btw. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature) ----- Ende der weitergeleiteten Nachricht ----- -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

2 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev