x2go-dev

x2go-dev@lists.x2go.org

1 participants
5399 discussions

Bug#1010: Slow repaint on window move (single application)
by Aki Ketolainen 31 Mar '17

31 Mar '17

Hi, I noticed yesterday that disabling "show window contents while moving" in Mate desktop and XFCE fix this behaviour. I haven't found the setting to do this in Unity, though. Also KDE, LXDE and Windows on the client side don't show this behaviour. @sunweaver on #x2go on freenode commented that "21:55 <@sunweaver> I guess a sustainabe fix is grabbing the window content client side and keep that static pixmap until movement is over." Best regards, Aki

1 0

Re: [X2Go-Dev] [X2Go-Commits] [x2goclient] 01/01: Don't override PATH for the actual session or application command. Fixes: #1100
by Mihai Moldovan 30 Mar '17

30 Mar '17

On 26.03.2017 06:11 PM, git-admin(a)x2go.org wrote: > This is an automated email from the git hooks/post-receive script. > > x2go pushed a commit to branch bugfix/1100 > in repository x2goclient. > > commit a7ed6868825c111f8d0fa4a64aa82115b8dab039 > Author: Mike DePaulo <mikedep333(a)gmail.com> > Date: Sun Mar 26 12:09:11 2017 -0400 > > Don't override PATH for the actual session or application command. Fixes: #1100 > --- > debian/changelog | 3 ++ > src/onmainwindow.cpp | 67 ++++++++++++++++++++++++++++----------------- > src/onmainwindow.h | 1 + > src/sshmasterconnection.cpp | 4 +-- > src/sshmasterconnection.h | 2 +- > src/sshprocess.cpp | 15 ++++++++-- > src/sshprocess.h | 2 +- > 7 files changed, 62 insertions(+), 32 deletions(-) > > diff --git a/debian/changelog b/debian/changelog > index 42c1e52..8e71aeb 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -180,6 +180,9 @@ x2goclient (4.1.0.1-0x2go1) UNRELEASED; urgency=medium > default because the installation dir is not writeable by > users) > + CVE-2017-6542 was fixed > + - Don't override PATH for the actual session or application > + command. > + Fixes: #1100 > > [ Seth Galitzer ] > * New upstream version (4.1.0.1): > diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp > index 5dd3906..0b15649 100644 > --- a/src/onmainwindow.cpp > +++ b/src/onmainwindow.cpp > @@ -6291,7 +6291,7 @@ void ONMainWindow::slotProxyStderr() > { > xmodExecuted=true; > QTimer::singleShot ( > - 2000, this, > + 4000, this, Why are you changing this? It's orthogonal to all the other changes. > SLOT ( slotExecXmodmap() ) ); > } > } > @@ -6700,6 +6700,39 @@ void ONMainWindow::slotAppDialog() > > void ONMainWindow::runCommand() > { > + > + if ( runRemoteCommand ) > + { > + /* 1st override PATH and determine the base path to x2goruncommand. Whitespace errors, you're mixing tabs and spaces here. > + * Then in SlotRunCommand, call x2goruncommand without overriding PATH. > + * This ensures that the PATH is never overriden with for the actual "overridden", remove "with" or specify. > + * user session. > + * Fixes: #1100 > + */ > + sshConnection->executeCommand ( "x2gobasepath", this, > + SLOT ( SlotRunCommand ( bool, > + QString, > + int )), true); > + } > +#ifdef Q_WS_HILDON > + //wait 5 seconds and execute xkbcomp > + QTimer::singleShot ( 5000, this, SLOT ( slotExecXmodmap() ) ); > +#endif We'll probably execute slotExecXmodmap a bit sooner than before with that change (since you're not doing it in SlotRunCommand - but that wouldn't work for XDMCP and Shadow sessions, since they don't set runRemoteCommand to true.) It's fine, I guess. I just noticed that the code in question is broken anyway - it wouldn't even compile on HILDON anymore, so let's ignore that. Otherwise looks good. Mihai

2 1

Bug#1167: Windows 7 runtime error - R6025 - pure virtual function, kills x2go client after Windows screen lock/unlock
by Petronic, Mark 29 Mar '17

29 Mar '17

Package: x2goclient Version: 4.1.0.0 Steps to reproduce: 1. Fire up x2go client 2. Establish a session 3. Session starts fine and all is well 3. Stop working and walk away and, due to IT policy, Windows screen will lock after 15 minutes of inactivity 4. Ctrl-Alt-Delete and log back into Windows 5. Find a popup error dialog indicating vcxsrv.exe crashed. The runtime error Windows popup message dialog says: ========================================================= Microsoft Visual C++ Runtime Library Program: C:\Users\mpetronic\<path-to-my-install>\VcXsrv\vcxsrv.exe R6025 - pure virtual function call ========================================================= I can also force the crash if, after I establish a working x2go session, I Ctrl-Alt-Delete and lock my desktop manually. Same crash occurs when I log back in. To recover, I have to close the x2go client and restart it then I can restart my session. On the server side, my session is restarted just fine. Everything I had open there is restored. So, this is really annoying in that, every time I walk away from my PC for a short time, I know I have to reestablish all my sessions due to this crash. I have further experimented and found this crash ONLY occurs when I run in -rootless configuration. I use that so that Alt-Tab works properly in my X session otherwise, when I Alt-Tab, I bounce back to windows in Windows. I basically use these settings set in the "X.Org Server Settings" dialog per (http://www.terheyden.com/blog/?p=202) -rootless -notrayicon -clipboard -keyhook Another tidbit of information is this crash only started to happen a few months ago but I made no changes to my x2go client installation or configuration. It started after a Windows update. Background: To access our remote systems at work, we have to use VMWare's VDI (Virtual Desktop Infrastructure). So, I have to first log into my corporate desktop, then start a VDI session using RSA key login, which gives me another Windows VDI desktop. On the VDI Windows instance, I have x2go installed in the portable way because I don't have admin access these to install it by running the setup program. Some months back, the VDI admins installed some Windows update per normal security patching. After that, this crash started happening. There happens to be a old VDI configuration that apparently has NOT been patched. If I log onto that instance, the crash does not occur. This crash happens with your latest version 4.1.0.0 and two previous versions so it appears to be related to something common to all versions. Since we still have this old (working) VDI configuration (until some realizes it and updates it) and new (broken) one, maybe there is a way I can help by getting you some information as to what is different between the two related to the Windows run time libraries installed? I am glad to help in any way to get you information to help in debugging and fixing this issue. Please let me know what I can do to assist. Thanks! [cid:image001.png@01D2A87C.0E8D7B90]

1 0

Bug#1166: x2goclient terminates with "WARNING: failed to kill process group '<pid>': No such process
by Seth Galitzer 28 Mar '17

28 Mar '17

Package: x2goclient Version: 4.1.0.0 and 4.1.0.1 When exiting x2goclient, after a pause of about 2 seconds, the following message is displayed to stderr: WARNING: unable to send SIGTERM to process group '<pid>': No such process About 10 more seconds later, the following message is displayed to stderr: WARNING: failed to kill process group '<pid>': No such process In some cases, the first message is not displayed, but the second one always is after about 10-12 seconds. The pid is the same in both message. This seems to only affect 4.1.x clients. 4.0.x clients do not seem to have this behavior. I have confirmed these results on the following platforms and builds: Ubuntu 16.04 (xenial): x2goclient 4.1.0.0 (4.1.0.0-0~1536~ubuntu16.04.1), installed from Launchpad PPA Ubuntu 16.04 (xenial): x2goclient 4.1.0.1, compiled from source Ubuntu 15.04 (vivid): x2goclient 4.1.0.0 (4.1.0.0-0~1536~ubuntu15.04.1), installed from Launchpad PPA Ubuntu 15.04 (vivid): x2goclient 4.1.0.1, compiled from source Debian 8.7 (jessie) 64-bit: x2goclient 4.1.0.1, compiled from source Debian 8.7 (jessie) 32-bit: x2goclient 4.1.0.1, compiled from source The following builds and platforms do not appear to be affected: Ubuntu 16.04 (xenial): x2goclient 4.0.5.1 (4.0.5.1-1), installed from official Ubuntu repos Ubuntu 15.04 (vivid): x2goclient 4.0.3.1 (4.0.3.1-4), installed from official Ubuntu repos Debian 8.7 (jessie) 64-bit: x2goclient 4.0.3.1 (4.0.3.1-4), installed from official debian repos Debian 8.7 (jessie) 32-bit: x2goclient 4.0.3.1 (4.0.3.1-4), installed from official debian repos Seth -- Seth Galitzer Systems Coordinator Computing and Information Sciences Kansas State University http://www.cis.ksu.edu/~sgsax sgsax(a)ksu.edu 785-532-7790

3 2

Bug#1085: 4.1 upgrade has not fixed the crashing
by Troels Arvin 27 Mar '17

27 Mar '17

Upgrading to X2Go 4.1.0.0: Unfortunately, the crashes still occur.

1 0

Bug#1162: X2Go issue (in src:x2goclient) has been marked as pending for release
by Mihai Moldovan 22 Mar '17

22 Mar '17

tag #1162 pending fixed #1162 4.1.0.1 thanks Hello, X2Go issue #1162 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=12a567a The issue will most likely be fixed in src:x2goclient (4.1.0.1). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 12a567a3cedde2ba58b33b545de284cd93aeb9c8 Author: Seth Galitzer <sgsax(a)ksu.edu> Date: Wed Mar 22 03:00:39 2017 +0100 {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new --branding option that replaces the seal logo. Fixes: #1162. diff --git a/debian/changelog b/debian/changelog index 09a10f5..42c1e52 100644 --- a/debian/changelog +++ b/debian/changelog @@ -185,6 +185,8 @@ x2goclient (4.1.0.1-0x2go1) UNRELEASED; urgency=medium * New upstream version (4.1.0.1): - src/help.cpp: add documentation for the --background option. Part of #1162. + - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new + --branding option that replaces the seal logo. Fixes: #1162. -- X2Go Release Manager <git-admin(a)x2go.org> Wed, 22 Feb 2017 07:13:10 +0100

2 1

Bug#1100: Solution Proposal
by Ezell, Matthew A. 21 Mar '17

21 Mar '17

I’m not sure I understand what nefarious behavior #336 is supposed to prevent either. It did, unfortunately, make x2go unusable in our environment. I propose one of the following solutions: 1. Revert the behavior (sounds like this isn’t going to happen?) 2. Add a ‘secure path’ boolean session option in the client (you can leave it on by default, I’ll have my users turn it off) 3. In the client, hard code the full path to the x2go server and convert x2go to use all absolute paths (hopefully this prevents all the same things as #336 without the side effect) 4. Option 3, but add an ‘x2go server binary’ string session option in the client in case the admin installed x2go in an alternate location 5. Save the path before setting it (export X2GOSAVEPATH=$PATH; export PATH=<safe_path>; cmd). Then, somewhere after all the x2go stuff has been run, restore the original path I’ll be happy to test implementations once the core developers determine the best path forward. Thanks, ~Matt

1 0

Processed: your mail
by owner＠bugs.x2go.org 21 Mar '17

21 Mar '17

Processing commands for control(a)bugs.x2go.org: > tag 1162 patch Bug #1162 [x2goclient] proposed patch to add customization of icon in lower left corner of x2goclient main window Added tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 1162: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1162 X2Go Bug Tracking System Contact owner(a)bugs.x2go.org with problems

1 0

Bug#1156: SSH daemon could not be started
by John Cobo 20 Mar '17

20 Mar '17

Package: Windows Client Version: 4.1.0.0 Using windows 10, I install X2Go client and on every connection the SSH deemon error pops up. Disabling printing and file shareing does fix it, but... 'tis not right. Thanks. [image: Inline images 1]

3 2

Bug#1162: proposed patch to add customization of icon in lower left corner of x2goclient main window
by Seth Galitzer 20 Mar '17

20 Mar '17

Package: x2goclient Version: 4.1.0.1 Attached patch adds functionality to customize the icon in the lower left corner of the main window. On commandline invocation, user can provide path to an SVG file to replace the seal face icon with one of their own choosing. Mechanism is similar to how the --background flag is used. Same file format, pixel size, and color palette as the seal face icon is assumed for replacement image. I respectfully ask this to be considered for inclusion in future releases. Seth Galitzer -- Seth Galitzer Systems Coordinator Computing and Information Sciences Kansas State University http://www.cis.ksu.edu/~sgsax sgsax(a)ksu.edu 785-532-7790

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev