[X2Go-Dev] Client build question

[Hauke Fath (SPG)]

Hi,

by way of an introduction: I maintain the x11/x2go-client package on 
pkgsrc (<https://pkgsrc.se/x11/x2go-client>).

The package has a few patches, which you may be interested in.

While updating to 4.1.2.3, I stumbled over a build problem: In 
<https://gitlab.x2go.org/x2go/client/x2goclient/-/commit/fc2db75ab86889cdde6448c4e6e5a25c431d212d>, 
the MAKEOVERRIDES variable is supposedly set to a list of make variables 
that are safe to propagate to sub-make processes.*

I find that this breaks the build, since gmake (v4.4.1 here) interprets 
the first word ("SHELL") as target, which it cannot find. 
Coincidentally, the Arch package 
<https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=x2goclient> also 
has a sed(1) command that cleans out the lists.

What was the motivation of the change? And where does it actually work?

Cheerio,
Hauke


* The *BSD variants are rather pointless, btw, since the rest of the 
Makefile has non-portable constructs and won't work at least with 
NetBSD's make(1)

-- 
      The ASCII Ribbon Campaign                    Hauke Fath
()     No HTML/RTF in email	        Institut für Nachrichtentechnik
/\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344

-- 
      The ASCII Ribbon Campaign                    Hauke Fath
()     No HTML/RTF in email	        Institut für Nachrichtentechnik
/\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344