[X2Go-Dev] Client build question

[Mike Gabriel]

Hi Hauke,

On  Fr 23 Feb 2024 16:43:10 UTC, Hauke Fath (SPG) wrote:

> Hi,
>
> by way of an introduction: I maintain the x11/x2go-client package on  
> pkgsrc (<https://pkgsrc.se/x11/x2go-client>).
>
> The package has a few patches, which you may be interested in.

Definitely, can you send merge requests via  
https://gitlab.x2go.org/x2go/client/x2goclient/ ?

> While updating to 4.1.2.3, I stumbled over a build problem: In  
> <https://gitlab.x2go.org/x2go/client/x2goclient/-/commit/fc2db75ab86889cdde6448c4e6e5a25c431d212d>, the MAKEOVERRIDES variable is supposedly set to a list of make variables that are safe to propagate to sub-make  
> processes.*
>
> I find that this breaks the build, since gmake (v4.4.1 here)  
> interprets the first word ("SHELL") as target, which it cannot find.  
> Coincidentally, the Arch package  
> <https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=x2goclient>  
> also has a sed(1) command that cleans out the lists.

Please also propose a patch via our gitlab. Thanks.

> What was the motivation of the change? And where does it actually work?
>
> Cheerio,
> Hauke

Thanks,
Mike
-- 

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de