[X2Go-Dev] Bug#1470: x2goserver: Broken x2goversion results in failed connection

[Ulrich Sibiller]

Hmm, in my version on debian (4.1.0.3-4) this is already fixed.

The fixing commit is quite old, but was added two days after the
version you (or Ubuntu) have...:

commit c80103788eebe0445efc2cefb56b074231b76f39
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Sat Dec 1 11:42:40 2018 +0100

    x2goversion: Fix situations where ${compfile} contains a
non-absolute path (e.g. it contains '../').

diff --git a/x2goserver/bin/x2goversion b/x2goserver/bin/x2goversion
index aa960a28..50e45c09 100755
--- a/x2goserver/bin/x2goversion
+++ b/x2goserver/bin/x2goversion
@@ -42,7 +42,7 @@ if [ -n "${1}" ]; then
 else
        cd "${X2GO_VERSIONS_BASEPATH}"
        for compfile in "${X2GO_VERSIONS_BASEPATH}"/*; do
-               X2GO_COMPONENT="$(echo "${compfile}" | cut -d '.' -f '2')"
+               X2GO_COMPONENT="$(echo "$(basename ${compfile})" | cut
-d '.' -f '2')"
                X2GO_COMPONENT_VERSION="$(get_version "${compfile}")"
                echo "${X2GO_COMPONENT}: ${X2GO_COMPONENT_VERSION}"
        done


Uli

On Tue, May 19, 2020 at 7:39 PM Randy Goldenberg
<randy.goldenberg at gmail.com> wrote:
>
> On Tuesday May 19, 2020, Edgar Fuß wrote:
>
> >> -            X2GO_COMPONENT="$(echo "${compfile}" | cut -d '.' -f '2')"
> >> +            X2GO_COMPONENT="$(echo "$(basename ${compfile})" | cut -d '.' -f '2')"
> >The echo $(...) is redundant, i.e., you want
> >               X2GO_COMPONENT="$(basename "${compfile}" | cut -d '.' -f '2')"
>
> True.  I limited my changes to what was needed to make things work.  There's no
> need for 2 to be in single quotes, either.
> _______________________________________________
> x2go-dev mailing list
> x2go-dev at lists.x2go.org
> https://lists.x2go.org/listinfo/x2go-dev