[X2Go-Commits] [libx2goclient] 06/132: src/x2goclient-openssh-version.c: clarify "weird casting" comment a bit.

git-admin at x2go.org git-admin at x2go.org
Fri Dec 3 15:26:28 CET 2021


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository libx2goclient.

commit b36136ddd5d702e602417b461aa8d9cde6453b30
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sat Oct 31 01:25:27 2020 +0100

    src/x2goclient-openssh-version.c: clarify "weird casting" comment a bit.
---
 src/x2goclient-openssh-version.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/x2goclient-openssh-version.c b/src/x2goclient-openssh-version.c
index 3911989..79eb318 100644
--- a/src/x2goclient-openssh-version.c
+++ b/src/x2goclient-openssh-version.c
@@ -492,9 +492,11 @@ X2GoClientOpenSSHVersion* x2goclient_openssh_version_fetch_openssh_version (GErr
            *       The reason is quite simple: we *know* that the called
            *       function WILL NOT modify the input string, not even call
            *       free () on it, if we explicitly disable that feature via
-           *       its boolean parameter. We could make the input string
-           *       parameter const instead, but this would require a cast when
-           *       calling g_free (), which seems to be frowned upon. Thus,
+           *       its boolean parameter. We could make
+           *       x2goclient_setbrk_dup's input string parameter const
+           *       instead, but this would require a cast when calling
+           *       g_free () (i.e., if freeing data was requested via the
+           *       boolean parameter), which seems to be frowned upon. Thus,
            *       we'll keep it taking a non-const pointer for the time being
            *       and cast data passed to it if necessary.
            *

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git


More information about the x2go-commits mailing list