[X2Go-Commits] [libx2goclient] 09/132: src/x2goclient-network-ssh.c: set return value to TRUE after initial checks in x2goclient_network_ssh_kill_subprocesses ().

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository libx2goclient.

commit 833b8a1ccf33f780ef9d20175d5fb2fb10da283c
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sat Oct 31 02:39:27 2020 +0100

    src/x2goclient-network-ssh.c: set return value to TRUE after initial checks in x2goclient_network_ssh_kill_subprocesses ().
    
    Otherwise, calling that function without a running master connection
    (which should essentially be a no-op) returns a failure, which is not
    intended.
---
 src/x2goclient-network-ssh.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/x2goclient-network-ssh.c b/src/x2goclient-network-ssh.c
index 6e1565a..6279e57 100644
--- a/src/x2goclient-network-ssh.c
+++ b/src/x2goclient-network-ssh.c
@@ -735,6 +735,12 @@ static gboolean x2goclient_network_ssh_kill_subprocesses (X2GoClientNetworkSSH *
 
   g_return_val_if_fail (X2GOCLIENT_IS_NETWORK_SSH (self), ret);
 
+  /*
+   * There's hardly anything that can fail and if it does we can update the
+   * return value directly.
+   */
+  ret = TRUE;
+
   g_mutex_lock (&(self->check_thread_mutex));
   if (self->active_master_conn) {
     g_mutex_unlock (&(self->check_thread_mutex));

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git