[X2Go-Commits] [nx-libs] 96/108: XKB: Fix garbage initialization

git-admin at x2go.org git-admin at x2go.org
Fri Nov 9 20:35:58 CET 2018


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository nx-libs.

commit 6625e78c1292f2dc03329e55bbc33537cc8ee569
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Wed Jul 18 23:26:10 2018 +0200

    XKB: Fix garbage initialization
    
      commit 8311cd5f89ca6781842bb24671b8122cdf8be148
      Author: Jeremy Huddleston <jeremyhu at freedesktop.org>
      Date:   Tue Mar 23 10:37:36 2010 -0700
    
          XKB: Fix garbage initialization
    
          XkbEnableDisableControls set extra garbage bits on the xkbControlsNotify
              changedControls mask because it was uninitialized on the stack.
    
          Found by clang
    
          Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
          Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    
      Backported-to-nx-by: Ulrich Sibiller <uli42 at gmx.de>
---
 nx-X11/programs/Xserver/xkb/xkbUtils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nx-X11/programs/Xserver/xkb/xkbUtils.c b/nx-X11/programs/Xserver/xkb/xkbUtils.c
index c97a54b..028f324 100644
--- a/nx-X11/programs/Xserver/xkb/xkbUtils.c
+++ b/nx-X11/programs/Xserver/xkb/xkbUtils.c
@@ -763,7 +763,7 @@ XkbSrvLedInfoPtr	sli;
     if (cause!=NULL) {
 	xkbControlsNotify cn;
 	cn.numGroups= ctrls->num_groups;
-	cn.changedControls|= XkbControlsEnabledMask;
+	cn.changedControls= XkbControlsEnabledMask;
 	cn.enabledControls= ctrls->enabled_ctrls;
 	cn.enabledControlChanges= (ctrls->enabled_ctrls^old);
 	cn.keycode= cause->kc;

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git


More information about the x2go-commits mailing list