[X2Go-Commits] [nx-libs] 95/108: ProcXkbGetKbdByName: fix use of uninitialised bytes valgrind error.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository nx-libs.

commit 69475953b37d23c77f977833f12cc696c955cd5f
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Wed Jul 18 23:15:07 2018 +0200

    ProcXkbGetKbdByName: fix use of uninitialised bytes valgrind error.
    
      We have fixed that (independendly) before, but missed one line.
    
      Backported-to-nx-by: Ulrich Sibiller <uli42 at gmx.de>
    
        commit 85f9017393c9bb19553e9afcf554673a44a09993
        Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>
        Date:   Tue Feb 8 11:10:10 2011 +0200
    
          ProcXkbGetXkbByName: fix use of uninitialised bytes valgrind error.
    
          ==9999== Syscall param writev(vector[...]) points to uninitialised byte(s)
          ==9999==    at 0x4AB5154: writev (writev.c:51)
          ==9999==    by 0x7C7C3: _XSERVTransWritev (Xtrans.c:912)
          ==9999==    by 0x61C8B: FlushClient (io.c:924)
          ==9999==    by 0x62423: WriteToClient (io.c:846)
          ==9999==    by 0xCE39B: XkbSendMap (xkb.c:1408)
          ==9999==    by 0xD247B: ProcXkbGetKbdByName (xkb.c:5814)
          ==9999==    by 0x4AB53: Dispatch (dispatch.c:432)
          ==9999==    by 0x205BF: main (main.c:291)
          ==9999==  Address 0x557eb68 is 40 bytes inside a block of size 4,096 alloc'd
          ==9999==    at 0x48334A4: calloc (vg_replace_malloc.c:467)
          ==9999==    by 0x62567: WriteToClient (io.c:1065)
          ==9999==    by 0x452EB: ProcEstablishConnection (dispatch.c:3685)
          ==9999==    by 0x4AB53: Dispatch (dispatch.c:432)
          ==9999==    by 0x205BF: main (main.c:291)
          ==9999==  Uninitialised value was created by a stack allocation
          ==9999==    at 0xD1910: ProcXkbGetKbdByName (xkb.c:5559)
    
          Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
          Reviewed-by: Oliver McFadden <oliver.mcfadden at nokia.com>
          Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>
---
 nx-X11/programs/Xserver/xkb/xkb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nx-X11/programs/Xserver/xkb/xkb.c b/nx-X11/programs/Xserver/xkb/xkb.c
index f601f04..e11d7e2 100644
--- a/nx-X11/programs/Xserver/xkb/xkb.c
+++ b/nx-X11/programs/Xserver/xkb/xkb.c
@@ -5018,7 +5018,7 @@ ProcXkbGetKbdByName(ClientPtr client)
     xkbGetIndicatorMapReply	irep = {0};
     xkbGetNamesReply		nrep = {0};
     xkbGetGeometryReply		grep = {0};
-    XkbComponentNamesRec	names;
+    XkbComponentNamesRec	names = {0};
     XkbDescPtr			xkb;
     unsigned char *		str;
     char 			mapFile[PATH_MAX];

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git