x2go-dev

x2go-dev@lists.x2go.org

5400 discussions

[nx-libs] Reason for using quilt
by Mihai Moldovan 20 May '12

20 May '12

Hi, I'm wondering why you guys are using quilt for managing patches to the nx-libs repository. I see that the general purpose is to have the original nomachine source base intact/unchanged to track changes easily. However, quilt is a pain to use (i.e., omitting a patch in the series or changing it), especially taking into consideration that git _already is_ a SCM. Wouldn't it be easier to actually use multiple branches for that purpose? [nomachine]--{3.5.0}------------{3.6.0 (future)}----... \-->[x2go]-------\-->------------... where [name] is a branch named "name", {name} is a tag named "name" and the arrows denote merges. Note that we don't want to merge x2go project changes back into the original nomachine source, thus not merging the x2go branch into the nomachine branch. However, we _want_ to merge new versions of nomachine's source into the x2go branch at some point. Also, this setup is very flexible. If, for instance, you decide to still support the x2go nx 3.5.0 branch, even though nomachine nx 3.6.0 has been released, simply branch off the x2go branch, like this: [nomachine]--{3.5.0}------------{3.6.0 (future)}----... \-->[x2go]-------\-->------------... \-->[x2go 3.5.0]--------... Afterwards, the nomachine branch (tag 3.6.0) can then be merged into the x2go branch and the x2go 3.5.0 life on happily ever after. It is way easier to rebase a branch such as to not include a specific commit (cherry-pick), than omit a patch in the quilt patch series. Not sure if it's only me, but this quilt stuff is really messing with my work flow. Please drop your thoughts in here. Best regards, Mihai

3 3

x2goclient 3.99.2.0 introduces excessive client logging
by masc 20 May '12

20 May '12

Hello, since updating to 3.99.2.0 on OSX the log database is flooded with x2go.client debug log messages while having a session connected. As a side effect specific operations like opening a new terminal window are slowed down and .asl log files have to be cleared out manually from /private/var/log/asl on a very regular basis. 3.99.1.0-rc2 did not show this behaviour and I cannot find any client side setting to lower the log level. Is it possible to change the client log level? Thank you, Marco

2 2

USB forwarding? (esp. @Alex & @Mike)
by Stefan Baur 19 May '12

19 May '12

Hi Devs (esp. Alex and Mike), this topic has popped up before, but it seems no one is really tackling this (or did I just miss the relevant posts?): Forwarding of USB devices from the guest to the host. Our commercial competitors offer solutions to forward, say, a USB card reader to the host, so digital signatures can be performed on a (windows) terminal server. How hard would it be to add this feature to X2Go (especially when working with a Windows client)? Is it a difficult task, or simply a matter of "nobody got around to coding this yet"? -Stefan

3 4

Build Server (Debian packages) available again
by Mike Gabriel 19 May '12

19 May '12

Hi Alex, the Debian packaging environment on japsand.x2go.org is available again. Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419 GnuPG Key ID 0xB588399B mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 0

Full screen on Windows XP
by Paul van der Vlis 19 May '12

19 May '12

Hello, Is it possible to work full-screen on Windows XP with X2goclient? I have a customer what says that this does not work. With regards, Paul. -- Paul van der Vlis Linux systeembeheer, Groningen http://www.vandervlis.nl

5 8

X2Go client (VcXsrv) crashes when running Google Chrome
by Stefan Baur 16 May '12

16 May '12

Hi, I'm trying to configure Google Chrome (google-chrome-stable 19.0.1084.46-r135956) on Debian Squeeze, from the Windows X2GoClient (RC3) - whenever I try to access the settings to configure my proxy, VcXsrv dies: Problemsignatur: Problemereignisname: APPCRASH Anwendungsname: vcxsrv.exe Anwendungsversion: 0.0.0.0 Anwendungszeitstempel: 4f852997 Fehlermodulname: vcxsrv.exe Fehlermodulversion: 0.0.0.0 Fehlermodulzeitstempel: 4f852997 Ausnahmecode: c0000005 Ausnahmeoffset: 00160860 Betriebsystemversion: 6.1.7601.2.1.0.768.3 Gebietsschema-ID: 1031 Zusatzinformation 1: 0a9e Zusatzinformation 2: 0a9e372d3b4ad19135b953a78882e789 Zusatzinformation 3: 0a9e Zusatzinformation 4: 0a9e372d3b4ad19135b953a78882e789 Please let me know if you need further information to debug the issue, I'll be happy to provide it. -Stefan

1 0

Support for PuTTY private key files / built-in ssh-agent?
by Stefan Baur 16 May '12

16 May '12

Hi Devs, would it be possible to integrate support (1) for PuTTY-style ssh private key files (*.ppk) into the X2Go client, or (2) to run a ssh-agent (maybe from cygwin, or copied from PuTTY's "pageant.exe") *within* the X2Go client, so other applications can authenticate with the same key? PuTTY's license does allow copying their code into GPLed code, as it seems. The idea behind (2) this is that the X2Go client on Windows would be able to provide authentication information to WinSCP and similar tools. (1) would simply make life easier for users that already have a private key stored in PuTTY's format. At present they either have to run PuTTYgen to convert it into the format X2Go client understands, or run pageant.exe, PuTTY's ssh agent. -Stefan

2 2

Adding ,,-nolisten tcp'' to x2goagent cmdline options
by Mike Gabriel 16 May '12

16 May '12

Hi Alex, hi others, a while ago someone posted to x2go-dev and x2go-user that x2goagent listens on *:6050 (or higher) while running. I just tried to add ,,-nolisten tcp'' to the x2goagent startup command in x2gostartagent and it works (I can't see a difference except the TCP ports being closed). I also tested with desktop sharing (shadow sessions). WITHOUT -nolisten tcp: (locadm@vidar) {~} $ sudo lsof -i | grep agent x2goagent 30753 mike 0u IPv6 6685074 0t0 TCP *:6050 (LISTEN) x2goagent 30753 mike 1u IPv4 6685075 0t0 TCP *:6050 (LISTEN) x2goagent 30753 mike 9u IPv4 6685176 0t0 TCP localhost:30001->localhost:37995 (ESTABLISHED) WITH -nolisten tcp: (locadm@vidar) {~} $ sudo lsof -i | grep agent x2goagent 32102 mike 7u IPv4 6691645 0t0 TCP localhost:30001->localhost:38003 (ESTABLISHED) Any reason, why we do not add that to x2gostartagent? Mike -- DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419 GnuPG Key ID 0xB588399B mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…

1 1

Patch to Fix x2goagent / nxagent With New LibCairo
by Jim Burnes 15 May '12

15 May '12

I don't know what the current patch status is for fixing nxagent with the new libcairo (1.12.1+ I believe), but eventually I got tired of waiting and created my own patches for nxagent/x2goagent. Most of the fixes were required because the render extension now allows (and libcairo uses) null source drawables (for gradients etc), null masks and null mask drawables. This change creates a bit of a logic mess in the code. Previous patches to the code tried to account for all of the possibilities, but fell a little short. Consider this an alpha-quality patch. I've only tested it in KDE while running GTK applications. All my favorite GTK apps like Firefox, Emacs, rox-filer and all my other GTK apps that were broken are now working just fine. (Though I'm getting only the standard GTK look and feel - don't know if that's caused by anything I've done.) Could someone test this under Gnome? Also, since I'm not primarily an X software engineer I'd like a specialist to take a look at it. The fix is a little crude. I just attached to the x2goagent process and fixed the lines that caused segfaults. (About 10 of them). I also rewrote one of the macros in Pixels.h into a local subroutine in Render.c. It had a bug in it and complex macro bugs are a PITA to debug in gdb (or anything else really). The macro is only used in one place and although the code in the macro is called pretty often, it's very likely that the compiler would inline it anyway. The rewrite increases readability by a large factor. A better patch could be created by someone that understands nxagent and X much better. The render extension code receives render ops from X client programs. The render ops can contain any combination of picture source, picture destination and picture mask. It's apparently legal to send render ops with combinations of null picture source drawables, picture masks and picture mask drawables. A better way to patch this would be to simply perform a return on all the illegal combinations of null parameters for the render ops. That way you wouldn't have to keep re-checking the parameter values. So anyway, here it is. I appreciate it if someone out there would test it and let me know. Also if anyone knows of the X docs which discuss null picture sources and masks in the render extension I'd be glad to create a cleaner patch that conforms to the stands. Let me know. eris0xff *** x2go/nx-libs-3.5.0.12/nx-X11/programs/Xserver/hw/nxagent/Render.c 2012-03-07 14:04:02.000000000 -0700 --- x2go-new/nx-libs-3.5.0.12/nx-X11/programs/Xserver/hw/nxagent/Render.c 2012-05-10 11:09:39.631786853 -0600 *************** *** 995,1000 **** --- 995,1030 ---- #endif } + + int nxagentShouldDeferComposite(PicturePtr pSrc, PicturePtr pMask, PicturePtr pDst) + { + + int drawableDst; + int linkDeferred; + int unSyncedSrcMask; + + drawableDst = ( nxagentRenderVersionMajor == 0 && + nxagentRenderVersionMinor == 8 && + (pDst) -> pDrawable -> type == DRAWABLE_PIXMAP + ); + + linkDeferred = ( nxagentOption(DeferLevel) >= 2 && + nxagentOption(LinkType) < LINK_TYPE_ADSL + ); + + unSyncedSrcMask = ( nxagentOption(DeferLevel) == 1 && + (pDst) -> pDrawable -> type == DRAWABLE_PIXMAP && + ( + (pSrc -> pDrawable && (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized)) || + ((pMask) && pMask -> pDrawable && (nxagentDrawableStatus((pMask) -> pDrawable) == NotSynchronized)) + ) + ); + + + return drawableDst || linkDeferred || unSyncedSrcMask; + } + + void nxagentComposite(CARD8 op, PicturePtr pSrc, PicturePtr pMask, PicturePtr pDst, INT16 xSrc, INT16 ySrc, INT16 xMask, INT16 yMask, INT16 xDst, INT16 yDst, CARD16 width, CARD16 height) *************** *** 1036,1043 **** } #endif ! ! if (NXAGENT_SHOULD_DEFER_COMPOSITE(pSrc, pMask, pDst)) { pDstRegion = nxagentCreateRegion(pDst -> pDrawable, NULL, xDst, yDst, width, height); --- 1066,1073 ---- } #endif ! /* if (NXAGENT_SHOULD_DEFER_COMPOSITE(pSrc, pMask, pDst)) */ ! if (nxagentShouldDeferComposite(pSrc, pMask, pDst)) { pDstRegion = nxagentCreateRegion(pDst -> pDrawable, NULL, xDst, yDst, width, height); *************** *** 1095,1101 **** } } ! if (pMask != NULL && pMask -> pDrawable != pSrc -> pDrawable && pMask -> pDrawable != pDst -> pDrawable) { nxagentSynchronizeShmPixmap(pMask -> pDrawable, xMask, yMask, width, height); --- 1125,1132 ---- } } ! if ((pMask) && (pMask->pDrawable) && ! pMask -> pDrawable != pSrc -> pDrawable && pMask -> pDrawable != pDst -> pDrawable) { nxagentSynchronizeShmPixmap(pMask -> pDrawable, xMask, yMask, width, height); *************** *** 1259,1265 **** * on the real X server. */ ! if (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized) { #ifdef TEST fprintf(stderr, "nxagentGlyphs: Synchronizing source [%s] at [%p].\n", --- 1290,1296 ---- * on the real X server. */ ! if (pSrc -> pDrawable && (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized)) { #ifdef TEST fprintf(stderr, "nxagentGlyphs: Synchronizing source [%s] at [%p].\n", *************** *** 1302,1315 **** nxagentSynchronizeBox(pSrc -> pDrawable, &glyphBox, NEVER_BREAK); } ! if (pSrc -> pDrawable -> type == DRAWABLE_PIXMAP) { nxagentIncreasePixmapUsageCounter((PixmapPtr) pSrc -> pDrawable); } } ! if (pSrc -> pDrawable != pDst -> pDrawable && ! nxagentDrawableStatus(pDst -> pDrawable) == NotSynchronized) { #ifdef TEST fprintf(stderr, "nxagentGlyphs: Synchronizing destination [%s] at [%p].\n", --- 1333,1347 ---- nxagentSynchronizeBox(pSrc -> pDrawable, &glyphBox, NEVER_BREAK); } ! if (pSrc -> pDrawable && (pSrc -> pDrawable -> type == DRAWABLE_PIXMAP)) { nxagentIncreasePixmapUsageCounter((PixmapPtr) pSrc -> pDrawable); } } ! ! if (pSrc -> pDrawable && (pSrc -> pDrawable != pDst -> pDrawable && ! nxagentDrawableStatus(pDst -> pDrawable) == NotSynchronized)) { #ifdef TEST fprintf(stderr, "nxagentGlyphs: Synchronizing destination [%s] at [%p].\n", *************** *** 1749,1755 **** return; } ! if (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized) { #ifdef TEST fprintf(stderr, "nxagentTrapezoids: Going to synchronize the source drawable at [%p].\n", --- 1781,1789 ---- return; } ! /* the following blocks need fixing to ignore null values of pDrawable */ ! ! if (pSrc -> pDrawable && (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized)) { #ifdef TEST fprintf(stderr, "nxagentTrapezoids: Going to synchronize the source drawable at [%p].\n", *************** *** 1843,1849 **** * operation like nxagentTrapezoids() does. */ ! if (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized) { #ifdef TEST fprintf(stderr, "nxagentTriangles: Going to synchronize the source drawable at [%p].\n", --- 1877,1885 ---- * operation like nxagentTrapezoids() does. */ ! ! ! if (pSrc -> pDrawable && (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized)) { #ifdef TEST fprintf(stderr, "nxagentTriangles: Going to synchronize the source drawable at [%p].\n", *************** *** 1920,1926 **** * operation like nxagentTrapezoids() does. */ ! if (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized) { #ifdef TEST fprintf(stderr, "nxagentTriStrip: Going to synchronize the source drawable at [%p].\n", --- 1956,1963 ---- * operation like nxagentTrapezoids() does. */ ! ! if (pSrc -> pDrawable && (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized)) { #ifdef TEST fprintf(stderr, "nxagentTriStrip: Going to synchronize the source drawable at [%p].\n", *************** *** 1997,2003 **** * operation like nxagentTrapezoids() does. */ ! if (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized) { #ifdef TEST fprintf(stderr, "nxagentTriFan: Going to synchronize the source drawable at [%p].\n", --- 2034,2041 ---- * operation like nxagentTrapezoids() does. */ ! ! if (pSrc -> pDrawable && (nxagentDrawableStatus(pSrc -> pDrawable) == NotSynchronized)) { #ifdef TEST fprintf(stderr, "nxagentTriFan: Going to synchronize the source drawable at [%p].\n",

3 10

Broken glyphs and icons after suspending a session
by Holger Hahn 13 May '12

13 May '12

Hello x2go dev team, as I was looking for an alternative on NX nomachine, because it was broken with the last Cairo 1.12 update, I found your x2go solution, which is great. So as it bases on the same libraries than the original nomachine, you had the same issues - with rendering to undrawable objects, the whole nxagent crashes because of SEGV. With the patch of Jan (thanks to) you committed to the master branch today, I compiled another nxagent. Actually it worked fine, but after suspending and reconnecting to a session, some graphical objects get broken... All characters/fonts that has been rendered on the screen prior the suspension, are gone. (See Screenshots the link below). Creating new text by starting applications is ok, as long as the characters has not been rendered in the session before. I thought it might be problem with a kind of glyph cache of the X session (ubuntu/x86 x2goclient). But I found one case, where additionally to the text, all icons are gone also, which was with an debian/x64 x2goclient... (Difference can be seen on screenshots) Might it have to do something with the patch from today, that could filter out to much rendering? Or is this issue known from somewhere else? Here are some screenshots: http://www.computerfreak.de/sonic/x2shots/ Thanks for your help, Holger

4 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev