x2go-dev

x2go-dev@lists.x2go.org

5399 discussions

Bug#422: Status Update
by Michael DePaulo 12 Mar '14

12 Mar '14

Status Update 1. x2goclient's 4.0.2.0 2014.03.05 nightly build was the last nightly build to be built with --console. So I ran that build with --debug. I've attached the output. I wonder if x2goclient is detecting that pulseaudio.exe stopped and then restarting it, or if x2goclient is forcefully restarting pulseaudio.exe? I'm leaning towards the former explanation. Other than that though, the logs do not help me debug this bug. 2. It seems likely that this PulseAudio commit (which made it into PulseAudio 3.0) triggered this bug, since it changed the logic for cookie creation, in addition to specifying a different default cookie path. http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=87ae8307057944… Most likely the bug/incompatibility lies in one or both of these files: src/pulsecore/authkey.c src/pulse/client-conf.c I plan on compiling pulseaudio before and after this commit to determine empirically if this commit triggered this bug/incompatibility.

1 0

Embed pyhoca-cli window in another window
by Borys Saulyak 08 Mar '14

08 Mar '14

Hello all, I am trying to develop X2GO plugin for Remmina and I am missing one very important feature in pyhoca. I need to be able to "embed" pyhoca window into another window. Something similar to "-parent" for Xephyr or "-X" for rdesktop. I tried myself to find how to do it but failed because my python knowledge is very limited. Do you think it is something that can be easily added? In case if nobody is interested would anyone please point me out in the code where the windows is getting created? Thanks a lot for your help in advance!

3 2

Bug#448: x2goclient won't connect with ssh agent (Q: Who was so afraid of the NSA that he disabled agent communication in x2go?)
by Stefan Baur 07 Mar '14

07 Mar '14

Addendum: Mike#2 suggested looking at libssh, as that was upgraded, too. So it might be that it's not a bug in x2goclient per se, but in how libssh talks to ssh agents. -Stefan

1 1

How to create patches for X2Go
by Oleksandr Shneyder 07 Mar '14

07 Mar '14

Hello all, Thank you for all your contributions to X2Go code. However, sometimes it is not easy to test and apply patches, that you send us via a developer mailing list. To make this procedure for us easier, please create your patches like it described in the GIT documentation: http://www.git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project#Pu… @Mike: What do you think about it? Should we include this link in our Wiki-Documentation? regards, Alex -- ----------------------------------------------------------- Oleksandr Shneyder | Email: o.shneyder(a)phoca-gmbh.de phoca GmbH | Tel. : 0911 - 14870374 0 Ludwig-Feuerbach-str. 18 | Fax. : 0911 - 14870374 9 D-90489 Nürnberg | Mobil: 0163 - 49 64 461 Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973 -----------------------------------------------------------

2 2

Bug#449: X2Go issue (in src:x2gobroker) has been marked as pending for release
by Mike Gabriel 07 Mar '14

07 Mar '14

tag #449 pending fixed #449 0.0.3.0 thanks Hello, X2Go issue #449 (src:x2gobroker) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=770683c The issue will most likely be fixed in src:x2gobroker (0.0.3.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 770683c5ade94095482bdb28ea868ab2d69c2e24 Author: Josh Lukens <jlukens(a)botch.com> Date: Thu Mar 6 20:55:10 2014 -0500 Add support to run pre and post authentication scripts. (Fixes: #449). diff --git a/debian/changelog b/debian/changelog index 0b2dd12..bb4cb93 100644 --- a/debian/changelog +++ b/debian/changelog @@ -118,6 +118,7 @@ x2gobroker (0.0.3.0-0x2go1) UNRELEASED; urgency=low * New upstream version (0.0.3.0): - Add support for dynamic cookie based auth after initial password auth. (Fixes: #447). + - Add support to run pre and post authentication scripts. (Fixes: #449). -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Fri, 07 Jun 2013 23:25:30 +0200

2 1

Bug#450: X2Go issue (in src:x2gobroker) has been marked as pending for release
by Mike Gabriel 07 Mar '14

07 Mar '14

tag #450 pending fixed #450 0.0.3.0 thanks Hello, X2Go issue #450 (src:x2gobroker) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=69fa03e The issue will most likely be fixed in src:x2gobroker (0.0.3.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 69fa03ef3eb9e6bf4aa299e3de6194b315c39d6e Author: Josh Lukens <jlukens(a)botch.com> Date: Thu Mar 6 21:33:38 2014 -0500 Add simple https get authmech. (Fixes: #450). diff --git a/debian/changelog b/debian/changelog index bb4cb93..49e1087 100644 --- a/debian/changelog +++ b/debian/changelog @@ -119,6 +119,7 @@ x2gobroker (0.0.3.0-0x2go1) UNRELEASED; urgency=low - Add support for dynamic cookie based auth after initial password auth. (Fixes: #447). - Add support to run pre and post authentication scripts. (Fixes: #449). + - Add auth mechanism https_get. (Fixes: #450). -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Fri, 07 Jun 2013 23:25:30 +0200

2 1

Bug#447: X2Go issue (in src:x2gobroker) has been marked as pending for release
by Mike Gabriel 07 Mar '14

07 Mar '14

tag #447 pending fixed #447 0.0.3.0 thanks Hello, X2Go issue #447 (src:x2gobroker) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=893b4ce The issue will most likely be fixed in src:x2gobroker (0.0.3.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 893b4ce7190ef088dc096144feb5c99be6d71cf7 Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Date: Fri Mar 7 21:37:59 2014 +0100 Add support for dynamic cookie based auth after initial password auth. (Fixes: #447). diff --git a/debian/changelog b/debian/changelog index ced44bc..0b2dd12 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,6 @@ x2gobroker (0.0.3.0-0x2go1) UNRELEASED; urgency=low + [ Mike Gabriel ] * New upstream version (0.0.3.0): - Add SSH support to X2Go Session Broker. (Fixes: #153). - Move x2gobroker executable to /usr/bin. @@ -113,6 +114,11 @@ x2gobroker (0.0.3.0-0x2go1) UNRELEASED; urgency=low sub-package. + Builds for EPEL-7 also have to systemd aware. + [ Josh Lukens ] + * New upstream version (0.0.3.0): + - Add support for dynamic cookie based auth after initial password auth. (Fixes: + #447). + -- Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de> Fri, 07 Jun 2013 23:25:30 +0200 x2gobroker (0.0.2.3-0~x2go1) unstable; urgency=low

2 1

Bug#450: [PATCH] Add simple https get authmech
by Josh Lukens 07 Mar '14

07 Mar '14

Package: x2gobroker Version: 0.0.2.4 Severity: wishlist Very simple authmech that requests a webpage over https with basic auth. If the page is fetched successfully (status 200) the user is authenticated. Used in conjunction with something like an apache server you can get easy access to the full handful of existing auth modules for things like radius, RSA, etc. --- x2gobroker/authmechs/https_get_authmech.py | 62 ++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100755 x2gobroker/authmechs/https_get_authmech.py diff --git a/x2gobroker/authmechs/https_get_authmech.py b/x2gobroker/authmechs/https_get_authmech.py new file mode 100755 index 0000000..03741f0 --- /dev/null +++ b/x2gobroker/authmechs/https_get_authmech.py @@ -0,0 +1,62 @@ +# -*- coding: utf-8 -*- + +# Copyright (C) 2012-2013 by Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de (mailto:mike.gabriel@das-netzwerkteam.de)> +# Copyright (C) 2012-2013 by Oleksandr Shneyder <oleksandr.shneyder(a)obviously-nice.de (mailto:oleksandr.shneyder@obviously-nice.de)> +# +# X2Go Session Broker is free software; you can redistribute it and/or modify +# it under the terms of the GNU Affero General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# X2Go Session Broker is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Affero General Public License for more details. +# +# You should have received a copy of the GNU Affero General Public License +# along with this program; if not, write to the +# Free Software Foundation, Inc., +# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. + +# Very simple authmech that requests a webpage over https with basic auth. +# If the page is fetched successfully (status 200) the user is authenticated. +# +# Used in conjunction with something like an apache server you can get easy +# access to the full handful of existing auth modules for things like radius, +# RSA, etc. +# +# Server name and path must be hard coded below for the time being. Also note +# that the httplib module used does not verify SSL certificates so be sure +# you are on a trusted network as there is a possibility of a man in the middle +# attack. + +# modules +import sys +import httplib +import base64 +import string + +class X2GoBrokerAuthMech(object): + + def authenticate(self, username, password): + + ## FIXME: these should really be specificed in config file + host = "my.webserver.com (http://my.webserver.com)" + path = "/auth/index.html" + + # base64 encode the username and password + auth = base64.standard_b64encode('%s:%s' % (username, password)).replace('\n', '') + + https = httplib.HTTPSConnection(host) + https.putrequest("GET", path) + https.putheader("Host", host) + https.putheader("User-Agent", "x2go http auth") + https.putheader("Authorization", "Basic %s" % auth) + https.endheaders() + + response = https.getresponse() + https.close() + + if response.status == 200: + return True + return False -- 1.8.3.4 (Apple Git-47)

1 0

Bug#449: [PATCH] Add support to run pre and post authentication scripts.
by Josh Lukens 07 Mar '14

07 Mar '14

Package: x2gobroker Version: 0.0.2.4 Severity: wishlist Diff is on top of patch in bug 447. This allows for things like logging to external systems, adjusting firewall rules for connecting users, mangling user data for various reasons before returning session info, etc. Follows similar approach to authmech but allows for multiple scripts to run. --- etc/x2gobroker.conf | 7 +++++++ x2gobroker/defaults.py | 2 ++ x2gobroker/optional_scripts/__init__.py | 20 ++++++++++++++++++++ x2gobroker/optional_scripts/base_script.py | 24 ++++++++++++++++++++++++ x2gobroker/web/plain.py | 25 +++++++++++++++++++++++++ 5 files changed, 78 insertions(+) create mode 100755 x2gobroker/optional_scripts/__init__.py create mode 100755 x2gobroker/optional_scripts/base_script.py diff --git a/etc/x2gobroker.conf b/etc/x2gobroker.conf index b8b8974..64967a9 100644 --- a/etc/x2gobroker.conf +++ b/etc/x2gobroker.conf @@ -48,6 +48,13 @@ # the permissions are set to allow the x2go broker process to write to this directory #cookie-directory = '/var/log/x2gobroker/cookies' +# Pre and Post authentication scripts give you the option to run outside scripts +# or adjust the values of variables for users logging in. Pre scripts run just +# before user authentication and Post scripts run just after. Set to list of +# scripts, comma seperated, with no spaces between. +#pre_auth_scripts = +#post_auth_scripts = + # Every server-client communication (between X2Go Client and broker) has to be # accompanied by this initial authentication cookie if require-cookie is set above. # This should be in the format of a UUID. diff --git a/x2gobroker/defaults.py b/x2gobroker/defaults.py index 9027ed0..d4bfaaf 100644 --- a/x2gobroker/defaults.py +++ b/x2gobroker/defaults.py @@ -186,6 +186,8 @@ X2GOBROKER_CONFIG_DEFAULTS = { u'auth-timeout': 36000, u'cookie-directory': '/var/log/x2gobroker/cookies', u'verify-ip': True, + u'pre_auth_scripts': [], + u'post_auth_scripts': [], u'my-cookie': uuid.uuid4(), u'enable-plain-output': True, u'enable-json-output': True, diff --git a/x2gobroker/optional_scripts/__init__.py b/x2gobroker/optional_scripts/__init__.py new file mode 100755 index 0000000..d3eff3c --- /dev/null +++ b/x2gobroker/optional_scripts/__init__.py @@ -0,0 +1,20 @@ +# -*- coding: utf-8 -*- + +# Copyright (C) 2012-2014 by Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de (mailto:mike.gabriel@das-netzwerkteam.de)> +# Copyright (C) 2012-2014 by Oleksandr Shneyder <oleksandr.shneyder(a)obviously-nice.de (mailto:oleksandr.shneyder@obviously-nice.de)> +# +# X2Go Session Broker is free software; you can redistribute it and/or modify +# it under the terms of the GNU Affero General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# X2Go Session Broker is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Affero General Public License for more details. +# +# You should have received a copy of the GNU Affero General Public License +# along with this program; if not, write to the +# Free Software Foundation, Inc., +# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. + diff --git a/x2gobroker/optional_scripts/base_script.py b/x2gobroker/optional_scripts/base_script.py new file mode 100755 index 0000000..e284362 --- /dev/null +++ b/x2gobroker/optional_scripts/base_script.py @@ -0,0 +1,24 @@ +# -*- coding: utf-8 -*- + +# Copyright (C) 2012-2014 by Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de (mailto:mike.gabriel@das-netzwerkteam.de)> +# Copyright (C) 2012-2014 by Oleksandr Shneyder <oleksandr.shneyder(a)obviously-nice.de (mailto:oleksandr.shneyder@obviously-nice.de)> +# +# X2Go Session Broker is free software; you can redistribute it and/or modify +# it under the terms of the GNU Affero General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# X2Go Session Broker is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Affero General Public License for more details. +# +# You should have received a copy of the GNU Affero General Public License +# along with this program; if not, write to the +# Free Software Foundation, Inc., +# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. + +class X2GoBrokerOptionalScript(object): + + def run_me(self, username, password, task, profile_id, ip, cookie): + return username, password, task, profile_id, ip, cookie diff --git a/x2gobroker/web/plain.py b/x2gobroker/web/plain.py index 254c9d2..cd623a9 100644 --- a/x2gobroker/web/plain.py +++ b/x2gobroker/web/plain.py @@ -114,9 +114,34 @@ class X2GoBrokerWeb(_RequestHandler): output = '' + if len(global_config['pre_auth_scripts']) != 0: + for script in global_config['pre_auth_scripts']: + try: + post_auth_script=None + exec("import x2gobroker.optional_scripts.{script}_script".format(script=script)) + exec("pre_auth_script = x2gobroker.optional_scripts.{script}_script.X2GoBrokerOptionalScript()".format(script=script)) + logger_broker.debug ('Calling pre-auth script {script} with username: {username}, password: {password}, task: {task}, profile_id: {profile_id}, ip: {ip}, cookie: {cookie}'.format(script=script,username=username, password='XXXXX', task=task, profile_id=profile_id, ip=ip, cookie=cookie)) + username, password, task, profile_id, ip, cookie = pre_auth_script.run_me(username=username, password=password, task=task, profile_id=profile_id, ip=ip, cookie=cookie) + logger_broker.debug ('Pre-auth script {script} finished with username: {username}, password: {password}, task: {task}, profile_id: {profile_id}, ip: {ip}, cookie: {cookie}'.format(script=script,username=username, password='XXXXX', task=task, profile_id=profile_id, ip=ip, cookie=cookie)) + except ImportError: + logger_error.error('No such optional script \'{script}\''.format(script=script)) + + logger_broker.debug ('username: {username}, password: {password}, task: {task}, profile_id: {profile_id}, cookie: {cookie}'.format(username=username, password='XXXXX', task=task, profile_id=profile_id, cookie=cookie)) access, next_cookie = broker_backend.check_access(username=username, password=password, ip=ip, cookie=cookie) if access: + if len(global_config['post_auth_scripts']) != 0: + for script in global_config['post_auth_scripts']: + try: + post_auth_script=None + exec("import x2gobroker.optional_scripts.{script}_script".format(script=script)) + exec("post_auth_script = x2gobroker.optional_scripts.{script}_script.X2GoBrokerOptionalScript()".format(script=script)) + logger_broker.debug ('Calling post-auth script {script} with username: {username}, password: {password}, task: {task}, profile_id: {profile_id}, ip: {ip}, cookie: {cookie}'.format(script=script,username=username, password='XXXXX', task=task, profile_id=profile_id, ip=ip, cookie=cookie)) + username, password, task, profile_id, ip, cookie = post_auth_script.run_me(username=username, password=password, task=task, profile_id=profile_id, ip=ip, cookie=cookie) + logger_broker.debug ('Post-auth script {script} finished with username: {username}, password: {password}, task: {task}, profile_id: {profile_id}, ip: {ip}, cookie: {cookie}'.format(script=script,username=username, password='XXXXX', task=task, profile_id=profile_id, ip=ip, cookie=cookie)) + except ImportError: + logger_error.error('No such optional script \'{script}\''.format(script=script)) + ### ### CONFIRM SUCCESSFUL AUTHENTICATION FIRST -- 1.8.3.4 (Apple Git-47)

1 0

Bug#448: x2goclient won't connect with ssh agent (Q: Who was so afraid of the NSA that he disabled agent communication in x2go?)
by Stefan Baur 06 Mar '14

06 Mar '14

Package: x2goclient Version: 4.0.2.0 (I'm filing this against 4.0.2.0 b/c it's still present there. If bugs should be filed against the version they initially appeared in, please let me know) not affected: 4.0.0.3 with PulseAudio 0.9.6 not affected: 4.0.1.2 with PulseAudio 0.9.6 possibly affected (untested) 4.0.1.3 with PulseAudio 0.9.6 affected: 4.0.1.3+build2 with PulseAudio 0.9.6 affected: 4.0.2.0 Preface: The followin issue has been observed on Windows; whoever takes care of this should also check if the same issue occurs on Linux and Mac when using the ssh agents shipped with these operating systems. Situation: 4.0.1.2 with PulseAudio 0.9.6 and older clients allowed the use of an external SSH agent that loads and memorizes SSH private keys (so you don't have to re-enter your private key's passphrase whenever you try to connect). In my case, this SSH agent was "Pageant" from the PuTTY package. With 4.0.1.3+build2/PA0.9.6, using the same (registry-stored) settings as before, x2goclient.exe pops up a dialog box asking me for my private key's password. Which it does over and over again, without ever connecting. To me, it looks like it's asking for the password for a non-existant private key, the key with the file name "", thus it always fails. Assumption: Someone tried to add/fix code regarding ssh public key authentication (maybe something to do with bug #322?), took care of whatever issue there was with private key file handling by x2goclient itself, but overlooked the possibility that an external ssh agent might be involved. Net Result: SSH public key login using an SSH agent is effectively broken in 4.0.1.3+build2 (and possibly 4.0.1.3), up to 4.0.2.0-2014-03-06 (nightly build), and probably still broken in the current source. Sounds like a case for one of our two Mikes ... -Stefan

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

x2go-dev