tag #405 pending
fixed #405 4.0.1.19
thanks
Hello,
X2Go issue #405 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=d6b726d
The issue will most likely be fixed in src:x2goserver (4.0.1.19).
light+love
X2Go Git Admin (on behalf of the sender of this mail)
---
commit d6b726dc6b9ad2945d3a3218ce2eeaef6474257a
Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>
Date: Thu Jan 8 13:26:21 2015 +0100
Start sshfs with a timeout of 30 seconds (because it never finishes if something is wrong with the client-side TCP socket). Also remove/unmount mountpoints erroneously registered sshfs mountpoints if sshfs command times out. (Fixes: #405).
diff --git a/debian/changelog b/debian/changelog
index 4d34828..bf219da 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -55,6 +55,11 @@ x2goserver (4.0.1.19-0x2go1) UNRELEASED; urgency=medium
- Improve sanitizer, use 'x2gosid' sanitizer for session IDs everywhere.
Drop unused 'pnixusername' sanitizer in 4.0.1.x release of X2Go Server.
- Allow usernames in session IDs of length 48 chars.
+ - Start sshfs with a timeout of 30 seconds (because it never finishes if
+ something is wrong with the client-side TCP socket). Also remove/unmount
+ mountpoints erroneously registered sshfs mountpoints if sshfs command
+ times out. Furthermore, print errors to STDERR (not STDOUT). (Fixes:
+ #405).
* debian/control:
+ Add D (x2goserver): libfile-which-perl.
+ Add C (x2goserver: x2godesktopsharing (<< 3.1.1.2).
Processing commands for control(a)bugs.x2go.org:
> tag 724 not-a-bug
Bug #724 [x2goserver-xsession] Scanning does not work over romote-desktop session with sane
Added tag(s) not-a-bug.
> --
Stopping processing here.
Please contact me if you need assistance.
--
724: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=724
X2Go Bug Tracking System
Contact owner(a)bugs.x2go.org with problems
Processing control commands:
> tag -1 confirmed
Bug #405 [x2goserver] x2gomountdirs/sshfs hangs indefinitely if
Ignoring request to alter tags of bug #405 to the same tags previously set
> reassign -1 x2goserver
Bug #405 [x2goserver] x2gomountdirs/sshfs hangs indefinitely if
Ignoring request to reassign bug #405 to the same package
> retitle -1 x2gomountdirs/sshfs hangs indefinitely if
Bug #405 [x2goserver] x2gomountdirs/sshfs hangs indefinitely if
Ignoring request to change the title of bug#405 to the same title
--
405: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=405
X2Go Bug Tracking System
Contact owner(a)bugs.x2go.org with problems
Processing control commands:
> tag -1 confirmed
Bug #405 [x2goclient] x2goclient pollutes ~/.ssh/authorized_keys
Added tag(s) confirmed.
> reassign -1 x2goserver
Bug #405 [x2goclient] x2goclient pollutes ~/.ssh/authorized_keys
Bug reassigned from package 'x2goclient' to 'x2goserver'.
No longer marked as found in versions 4.0.1.2.
Ignoring request to alter fixed versions of bug #405 to the same values previously set
> retitle -1 x2gomountdirs/sshfs hangs indefinitely if
Bug #405 [x2goserver] x2goclient pollutes ~/.ssh/authorized_keys
Changed Bug title to 'x2gomountdirs/sshfs hangs indefinitely if' from 'x2goclient pollutes ~/.ssh/authorized_keys'
--
405: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=405
X2Go Bug Tracking System
Contact owner(a)bugs.x2go.org with problems
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Control: tag -1 wontfix
Control: tag -1 notabug
Control: tag -1 close
Hello, Andreas.
I couldn't help but notice that you already reported this on X2Go-User
back in November of 2014.
(http://lists.x2go.org/pipermail/x2go-user/2014-November/002679.html)
So, let me quote from my reply to you that I sent back then
(http://lists.x2go.org/pipermail/x2go-user/2014-November/002680.html)
> I fail to see what this has to do with X2Go, other than you used
> X2go as a workaround for your problem. We're not Debian, we're not
> XOrg, so the bug report mentioned has nothing to do with us.
If you feel differently, please be more precise in your explanation as
to why you believe it to be an X2Go bug.
- -Stefan
- --
BAUR-ITCS UG (haftungsbeschränkt)
Geschäftsführer: Stefan Baur
Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364
Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)
iQEcBAEBAgAGBQJUro33AAoJEG7d9BjNvlEZ0X4H/2NsT1wwZCE1rkfhFt4RfoQL
Kl3w0hgUVLf7Jfg/GfOY+OTEEQoe33iEisktHnwT/BVOWt8Es+w0hqi7nqqu5JET
XmX7hewcQ38VPXHArSj/UQiXbDyY8m2US9DLVI2aOJ2H+/4MLnMrJcZY53abOPVk
TG4yY0yOSPBHgATIzycGwn8CPi9fVGw8HQdDchUUB0FPAaKrBYYq78DPA6OrTZ+0
poDV86+cBqnc7JS1aharjNk8Og/n6YDH3JbsGjStzT8X98+0De3CJWhlAlLI4i2e
bnWRbFZOp0iii5r3SyQF1yNLC9xfxEGGE8ZFCc1rlWExM29WaqD56REtWvef6NU=
=5+3O
-----END PGP SIGNATURE-----
Control: tag -1 confirmed
Control: reassign -1 x2goserver
Control: retitle -1 x2gomountdirs/sshfs hangs indefinitely if
client-side sshd is down
Hi,
I have spent the last 1.5 days with hunting down the cause for #405.
The phenomenon is:
o client-side is Linux (or maybe Mac OS X)
o sshd ist not running on the client machine
o the session profile has printing or client-side folder sharing enabled
If X2Go Client launches a remote session it does the following things:
o set up a reverse port forwarding tunnel that allows
<server-side-localhost>:<fsPort> -> <client-side-localhost>:<sshd-Port>
o if sshd is not running, the above will still work...
o then x2gomountdirs is evoked...
o ... which attempts to run sshfs against <server-side-localhost>:<fsPort>
o however, in X2Go Client this triggers an I/O error because the client-side
sshd is not listening / not running
I studied the X2Go Client code (sshmasterconnection.cpp and
sshprocess.cpp) very deeply and added several new debug messages +
improved the debugging output of existing messages.
In X2Go Client, the mounting of a client-side folder uses two SSH
channel inside this reverse port forwarding tunnel:
o one SSH channel for the tunnel itself
o one SSH channel per x2gomountdirs command call evoked on the server
Furthermore, X2Go Client can detect if failures occur in x2gomountdirs
this way:
o something strange happens while executing the command (SSH
disconnects etc.)
o the stdOut of the evoked command (x2gomountdirs) is empty while
stdErr is not
So, (and I did not know this), all X2Go Server side commands
(/usr/bin/x2go*) should properly write to stderr if things go wrong
and leave stdOut untouched at the same time.
The problem now is: if x2gomountdirs is not detected as "failing"
(which it is not), the sshfs pubkey required for client-side folder
sharing is not removed from the .ssh/authorized_keys file.
Furthermore, X2Go Client detects the I/O errors on the sshfs tunnel
channel, but cannot relate to that to the x2gomountdirs command evoked
via the SSH command channel.
My first attempts targetted getting X2Go Client to tidy up the
authorized_keys file whenever a tunnel failure occurs. X2Go Client
should be able to detect this, but this would require a partial
redesign of the complete reverse port forwarding mechanism. I
disrecommend doing this for the current X2Go Client implementation,
but we should keep it in the back of our heads for a later redesign.
It took about 8h to come to this conclusion.
My second approach (and I will commit soon is this):
o evoke sshfs command with "timeout 30 sshfs <options>"
o print error messages to STDERR (not to STDOUT)
o and make sure we unregister the mount point if sshfs fails (with
fusermount -u)
Wit this approach, X2Go Client tries to call x2gomountdirs,
x2gomountdirs fails after 30 seconds with error messages printed to
STDERR. This gets caught by X2Go Client and then the
post-startX2goMount code is triggered which removes the used pubkey
from ~/.ssh/authorized_keys.
Commit will come in a minute...
Greets,
Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31
mail: mike.gabriel(a)das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x…
Package: x2goclient
Version: 4.0.3.0
x2goserver-version: 4.0.1.18-0~949 running on Ubuntu 14.04.1
x2goclient-version: 4.0.3.0 running on Windows 7
We are experiencing a strange bug in the interplay of x2go with a component of the ROOT data analysis framework (https://root.cern.ch) Displaying GUI windows in the ROOT framework, shows them shortly and results in an immediate CRASH of the X2go connection with a Windows error "vcxsrv.exe has stopped working" and subsequent closure of all opened remote applications.
Strangely the GUI window shows up when resuming the session in X2go. Running the ROOT GUI window from pure vcxsrv, Xming, Mobaxfire or similar Windows X-Server applications works flawlessly. It also worked previously with the "baikal" version of X2go. I admit this seems to be an exotic bug but there might be further graphical software affected which increases the severity of this bug.
Steps to reproduce:
- Install ROOT from the webpage or via "apt-get install root-system-bin" on the x2goserver
- Run "root" on command line.
- Open a TBrowser with the command "TBrowser b"
After this the x2goclient slowly fills the "session" log with warnings of
"Proxy: WARNING! Handling data for finishing FD#6 channel ID#1."
This bug is a kind of a show stopper for us because we need ROOT for scientific use. I would help to further track down the error and debug if I can get some hints where and how to start.
Kind regards,
Martin
Package: x2goclient
Version: 4.0.2.1
This crashing here:
x2goSession ONMainWindow::getSessionFromString ( const QString& string )
{
QStringList lst=string.split ( '|' );
x2goSession s;
s.agentPid=lst[0];
s.sessionId=lst[1];
looks like the session string is corrupted and doesn't have the expected
number of elements. Need some error checking here.
-------- Forwarded Message --------
Subject: [Bug 1179869] New: [abrt] x2goclient: ref(): x2goclient killed by SIGSEGV
Date: Wed, 07 Jan 2015 17:05:11 +0000
From: bugzilla(a)redhat.com
To: orion(a)cora.nwra.com
https://bugzilla.redhat.com/show_bug.cgi?id=1179869
Bug ID: 1179869
Summary: [abrt] x2goclient: ref(): x2goclient killed by SIGSEGV
Product: Fedora
Version: 20
Component: x2goclient
Assignee: orion(a)cora.nwra.com
Reporter: livyathan(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: orion(a)cora.nwra.com
Version-Release number of selected component:
x2goclient-4.0.2.1-1.fc20
Additional info:
reporter: libreport-2.2.3
backtrace_rating: 4
cmdline: x2goclient
crash_function: ref
executable: /usr/bin/x2goclient
kernel: 3.16.6-203.fc20.x86_64
runlevel: N 5
type: CCpp
uid: 1000
Truncated backtrace:
Thread no. 1 (10 frames)
#0 ref at ../../src/corelib/arch/qatomic_x86_64.h:121
#1 QString::operator= at tools/qstring.cpp:1410
#2 ONMainWindow::getSessionFromString at ../onmainwindow.cpp:3657
#3 ONMainWindow::selectSession at ../onmainwindow.cpp:4364
#4 ONMainWindow::slotListSessions at ../onmainwindow.cpp:3629
#5 ONMainWindow::qt_static_metacall at moc_onmainwindow.cpp:385
#6 QMetaObject::activate at kernel/qobject.cpp:3567
#7 SshProcess::sshFinished at moc_sshprocess.cpp:140
#8 SshProcess::slotChannelClosed at ../sshprocess.cpp:443
#9 SshProcess::qt_static_metacall at moc_sshprocess.cpp:84
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
tag #702 pending
fixed #702 4.0.3.2
thanks
Hello,
X2Go issue #702 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:
http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=3008b2a
The issue will most likely be fixed in src:x2goclient (4.0.3.2).
light+love
X2Go Git Admin (on behalf of the sender of this mail)
---
commit 3008b2a10fde108810650849522f4d2e76c3b300
Author: Mike Gabriel <mike.gabriel(a)das-netzwerkteam.de>
Date: Wed Jan 7 10:31:55 2015 +0100
Use app.setQuitOnLastWindowClosed(false) for the X2Go Client QtApplication to assure that X2Go Client does not arbitrarily exit during a running session. This fixes X2Go Client crashes that occur when printing via the CUPS-X2Go printing mechanism with activate print dialog popup on incoming print jobs and minimized main window. (Fixes: #702).
diff --git a/debian/changelog b/debian/changelog
index a754d04..ae08442 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,6 +9,11 @@ x2goclient (4.0.3.2-0x2go1) UNRELEASED; urgency=medium
* New upstream release (4.0.3.2):
- Provide empty Turkish translation file.
- Add several info/error/debug log message while hunting down #702.
+ - Use app.setQuitOnLastWindowClosed(false) for the X2Go Client QtApplication
+ to assure that X2Go Client does not arbitrarily exit during a running
+ session. This fixes X2Go Client crashes that occur when printing via
+ the CUPS-X2Go printing mechanism with activate print dialog popup on
+ incoming print jobs and minimized main window. (Fixes: #702).
[ Jason Alavaliant ]
* New upstream verson (4.0.3.2):