This is an automated email from the git hooks/post-receive script. x2go pushed a change to branch master in repository x2gobroker. from 533a37b x2gobroker/loadchecker.py: Avoid rare cases where at the end of a load checking cycle a negative sleep time would have been calculated. (Fixes: #1315). Thanks to Walid Moghrabi for catching this. new 32245e3 x2gobroker/agent.py: Add FIXME about bogus code passage. Needs rechecking... new 5923632 lib/x2gobroker-agent.pl: Be more specific in comment about load average check. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: lib/x2gobroker-agent.pl | 3 ++- x2gobroker/agent.py | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2gobroker.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository x2gobroker. commit 32245e36db0a912142ff97f9e23bd2fa8980c35a Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Date: Thu Sep 13 16:31:26 2018 +0200 x2gobroker/agent.py: Add FIXME about bogus code passage. Needs rechecking... --- x2gobroker/agent.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/x2gobroker/agent.py b/x2gobroker/agent.py index 14620de..3563da2 100644 --- a/x2gobroker/agent.py +++ b/x2gobroker/agent.py @@ -150,6 +150,9 @@ def _call_local_broker_agent(username, task, cmdline_args=[], logger=None): cmd_line.append('{arg}'.format(arg=cmdline_arg)) logger.info('Executing agent command locally: {cmd}'.format(cmd=" ".join(cmd_line))) + + ### FIXME: why do we set result to ['FAILED'] here and override it later??? + result = ['FAILED'] try: agent_process = subprocess.Popen(cmd_line, -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2gobroker.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository x2gobroker. commit 5923632054b34b5e44ec228a45f795443d9e48b8 Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Date: Thu Sep 13 16:33:09 2018 +0200 lib/x2gobroker-agent.pl: Be more specific in comment about load average check. --- lib/x2gobroker-agent.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/x2gobroker-agent.pl b/lib/x2gobroker-agent.pl index b9359ba..3b2889d 100755 --- a/lib/x2gobroker-agent.pl +++ b/lib/x2gobroker-agent.pl @@ -162,7 +162,8 @@ if ( $mode eq 'checkload' ) { close FILE; my $loadavgXX = ( $avg1 + $avg5 + $avg15 ) * 100/3 + 1; if ( $loadavgXX lt 1 ) { - # load may not be ZERO, we should never get here... + # if we get here, then our avgXX values were negative, + # we should never get here... $loadavgXX = 1; } -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2gobroker.git
-
git-admin＠x2go.org