This is an automated email from the git hooks/post-receive script. x2go pushed a change to branch master in repository libx2goclient. from 2e1e4d7 src/x2goclient-network-ssh.c: re-implement master connection spawning via GSubprocess. new 2bcf9ae src/x2goclient-network.c: hook up dispose and finalize function pointers. new 3e7701c src/x2goclient-network-ssh.c: hook up dispose and finalize function pointers. new 98e5ddc src/x2goclient-network-ssh.c: log debug message for master connection process disposal. new bc07aef src/x2goclient-network.c: don't call g_string_free () on NULL pointers. The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: src/x2goclient-network-ssh.c | 10 +++++++++- src/x2goclient-network.c | 11 +++++++++-- 2 files changed, 18 insertions(+), 3 deletions(-) -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository libx2goclient. commit 3e7701c6c12645100add6ffc3b1b029ad350db1b Author: Mihai Moldovan <ionic@ionic.de> Date: Sat Jan 18 11:13:48 2020 +0100 src/x2goclient-network-ssh.c: hook up dispose and finalize function pointers. --- src/x2goclient-network-ssh.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/x2goclient-network-ssh.c b/src/x2goclient-network-ssh.c index 502e7fb..fc08760 100644 --- a/src/x2goclient-network-ssh.c +++ b/src/x2goclient-network-ssh.c @@ -96,16 +96,22 @@ struct _X2GoClientNetworkSSH { G_DEFINE_TYPE (X2GoClientNetworkSSH, x2goclient_network_ssh, X2GOCLIENT_TYPE_NETWORK); +static void x2goclient_network_ssh_dispose (GObject *object); +static void x2goclient_network_ssh_finalize (GObject *object); static GSocketAddress* x2goclient_network_ssh_parse_sockspec (X2GoClientNetwork *parent, const GString *sockspec); static gboolean x2goclient_network_ssh_parent_connect (X2GoClientNetwork *parent, GError **gerr); static gboolean x2goclient_network_ssh_kill_subprocesses (X2GoClientNetworkSSH *self); static void x2goclient_network_ssh_class_init (X2GoClientNetworkSSHClass *klass) { + GObjectClass *object_class = G_OBJECT_CLASS (klass); + + object_class->dispose = &x2goclient_network_ssh_dispose; + object_class->dispose = &x2goclient_network_ssh_finalize; + X2GoClientNetworkClass *parent_class = X2GOCLIENT_NETWORK_CLASS (klass); parent_class->connect = &x2goclient_network_ssh_parent_connect; - parent_class->parse_sockspec = &x2goclient_network_ssh_parse_sockspec; } -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository libx2goclient. commit bc07aef1d8372832ecb496f401a130f7403d2eb1 Author: Mihai Moldovan <ionic@ionic.de> Date: Sat Jan 18 13:20:43 2020 +0100 src/x2goclient-network.c: don't call g_string_free () on NULL pointers. --- src/x2goclient-network.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/x2goclient-network.c b/src/x2goclient-network.c index 9d0ce6b..667e99a 100644 --- a/src/x2goclient-network.c +++ b/src/x2goclient-network.c @@ -144,8 +144,10 @@ static void x2goclient_network_dispose (GObject *object) { static void x2goclient_network_finalize (GObject *object) { X2GoClientNetworkPrivate *priv = x2goclient_network_get_instance_private (X2GOCLIENT_NETWORK (object)); - g_string_free (priv->socket_spec, TRUE); - priv->socket_spec = NULL; + if (priv->socket_spec) { + g_string_free (priv->socket_spec, TRUE); + priv->socket_spec = NULL; + } g_free (priv->session_path); priv->session_path = NULL; -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository libx2goclient. commit 2bcf9aed97edc2c808a9b54ac0b169ef674e1d11 Author: Mihai Moldovan <ionic@ionic.de> Date: Sat Jan 18 11:12:00 2020 +0100 src/x2goclient-network.c: hook up dispose and finalize function pointers. --- src/x2goclient-network.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/x2goclient-network.c b/src/x2goclient-network.c index 20662fa..9d0ce6b 100644 --- a/src/x2goclient-network.c +++ b/src/x2goclient-network.c @@ -77,6 +77,8 @@ enum { static GParamSpec *net_obj_properties[X2GO_NET_N_PROPERTIES] = { NULL, }; +static void x2goclient_network_dispose (GObject *object); +static void x2goclient_network_finalize (GObject *object); static void x2goclient_network_set_property (GObject *object, guint prop_id, const GValue *value, GParamSpec *param_spec); static void x2goclient_network_get_property (GObject *object, guint prop_id, GValue *value, GParamSpec *param_spec); static GSocketAddress* x2goclient_network_parse_sockspec (X2GoClientNetwork *self, const GString *sockspec); @@ -85,6 +87,9 @@ static GSocketAddress* x2goclient_network_parse_sockspec (X2GoClientNetwork *sel static void x2goclient_network_class_init (X2GoClientNetworkClass *klass) { GObjectClass *object_class = G_OBJECT_CLASS (klass); + object_class->dispose = &x2goclient_network_dispose; + object_class->finalize = &x2goclient_network_finalize; + object_class->set_property = &x2goclient_network_set_property; object_class->get_property = &x2goclient_network_get_property; -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository libx2goclient. commit 98e5ddc6808b3bff442c02eb71c79c6901f085ce Author: Mihai Moldovan <ionic@ionic.de> Date: Sat Jan 18 11:14:25 2020 +0100 src/x2goclient-network-ssh.c: log debug message for master connection process disposal. --- src/x2goclient-network-ssh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/x2goclient-network-ssh.c b/src/x2goclient-network-ssh.c index fc08760..4a13184 100644 --- a/src/x2goclient-network-ssh.c +++ b/src/x2goclient-network-ssh.c @@ -579,6 +579,8 @@ static gboolean x2goclient_network_ssh_kill_subprocesses (X2GoClientNetworkSSH * if (self->master_conn) { /* Cleanup, if necessary. */ + g_log (NULL, G_LOG_LEVEL_DEBUG, "Master connection cleanup required."); + g_subprocess_force_exit (self->master_conn); GCancellable *wait_cancel = g_cancellable_new (); -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git