This is an automated email from the git hooks/post-receive script. x2go pushed a change to branch master in repository cups-x2go. from edf1f24 debian/control: do not depend on perl-modules directly. new ef73554 cups-x2go: actually print "real" executed command instead of the "original" one with placeholders. new 6bb95f9 cups-x2go: read output from ghostscript, don't write a filehandle to the temporary file. new 7d4b067 cups-x2go: use parentheses around function arguments. new 54c4709 cups-x2go: fix binmode() call, :raw layer is implicit. The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Summary of changes: cups-x2go | 14 ++++++++++++-- debian/changelog | 7 +++++++ 2 files changed, 19 insertions(+), 2 deletions(-) -- Alioth's /srv/git/code.x2go.org/cups-x2go.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/cups-x2go.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository cups-x2go. commit ef73554db926aeb8ba9d2a3ebabb97c4e2c9c32c Author: Mihai Moldovan <ionic@ionic.de> Date: Tue Jun 16 02:10:37 2015 +0200 cups-x2go: actually print "real" executed command instead of the "original" one with placeholders. --- cups-x2go | 2 +- debian/changelog | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/cups-x2go b/cups-x2go index 1d488b7..3161578 100755 --- a/cups-x2go +++ b/cups-x2go @@ -222,7 +222,7 @@ for (my $i = 0; $i < @ps2pdf_args; ++$i) { $ps2pdf_args[$i] =~ s/%s/$psFile/g; } -syslog('info', "Converting printjob with command: $ps2pdf\n"); +syslog('info', "Converting printjob with command: $ps2pdf_cmd " . join (" ", @ps2pdf_args) . "\n"); my ($pdf_fh, $pdfFile) = tempfile ($pdf_template, TMPDIR => 1); diff --git a/debian/changelog b/debian/changelog index 6409c59..0c67388 100644 --- a/debian/changelog +++ b/debian/changelog @@ -5,6 +5,8 @@ cups-x2go (3.0.1.3-0x2go1) UNRELEASED; urgency=low - cups-x2go: import tempfile() function from File::Temp module. - cups-x2go: only repeat the last X, not the whole ".pdfX" string (or the like.) + - cups-x2go: actually print "real" executed command instead of the + "original" one with placeholders. * debian/control: - Add dependencies on perl-modules for core modules and ${perl:Depends} for perl itself. -- Alioth's /srv/git/code.x2go.org/cups-x2go.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/cups-x2go.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository cups-x2go. commit 6bb95f9fa18769d1b69ae7b9e93dc268ae977345 Author: Mihai Moldovan <ionic@ionic.de> Date: Tue Jun 16 02:12:19 2015 +0200 cups-x2go: read output from ghostscript, don't write a filehandle to the temporary file. Fixes a hanging ghostscript call and... well... random junk, instead of a "real" PDF file. --- cups-x2go | 12 +++++++++++- debian/changelog | 3 +++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/cups-x2go b/cups-x2go index 3161578..76f6bdb 100755 --- a/cups-x2go +++ b/cups-x2go @@ -230,6 +230,16 @@ my ($pdf_fh, $pdfFile) = tempfile ($pdf_template, TMPDIR => 1); $ENV{TMPDIR}="/tmp"; my ($gs_out, $gs_in, $wait_ret, $real_ret); my $gs_pid = open2 ($gs_out, $gs_in, $ps2pdf_cmd, @ps2pdf_args); + +binmode $gs_out :raw; + +close $gs_in; + +# Force readline to not read "lines", but raw data. Get all output from ghostscript. +my $gs_out_data = do { local $/; readline ($gs_out) }; + +close $gs_out; + waitpid ($gs_pid, 0); $wait_ret = $?; @@ -259,7 +269,7 @@ if ($conv_fail) { syslog('debug', "cups-x2go processed postscript file $psFile to $pdfFile"); -print $pdf_fh $gs_out; +print $pdf_fh $gs_out_data; close ($pdf_fh); # after we have created the PDF from CUPS's PS file, we can drop the PS file diff --git a/debian/changelog b/debian/changelog index 0c67388..64fe153 100644 --- a/debian/changelog +++ b/debian/changelog @@ -7,6 +7,9 @@ cups-x2go (3.0.1.3-0x2go1) UNRELEASED; urgency=low like.) - cups-x2go: actually print "real" executed command instead of the "original" one with placeholders. + - cups-x2go: read output from ghostscript, don't write a filehandle to the + temporary file. Fixes a hanging ghostscript call and... well... random + junk, instead of a "real" PDF file. * debian/control: - Add dependencies on perl-modules for core modules and ${perl:Depends} for perl itself. -- Alioth's /srv/git/code.x2go.org/cups-x2go.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/cups-x2go.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository cups-x2go. commit 7d4b06754c9f1aaf49ab0a2f0f931ca568232694 Author: Mihai Moldovan <ionic@ionic.de> Date: Tue Jun 16 02:18:34 2015 +0200 cups-x2go: use parentheses around function arguments. --- cups-x2go | 8 ++++---- debian/changelog | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cups-x2go b/cups-x2go index 76f6bdb..018e027 100755 --- a/cups-x2go +++ b/cups-x2go @@ -231,14 +231,14 @@ $ENV{TMPDIR}="/tmp"; my ($gs_out, $gs_in, $wait_ret, $real_ret); my $gs_pid = open2 ($gs_out, $gs_in, $ps2pdf_cmd, @ps2pdf_args); -binmode $gs_out :raw; +binmode ($gs_out, :raw); -close $gs_in; +close ($gs_in); # Force readline to not read "lines", but raw data. Get all output from ghostscript. my $gs_out_data = do { local $/; readline ($gs_out) }; -close $gs_out; +close ($gs_out); waitpid ($gs_pid, 0); @@ -269,7 +269,7 @@ if ($conv_fail) { syslog('debug', "cups-x2go processed postscript file $psFile to $pdfFile"); -print $pdf_fh $gs_out_data; +print ($pdf_fh, $gs_out_data); close ($pdf_fh); # after we have created the PDF from CUPS's PS file, we can drop the PS file diff --git a/debian/changelog b/debian/changelog index 64fe153..2203f08 100644 --- a/debian/changelog +++ b/debian/changelog @@ -10,6 +10,7 @@ cups-x2go (3.0.1.3-0x2go1) UNRELEASED; urgency=low - cups-x2go: read output from ghostscript, don't write a filehandle to the temporary file. Fixes a hanging ghostscript call and... well... random junk, instead of a "real" PDF file. + - cups-x2go: use parentheses around function arguments. * debian/control: - Add dependencies on perl-modules for core modules and ${perl:Depends} for perl itself. -- Alioth's /srv/git/code.x2go.org/cups-x2go.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/cups-x2go.git
This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository cups-x2go. commit 54c470923eeca660f278f58b1f20d66c1ede89cf Author: Mihai Moldovan <ionic@ionic.de> Date: Tue Jun 16 02:20:35 2015 +0200 cups-x2go: fix binmode() call, :raw layer is implicit. --- cups-x2go | 2 +- debian/changelog | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cups-x2go b/cups-x2go index 018e027..ea154da 100755 --- a/cups-x2go +++ b/cups-x2go @@ -231,7 +231,7 @@ $ENV{TMPDIR}="/tmp"; my ($gs_out, $gs_in, $wait_ret, $real_ret); my $gs_pid = open2 ($gs_out, $gs_in, $ps2pdf_cmd, @ps2pdf_args); -binmode ($gs_out, :raw); +binmode ($gs_out); close ($gs_in); diff --git a/debian/changelog b/debian/changelog index 2203f08..c962d27 100644 --- a/debian/changelog +++ b/debian/changelog @@ -11,6 +11,7 @@ cups-x2go (3.0.1.3-0x2go1) UNRELEASED; urgency=low temporary file. Fixes a hanging ghostscript call and... well... random junk, instead of a "real" PDF file. - cups-x2go: use parentheses around function arguments. + - cups-x2go: fix binmode() call, :raw layer is implicit. * debian/control: - Add dependencies on perl-modules for core modules and ${perl:Depends} for perl itself. -- Alioth's /srv/git/code.x2go.org/cups-x2go.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/cups-x2go.git
-
git-admin＠x2go.org