New subject: [libx2goclient] 08/44: misc src/: constify all function parameters.

17 Sep 2020

      This is an automated email from the git hooks/post-receive script.

x2go pushed a change to branch master
in repository libx2goclient.

      from  afb65da   src/x2goclient-network-ssh.c: stop using g_printf (), use g_log () instead.
       new  3fe03ca   src/x2goclient-openssh-version.c: typo fix in error string.
       new  f8c71aa   src/x2goclient-network-ssh.c: add active_master_conn instance variable, scheduled to replace master_conn.
       new  5d6eef0   src/x2goclient-network-ssh.c: fix UB when printing OpenSSH client command array elements being NULL (and hence not strings) and clean up the code a bit.
       new  e536f54   src/x2goclient-network-ssh.c: replace "stderr" parameter to x2goclient_network_ssh_log_std_str () with "select_stderr".
       new  270b3f5   src/x2goclient-network-ssh.c: split out array printing routine into its own function.
       new  e1100f6   src/x2goclient-network-ssh.c: rename x2goclient_network_ssh_ptrarray_print () to x2goclient_network_ssh_gptrarray_to_string () and fully rework it.
       new  ca8983d   src/x2goclient-network-ssh.c: add another helper function  x2goclient_network_ssh_gptrarray_print_debug (), wrapping the GPtrArray printing to g_log () and its DEBUG target.
       new  c57d50c   misc src/: constify all function parameters.
       new  fcb526e   src/x2goclient-network-ssh.c: split out appending host (and, if applicable, port) to an GPtrArray to a new function called x2goclient_network_ssh_sshcmd_add_host_port ().
       new  b98389b   src/x2goclient-network-ssh.c: don't assign NULL to a (g)boolean.
       new  d8ec4e0   src/x2goclient-network-ssh.{c,h}: split out OpenSSH client process spawning into a separate function called x2goclient_network_ssh_start_sshcmd ().
       new  b871c1b   src/x2goclient-network-ssh.c: rewrite x2goclient_network_ssh_kill_subprocesses () to not kill an actual process but spawn an OpenSSH client process executing an exit command for the master connection.
       new  1e36d6d   src/x2goclient-network-ssh.c: remove master_conn instance variable.
       new  27f6fa5   src/test/sshtest.c: add locale.h header, needed for setlocale () and friends.
       new  285eeb3   src/x2goclient-network-ssh.c: re-order finalization.
       new  387254c   src/x2goclient-network-ssh.c: fix x2goclient_network_ssh_log_std_str (): actual decrease the size counter.
       new  9ac9581   src/x2goclient-network-ssh.c: implement master connection status check.
       new  b8e9b1f   src/x2goclient-network.c: add connected boolean private instance variable and read-only getters and setters.
       new  88174ed   src/x2goclient-network.c: make x2goclient_network_connect () idempotent via the connected instance variable.
       new  ca3938f   src/x2goclient-network.{c,h}: add new private parent_connect function pointer, to be used for x2goclient_network_connect ().
       new  5ce70da   src/x2goclient-network-ssh.c: use parent_connect function pointer in x2goclient_network_ssh_connect ().
       new  9e9d174   src/test/sshtest.c: test connection status getter and setter.
       new  007bfa8   src/test/sshtest.c: try to connect a second time to see if the function is really idempotent now.
       new  3d8d50f   src/x2goclient-network.c: reorder properties in setter to keep original order.
       new  ddeb531   src/x2goclient-network.c: add getter and setters for {write,read}-only properties.
       new  7ee08cf   src/x2goclient-network.{c,h}: make parent_connection function pointer a read-only property called connect-function acting on an instance private called connect_function, add getter and setter.
       new  c8853fa   src/x2goclient-network-ssh.c: use connect-function property to fetch parent connect function.
       new  54e91ee   src/x2goclient-network-ssh.c: move check timeout to a separate thread, add synchronization via a mutex.
       new  8feeaae   src/x2goclient-network-ssh.c: actually assign data to check_thread instance variable.
       new  115cda2   src/x2goclient-network-ssh.c: fix typo in debug message.
       new  7e61eea   src/x2goclient-network-ssh.c: change timeout check to 3000 ms (3 seconds) while debugging.
       new  8ea258e   src/test/sshtest.c: sleep for 30 seconds after connection has been established, then tear everything down.
       new  8e4cad6   src/x2goclient-network-ssh.c: make parameter to x2goclient_network_ssh_check_timeout_data_free const )not const-data).
       new  1a1e7d0   src/x2goclient-network-ssh.c: check timeout is not an idle source, rename unwrapping function to x2goclient_network_ssh_start_check_timeout_unwrap.
       new  67c9306   src/x2goclient-network-ssh.c: add parenthesis to cast, non-functional.
       new  9ba0651   src/test/sshtest.c: only try to connect again if the first connection succeeded.
       new  108c6b4   src/x2goclient-openssh-bugs.c: bump version requirement for stderr closing to 8.5+.
       new  69202fa   src/x2goclient-network-ssh.c: check thread pointer before joining check thread.
       new  fc37887   src/x2goclient-network-ssh.c: pass self instead of the main context to check thread main function.
       new  b6d34d0   src/x2goclient-network-ssh.c: let x2goclient_network_ssh_finalize () make more use of the mutex.
       new  1a45278   src/x2goclient-network-ssh.c: initialize main loop pointer for good measure.
       new  5157e75   src/x2goclient-network-ssh.c: make check thread main loop an instance variable.
       new  f89c2dc   src/x2goclient-network-ssh.c: add comment only.
       new  8491443   src/x2goclient-network-ssh.c: add debugging output for check thread main function.

The 44 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.

Summary of changes:
 src/test/sshtest.c               |  37 +-
 src/x2goclient-network-ssh.c     | 989 +++++++++++++++++++++++++++++----------
 src/x2goclient-network-ssh.h     |   6 +-
 src/x2goclient-network.c         |  85 +++-
 src/x2goclient-network.h         |   6 +-
 src/x2goclient-openssh-bugs.c    |   6 +-
 src/x2goclient-openssh-bugs.h    |   4 +-
 src/x2goclient-openssh-version.c |   8 +-
 src/x2goclient-openssh-version.h |   6 +-
 src/x2goclient-utils.c           |   4 +-
 src/x2goclient-utils.h           |   6 +-
 11 files changed, 877 insertions(+), 280 deletions(-)

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git

[libx2goclient] branch master updated (afb65da -> 8491443)