[X2Go-Dev] [PATCH] build: avoid using install -o/-g

Jan Engelhardt jengelh at inai.de
Sat Feb 16 04:12:08 CET 2013


The -o and -g options cause installation failure in unprivileged build
environments, and provide no benefit for root either, because files
will be owned by the installing user anyway.
---
Can we please stop with the -o and -g madness?

 Makefile |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 07428f6..3c90c45 100755
--- a/Makefile
+++ b/Makefile
@@ -23,9 +23,9 @@
 SRC_DIR=$(CURDIR)
 SHELL=/bin/bash
 
-INSTALL_DIR=install -d -o root -g root -m 755
-INSTALL_FILE=install -o root -g root -m 644
-INSTALL_PROGRAM=install -o root -g root -m 755
+INSTALL_DIR=install -dm 755
+INSTALL_FILE=install -m 644
+INSTALL_PROGRAM=install -m 755
 
 CC      ?= gcc
 CFLAGS  += -fPIE
-- 
1.7.10.4




More information about the x2go-dev mailing list