[X2Go-Dev] [PATCH] build: avoid using install -o/-g

[Mike Gabriel]

Hi Jan,

On Sa 16 Feb 2013 04:12:08 CET Jan Engelhardt wrote:

> The -o and -g options cause installation failure in unprivileged build
> environments, and provide no benefit for root either, because files
> will be owned by the installing user anyway.
> ---
> Can we please stop with the -o and -g madness?
>
>  Makefile |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 07428f6..3c90c45 100755
> --- a/Makefile
> +++ b/Makefile
> @@ -23,9 +23,9 @@
>  SRC_DIR=$(CURDIR)
>  SHELL=/bin/bash
>
> -INSTALL_DIR=install -d -o root -g root -m 755
> -INSTALL_FILE=install -o root -g root -m 644
> -INSTALL_PROGRAM=install -o root -g root -m 755
> +INSTALL_DIR=install -dm 755
> +INSTALL_FILE=install -m 644
> +INSTALL_PROGRAM=install -m 755
>
>  CC      ?= gcc
>  CFLAGS  += -fPIE
> --
> 1.7.10.4

I would really appreciate if he could start using X2Go BTS for  
submitting patches. With this patch I have a hard time to find out to  
what X2Go component to apply it...

1. Send your patches to ,,submit at bugs.x2go.org''.
2. Find a good subject...
3. And put these lines at the top of the mail body:
Package: <Git-project name>
Version: HEAD
Tag: patch

<your patch description / long description>

4. And then add the patch as attachment to your mail. Attachments are  
much easier to handle than inline patch code.

As I still have no clue what X2Go component this patch is for, may I  
ask you to follow the above procedure for this very patch?

Thanks,
Mike




-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20130216/06932d72/attachment.pgp>