[X2Go-User] x2goclient resumes session with wrong X-Server options

[Maarten Boekhold]

(resending in plain text format)

Hi all,

Windows 10, x2goclient 4.1.2.2

When resuming a "paused" x2Go session, x2goclient is using the wrong
X-Server settings. I have configured my x2goclient with the following
settings for X.Org Server settings:


**X.Org Server settings**
[X] use custom X-Server
Executable: C:/Program Files (x86)/x2goclient/VcXsrv/vcxsrv.exe
[ ] start X-Server on X2Go Client start

Window mode: -screen 0 %wx%h -notrayicon -clipboard -keyhook \
	-nowinkill -nopn -silent-dup-error
Fullscreen mode: -fullscreen -notrayicon -clipboard -keyhook \
	-nowinkill -nopn -silent-dup-error
Single application: -multiwindow -notrayicon -clipboard \
	-keyhook -nowinkill -nopn -silent-dup-error
Whole display: -nodecoration -notrayicon -clipboard -keyhook \
	-nopn -silent-dup-error -screen 0 @

My x2goclient session is configured as:

**Session preferences: Input/Output**
[ ] Fullscreen
[ ] Custom 	Width (greyed out 3696) Height (greyed out 2160)
[X] Use whole display [ ] Maximum available 	Display: 2

When I start a new x2Go session, it correctly runs the X-Server with the
"Whole display" command:

"C:\Program Files (x86)\x2goclient\VcXsrv\vcxsrv.exe" \
	-nodecoration -notrayicon -clipboard -keyhook -nowinkill \
	-nopn -silent-dup-error screen 0 @2 :0

But if I then "pause" this session and reconnect, x2goclient uses the
"Window mode" command line options instead:

"C:\Program Files (x86)\x2goclient\VcXsrv\vcxsrv.exe" \
	-screen 3696x2160 -notrayicon -clipboard -keyhook \
	-nowinkill -nopn -silent-dup-error :0

This is really annoying. I suspect this has something to do with the
code around line 4442 in onmainwindow.cpp, but I've not been able to
figure out the exact details yet.

I've tried to debug this by running  x2goclient.debug.exe --debug, but
there's an issue here. When running the debug version, the "Use whole
display" option is not available in the session settings tab:

**Session Input/Output with x2goclient.debug.exe --debug**
[ ] Fullscreen
[ ] Custom 	Width (greyed out 3696) Height (greyed out 2160)
[ ] Maximum available

See the "Use whole display" option missing in front of the "Maximum
available" radio box. It's almost as if the debug build included in this
distribution is of an older x2goclient version (but it shows the correct
version number in the About dialog).

I hope that based on the provided information a fix can be created for
this issue?

Regards, Maarten