<div dir="auto">Ok, that makes sense. <div dir="auto"><br></div><div dir="auto">Checkout README .mxe for instructions how to compile for windows using mxe on Linux </div><div dir="auto"><br></div><div dir="auto">Uli</div><div dir="auto"><br></div><div dir="auto"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Orion Poplawski <<a href="mailto:orion@nwra.com">orion@nwra.com</a>> schrieb am Di., 9. Mai 2023, 20:19:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">And I think at the moment I still prefer simply removing the <br>
wapiSetWindowIcon() code since it isn't used and allows the removal of <br>
the QT winextras dependency.<br>
<br>
On 5/9/23 12:16, Orion Poplawski wrote:<br>
> Gah, once again I make the mistake of not trying to build with the <br>
> latest git<br>
> code.<br>
> <br>
> So now I'm trying with that and getting:<br>
> <br>
> i686-w64-mingw32-g++ -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 <br>
> -fexceptions --param=ssp-buffer-size=4 -fno-keep-inline-dllexport -O2 <br>
> -Wall -Wextra -mthreads -DUNICODE -DCFGCLIENT -DQT_STATIC <br>
> -DQT_DESIGNER_STATIC -DDBUS_STATIC_BUILD -DPCRE_STATIC -DPCRE2_STATIC <br>
> -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_WINEXTRAS_LIB <br>
> -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_NEEDS_QMAIN <br>
> -I../../x2goclient-1ca43813937df9cd136ae6d282204604ab659fab -I. -I../src <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5 <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtSvg <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtWidgets <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtWinExtras <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtGui <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtNetwork <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtCore -Irelease -I. <br>
> -I/usr/i686-w64-mingw32/sys-root/mingw/share/qt5/mkspecs/mingw-w64-g++ <br>
> -o release/wapi.o ../src/wapi.cpp<br>
> ../src/wapi.cpp:25:10: fatal error: AccCtrl.h: No such file or directory<br>
> 25 | #include <AccCtrl.h><br>
> | ^~~~~~~~~~~<br>
> <br>
> I couldn't find anything that provided that on my system so I simply <br>
> removed it. And that seems to compile okay.<br>
> <br>
> Ah, just realized I'm on a case sensitive system, so changing that to <br>
> <accctrl.h> works too. But perhaps it isn't really needed?<br>
> <br>
> On 5/9/23 11:27, Ulrich Sibiller wrote:<br>
>> Hi again,<br>
>><br>
>> the current upstream of x2goclient contains these lines. So it looks<br>
>> like your QT_VERSION is not set correctly. (see<br>
>> <a href="https://code.x2go.org/gitweb?p=x2goclient.git;a=blob;f=src/wapi.cpp;h=12732c24b7b7cbf2da4cc8b0d0d9f782646960d3;hb=HEAD" rel="noreferrer noreferrer" target="_blank">https://code.x2go.org/gitweb?p=x2goclient.git;a=blob;f=src/wapi.cpp;h=12732c24b7b7cbf2da4cc8b0d0d9f782646960d3;hb=HEAD</a>)<br>
>><br>
>> Uli<br>
>><br>
>> On Tue, May 9, 2023 at 7:25 PM Ulrich Sibiller<br>
>> <<a href="mailto:ulrich.sibiller@gmail.com" target="_blank" rel="noreferrer">ulrich.sibiller@gmail.com</a>> wrote:<br>
>>><br>
>>> Iirc I have made some patches for the windows version. I thought they <br>
>>> had been merged but I must check that. For now try this:<br>
>>><br>
>>><br>
>>> #if QT_VERSION >= 0x050200<br>
>>> largeIcon=QtWin::toHICON(icon.scaled(iconx,icony, <br>
>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation));<br>
>>> smallIcon=QtWin::toHICON(icon.scaled(smallx,smally, <br>
>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation));<br>
>>> #else<br>
>>> largeIcon=icon.scaled(iconx,icony, <br>
>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON();<br>
>>> smallIcon=icon.scaled(smallx,smally, <br>
>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON();<br>
>>> #endif<br>
>>><br>
>>><br>
>>> Uli<br>
>>><br>
>>> Orion Poplawski <<a href="mailto:orion@nwra.com" target="_blank" rel="noreferrer">orion@nwra.com</a>> schrieb am Di., 9. Mai 2023, 19:00:<br>
>>>><br>
>>>> Package: x2goclient<br>
>>>> Version: 4.1.2.2<br>
>>>> Tag: patch<br>
>>>><br>
>>>><br>
>>>> When compiling against Qt5 5.15.9 I get:<br>
>>>><br>
>>>> ../src/wapi.cpp: In function 'void wapiSetWindowIcon(HWND, const <br>
>>>> QPixmap&)':<br>
>>>> ../src/wapi.cpp:224:88: error: 'class QPixmap' has no member named<br>
>>>> 'toWinHICON'<br>
>>>> 224 | largeIcon=icon.scaled(iconx,icony,<br>
>>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();<br>
>>>> | ^~~~~~~~~~<br>
>>>> ../src/wapi.cpp:225:90: error: 'class QPixmap' has no member named<br>
>>>> 'toWinHICON'<br>
>>>> 225 | smallIcon=icon.scaled(smallx,smally,<br>
>>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();<br>
>>>> | ^~~~~~~~~~<br>
>>>><br>
>>>> Now, the only call to wapiSetWindowIcon() is commented out, so I just<br>
>>>> commented out the wapiSetWindowIcon() code as we... Looks like the<br>
>>>> current function to use is QImage::toHICON().<br>
>>>><br>
>>>> I'm also curious that you need to shift to a Windows API call -<br>
>>>> shouldn't we be able to do everything in Qt?<br>
>>>><br>
>>>><br>
>>>><br>
>>>> -- <br>
>>>> Orion Poplawski<br>
>>>> he/him/his - surely the least important thing about me<br>
>>>> IT Systems Manager 720-772-5637<br>
>>>> NWRA, Boulder/CoRA Office FAX: 303-415-9702<br>
>>>> 3380 Mitchell Lane <a href="mailto:orion@nwra.com" target="_blank" rel="noreferrer">orion@nwra.com</a><br>
>>>> Boulder, CO 80301 <br>
>>>> <a href="https://www.nwra.com/_______________________________________________" rel="noreferrer noreferrer" target="_blank">https://www.nwra.com/_______________________________________________</a><br>
>>>> x2go-dev mailing list<br>
>>>> <a href="mailto:x2go-dev@lists.x2go.org" target="_blank" rel="noreferrer">x2go-dev@lists.x2go.org</a><br>
>>>> <a href="https://lists.x2go.org/listinfo/x2go-dev" rel="noreferrer noreferrer" target="_blank">https://lists.x2go.org/listinfo/x2go-dev</a><br>
> <br>
<br>
-- <br>
Orion Poplawski<br>
he/him/his - surely the least important thing about me<br>
IT Systems Manager 720-772-5637<br>
NWRA, Boulder/CoRA Office FAX: 303-415-9702<br>
3380 Mitchell Lane <a href="mailto:orion@nwra.com" target="_blank" rel="noreferrer">orion@nwra.com</a><br>
Boulder, CO 80301 <a href="https://www.nwra.com/" rel="noreferrer noreferrer" target="_blank">https://www.nwra.com/</a><br>
<br>
</blockquote></div>