<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Dear list members,<div class=""><br class=""></div><div class="">I recently managed to make our python-x2go based app run on Mac OS with some tiny changes to python-x2go, so I wanted to share these changes with others and suggest merging them upstream.</div><div class=""><br class=""></div><div class="">The first problem was in defaults.py, which includes some specific settings for different OSes based on platform.system(). The problem is, that the section for Mac OS wrongly assumes that <font color="#000000" class="">platform.system() returns ‘Mac’, while it actually returns ‘Darwin’. AFAIK, it has always been so. For more insight see for example <span style="caret-color: rgb(0, 0, 0);" class=""><a href="https://bugs.python.org/issue7850" class="">https://bugs.python.org/issue7850</a>. The attached file 0001-Fix-Mac-OS-recognition.patch fixes that.</span></font></div><div class=""><font color="#000000" class=""><span style="caret-color: rgb(0, 0, 0);" class=""><br class=""></span></font></div><div class=""><font color="#000000" class="">The second problem was that we need to install the NX proxy binary to a different path than "/usr/bin/nxproxy”. For that purpose I made use of the environment variable NXPROXY_BINARY which is already used on Windows. This is implemented by the second patch file 0002-Respect-NXPROXY_BINARY-also-on-non-Windows-systems.patch. For consistency, it might also make sense to use this variable only if it contains a valid path, as it is done on Windows, but I didn’t do that in the patch.</font></div><div class=""><font color="#000000" class=""><span style="caret-color: rgb(0, 0, 0);" class=""><br class=""></span></font></div><div class=""><font color="#000000" class=""><span style="caret-color: rgb(0, 0, 0);" class="">Thank you for considering merging these patches upstream and thank you for the great work on X2Go.</span></font></div><div class=""><font color="#000000" class=""><span style="caret-color: rgb(0, 0, 0);" class=""><br class=""></span></font></div><div class=""><font color="#000000" class=""><span style="caret-color: rgb(0, 0, 0);" class="">Best regards</span></font></div><div class=""><font color="#000000" class=""><span style="caret-color: rgb(0, 0, 0);" class=""><br class=""></span></font></div><div class=""><font color="#000000" class=""><span style="caret-color: rgb(0, 0, 0);" class="">Tomas Cerha</span></font></div><div class=""><br class=""></div><div class=""></div></body></html>