[X2Go-Dev] Code formatting

[Ulrich Sibiller]

Yeah, that's right. But I was referring to session start, ssh stuff and
interactive user input.

Uli

Melroy van den Berg <melroy89 at protonmail.com> schrieb am Mi., 20. Mai 2020,
18:32:

> Hi Uli,
>
> Thanks for the links to Xorg.
>
> > As always this is quite difficult to achieve for a client/server setup
> > with interactive tools....
>
> I don't agree. Unit testing is a test technique were you isolate the code
> from the rest of the context and create a stub/mock in place of that.
> This allows you you test pieces of your code (like a function) in
> isolation.
>
> Moreover, when something is hard to test means that you may want to invest
> time in refactoring for test ability.
> Only for integration testcases between client & server you need to create
> a test approach, like you may want to mock the whole server side (if you
> want to test the client side).
>
> But the important take away from this mail is that there are different
> levels of testing. Where unit testing in the first level and can easily be
> done.
>
> Regards,
> Melroy van den Berg
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> Op woensdag, mei 20, 2020 5:44 PM, Ulrich Sibiller <
> ulrich.sibiller at gmail.com> schreef:
>
> > On Wed, May 20, 2020 at 5:20 PM Melroy van den Berg
> > melroy89 at protonmail.com wrote:
> >
> > > I'm afraid I was the cause of the start of the discussion. I'm also
> using VS Code now, which has a built-in way to auto format the code (incl
> C++).
> > > Using the shortcut: Ctrl + Shift + I (capital i)
> > > Yet there are otherwise, like clang auto formatter. Instead of using
> right away. We may need to discuss and agree as a community which tool we
> will use.
> > > And also which settings will be used, ideally be stored into the git
> repo (root folder), which then get picked up by the relevant tool.
> >
> > For Xorg they simply used a shell script that took care of a clean
> > formatting, see e.g. here:
> >
> https://github.com/XQuartz/xorg-server/commit/9838b7032ea9792bec21af424c53c07078636d21
> >
> > > In fact, I'm would like to go to next level, namely automated CI/CD.
> Which may include auto-formatter, other tools maybe like static code
> analysis (cppcheck), generation of documentation (from source code) and
> running testcases within a pipeline.
> >
> > Maybe Mihai and Mike#1 can explain what we already have here. IIRC
> > there's jenkins server and there are nightly builds ("heuler" repos).
> > For nx-libs we have some stuff on travis (including cppcheck) and on
> > LGTM (non-working because it does not find the C sources for unknown
> > reasons).
> >
> > > Read my message #62 on bug report:
> https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1469#62
> > > Ps. Where are the testcases? We may need to start creating
> (integration/unit) testcases to avoid regression issues when changing code.
> >
> > As always this is quite difficult to achieve for a client/server setup
> > with interactive tools....
> >
> > Uli
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200520/424493be/attachment-0001.htm>