[X2Go-Dev] Bug#1469: But wait; there is more... patches!

[Melroy van den Berg]

Hi Mike & Uli,

As Mike suggested, I redone all changes (plus even some more bonus items).
Since I was in a separate git branch I could run the format-patch easily via:git format-patch master. Thanks for the suggestion.

@Uli I'm using the auto-formatter for C++ built-in in VS Code.

I think the end-result with all the separate patches makes more sense now, sorry I didn't do it right away. I think once I have a wiki account, I will add all these best practices your x2go wiki. Instead of Attachment: <your-patch.diff>: https://wiki.x2go.org/doku.php/wiki:bugs?s[]=git&s[]=patch#bug_submission_with_a_patch.

See the attachments for all the patches in this mail (11 in total). Thanks in advance.

Best regards,
Melroy van den Berg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-endl-for-every-debug-line.patch
Type: text/x-patch
Size: 25784 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-send-eof-before-close.patch
Type: text/x-patch
Size: 835 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-return-false-in-all-bad-cases.patch
Type: text/x-patch
Size: 765 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Remove-deprecated-call-and-use-new-libssh-API-call.-.patch
Type: text/x-patch
Size: 1331 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Refactor-and-fix-channel-session-closes.patch
Type: text/x-patch
Size: 15958 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Fix-when-not-password-auth.-Otherwise-you-get-double.patch
Type: text/x-patch
Size: 1145 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Mark-as-unused-explicitly.patch
Type: text/x-patch
Size: 1463 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-improve-gitignore-why-not.patch
Type: text/x-patch
Size: 499 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Correct-retval-check.-Plus-some-minor-formatting.patch
Type: text/x-patch
Size: 1014 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Another-missing-endl.patch
Type: text/x-patch
Size: 1050 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-First-auto-format-the-code-for-readability-and-human.patch
Type: text/x-patch
Size: 132022 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200519/43672b14/attachment-0021.bin>