[X2Go-Dev] Bug#1476: x2goclient interface code needs refactoring to make it more accessible and make improvements easier to implement and test

[Dave Chamberlin-Kidd]

Package: x2goclient
Version: 4.1.2.3
Severity: wishlist
Tag: patch

There are a number of minor issues, oddities and limitations with the
current x2goclient gui which would be good to fix, resolve and improve on.
Like all projects however the core team have more important issues to
resolve. The code in its current state is difficult to understand and amend
and as it has no tests it is risky for developers to make functional
changes unless they spend a lot of time getting to know the code and doing
extensive manual testing.

Attached are 10 small refactorings which start extracting out some of the
code into smaller functions. As the code is separated out it becomes easier
to understand and change.

There are no functional changes in these patches, nor do they attempt or
claim to fix any known issues. On their own the benefit of these patches is
limited however the hope is that over time I will be able to submit more
refactorings as I learn more and then start fixing issues and improving the
UI. Extracting out functions is just one of many techniques that can be
used to make code cleaner but in my experience it's a good one to start
with. It should also be noted that sometimes code is extracted "as is" even
when it is clear further refactoring can be done to improve things, this is
by design in order to keep risk and size of patches to a minimum.

Cheers
Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Refactor-Extract-geometry-setup.patch
Type: text/x-patch
Size: 2066 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Refactor-Extract-sound-setup.patch
Type: text/x-patch
Size: 1862 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Refactor-Extract-server-setup.patch
Type: text/x-patch
Size: 1405 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Refactor-Extract-edit-button-setup.patch
Type: text/x-patch
Size: 1522 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Refactor-Extract-command-setup.patch
Type: text/x-patch
Size: 1735 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Refactor-Organise-object-creation-by-feature.patch
Type: text/x-patch
Size: 3494 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Refactor-Remove-unnecessary-code.patch
Type: text/x-patch
Size: 799 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Refactor-Use-constant-for-color.patch
Type: text/x-patch
Size: 1212 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Refactor-Extract-geometry-box-setup.patch
Type: text/x-patch
Size: 2019 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refactor-Extract-palette-setup.patch
Type: text/x-patch
Size: 3548 bytes
Desc: not available
URL: <https://lists.x2go.org/pipermail/x2go-dev/attachments/20200607/a1648bda/attachment-0019.bin>