[X2Go-Dev] Bug in sshproxy handling

[Ulrich Sibiller]

On Fri, May 17, 2019 at 9:31 PM Ulrich Sibiller
<ulrich.sibiller at gmail.com> wrote:
> Alternatively we could add a hack: if the proxy hostname has some
> special form, e.g. "!hostname", that very check will be skipped. As
> proxy and normal hosts are both controlled via the same code in
> SshmasterConnection this way the user could configure that for both
> connections independently.

I have just implemented that, see attached patch 0001. It makes my
setup work.  What do you think of this approach?

While doing that I also noticed that checkLogin() is missing some
cleanup code, see attached patch 0002.

Uli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Skip-checkLogin-if-hostname-starts-with.patch
Type: application/x-patch
Size: 2495 bytes
Desc: not available
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20190517/187b9594/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-checkLogin-close-channel-on-failure.patch
Type: application/x-patch
Size: 2406 bytes
Desc: not available
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20190517/187b9594/attachment-0001.bin>