[X2Go-Dev] Bug#1035: Bug#1035: capture x2goruncommand debug output for x2gofeature X2GO_XSESSION

[Mike Gabriel]

Control: fixed -1 4.0.1.20
Control: close -1

Hi Tor,

On  Fr 13 Mai 2016 18:58:12 CEST, Tor Perkins wrote:

> Package: x2goserver
> Version: 4.0.1.19
> Tags: patch
>
>
> Hello,
>
> I had recently had a problem with my /etc/xprofile file that
> prevented session startup.  The details are not too important; it
> had to do with a difference of default shell (/bin/sh) being either
> /bin/dash or /bin/bash.
>
> After enabling the 'debug' loglevel on the server, I still had no
> helpful output indicating what the problem might be...
>
> I did some ferreting about and noticed that x2goruncommand was not
> capturing cmd output when using x2gofeature X2GO_XSESSION
> (/etc/x2go/Xsession).  The client side invocation of x2goruncommand
> (via sshlib) redirects remote command output to /dev/null, so it is
> also not preserved when using the client's --debug option...
>
> This small patch appends the missing output to an already existing
> debug file in x2goruncommand ($MESSAGE_FILE).  With this in place, I
> was able to see the "smoking gun":
>
>   cat ~/.x2go/C-user-50-1463156913_stD.Xclients_dp24/cmdoutput
>
>     exec /root/.Xclients
>     Loading profile from /etc/profile
>     Loading profile from /root/.profile
>     Loading profile from /etc/xprofile
>     /etc/xprofile: 14: Bad substitution        <--  whoop!
>
> The file is deleted (as before) if not at loglevel debug.
>
> Thanks for your consideration.
>
> - Tor

You may have missed it, as this bug never got closed. However, your  
patch became part of 4.0.1.20.

So closing this bug manually now. Thanks for your patch.

Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20181121/9842a117/attachment-0001.sig>