[X2Go-Dev] Effective username not correct in Session ID because of plus sign in user names (Windows AD / Samba4)

[Mihai Moldovan]

* On 03/20/2018 10:29 AM, j.rohde at nederlandlive.nl wrote:
> Hi All,
> 
> I've encountered a problem with the latest ppa packages (stable:
> 4.1.0.0-0~1517~ubuntu14.04.1).
> My system runs a samba4 server and my users are named:
> 
> "DOMAIN+user" (the plus sign is a literal plus / AD style).
> 
> When the session ID for x2go is formed/created the plus sign is stripped
> from the user name apparently.
> This gives (at least) a problem when changing the state in de DB:
> 
> In /usr/share/perl5/X2Go/Server/DB/SQLite3.pm line 403 an attempt is
> made to get the 'effective' user name, but that will never happen
> because of the stripped out plus sign. As a consequence sessions are not
> terminated/suspended/etc..
> For now i've made it so my $effective_user == $realuser, but this breaks
> desktop sharing functionality.
> 
> Sort of the same bug was present in earlier versions, but was fixed
> later on.
> I've tried to find the script/code where the session id is formed, but
> could not find it yet.
> I guess that's where this should be fixed though.
> 
> Is it possible to get support for these style of user names?!

There are also problems with backslashes and other characters in user names.

They originate from a new sanitization feature in X2Go Server that drops
characters not deemed suitable for a username.

A plus sign might not be part of the allowed character set, which would explain
this behavior.

We've had such an discussion before and I'm still not completely sure what to do
with it. It sounded like sanitization was a good idea at first, but seeing it
causes problems often (well, for AD and NIS users only most of the time), maybe
I should rework this and just accept any input.


Not sure if that is a smart idea, though.



Mihai


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20180320/96b72bc5/attachment-0001.sig>