[X2Go-Dev] Bug#1153: Bug#1153: x2goruncommand must stop exporting LD_LIBRARY_PATH with nx-libs 3.6.x

[Mike Gabriel]

Hi Mihai

On  Di 07 Mär 2017 19:23:11 CET, Mike Gabriel wrote:

> Package: x2goserver
> Severity: important
> Version: 4.1.0.0
> Control: tags -1 patch
>
>
> In Arctica's nx-libs, we changed the path where the libX11.so  
> symlinks to libNX_X11.so reside.
>
> This makes applications in X2Go behave strange esp. Actually, the  
> LD_LIBRARY_PATH setup is for nx-libs 3.5.0.x and obsolete in 3.6.x.
>
> Here is a simple patch that stops setting LD_LIBRARY_PATH, if  
> nx-libs 3.6.x is installed:
>
> ```
> diff --git a/x2goserver/bin/x2goruncommand b/x2goserver/bin/x2goruncommand
> index 8c3ee62..4593539 100755
> --- a/x2goserver/bin/x2goruncommand
> +++ b/x2goserver/bin/x2goruncommand
> @@ -68,14 +68,16 @@ if [ -S "$SSH_AUTH_SOCK" ]; then
>  fi
>  export SSH_AUTH_SOCK="$X2GOSSH_AUTH_SOCK"
>
> -
> -NX_XINERAMA_LIBS="$(x2gopath xinerama)"
> -NX_LIBS="$(x2gopath nx-x11)"
> -test -n "$LD_LIBRARY_PATH" && \
> -       LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS:$LD_LIBRARY_PATH" || \
> -       LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS"
> -"$X2GO_LIB_PATH/x2gosyslog" "$0" "debug" "exporting  
> LD_LIBRARY_PATH=$LD_LIBRARY_PATH"
> -export LD_LIBRARY_PATH
> +if ! x2gofeature X2GOAGENT_RANDRXINERAMA 1>/dev/null; then
> +
> +       NX_XINERAMA_LIBS="$(x2gopath xinerama)"
> +       NX_LIBS="$(x2gopath nx-x11)"
> +       test -n "$LD_LIBRARY_PATH" && \
> +                
> LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS:$LD_LIBRARY_PATH" || \
> +               LD_LIBRARY_PATH="$NX_XINERAMA_LIBS:$NX_LIBS"
> +       "$X2GO_LIB_PATH/x2gosyslog" "$0" "debug" "exporting  
> LD_LIBRARY_PATH=$LD_LIBRARY_PATH"
> +       export LD_LIBRARY_PATH
> +fi
>
>  if [ "$sndsys" == "esd" ]; then
>         export ESPEAKER="localhost:$4"
>
> ```

Can you make sure that this patch is also backported to the  
release/4.0.1.x branch? In case X2Go switches to nx-libs 3.6.x earlier  
than releasing X2Go Server 4.1.0.0.

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20170308/07b0531c/attachment.sig>