[X2Go-Dev] FYI: I updated the Fedora Rawhide mock files onjenkins

[Michael DePaulo]

On Tue, Mar 31, 2015 at 2:33 PM, Mihai Moldovan <ionic at ionic.de> wrote:
> On 31.03.2015 08:02 PM, Mihai Moldovan wrote:
>> On 31.03.2015 02:53 PM, Michael DePaulo wrote:
>>> On Japsand, which Jenkins builds on, I updated the mock files
>>> (/etc/mock/*.cfg) for Fedora Rawhide to their mock 1.2.7-1 versions:
>>> https://apps.fedoraproject.org/packages/mock/changelog/
>> Note that /etc/mock/*.cfg isn't used anymore for the current builds,
>> neither for manual builds nor Jenkins... so changing stuff there does
>> absolutely nothing.

I believe you are mistaken. The newly X2Go rawhide RPMs are for fc23
rather than fc22:
http://packages.x2go.org/fedora/rawhide/heuler/x86_64/rpms/nx-libs/

This indicates that the mock config files are being used.

>> Also, as far as I've seen, the new config didn't add anything
>> interesting but DNF support, which I assumed to be automatic. Maybe that
>> wasn't the case.
>

See above.

> Besides, mock on Jenkins is at 1.1.33 (< 1.2.7) and I feared that some
> changes in the config file may be incompatible with this rather version.
> I *did* diff the fedora-rawhide config file against the newest one from
> mock's git repository, but as there was a chance for breaking it
> completely and it not introducing any real benefit, I left it out.
>
> For instance, it changes the buildsys-build groupinstall command to just
> install with an additional @ sign, or mirrorlink yum config lines to
> metalink ones. That's not really changing anything, especially the first
> change is merely another way to express the same thing.
>
> However, setting /run/lock as extra directory did sound weird. Why would
> that need to be defined in the mock config file? Shouldn't that
> directory be created automatically? The pre-23 mock config files as
> shipped by Debian Stale Backports (the mentioned 1.1.33 version) didn't
> have that for any Fedora release, while in 1.2.x that was added to
> pretty much all of them, even old ones.
>
> I decided to better not change the files as there was potential for
> breakage and no clearly cut out reason for this option.
>
> Anyway, I guess I'll just be merging that and see how it goes.
>
> Also, next time you do any changes, PLEASE copy the original files
> either by making a copy of the original /etc/mock directory or the
> individual files there with a .bak or similar extension.
>
> Reverting changes to config files on Debian is a pain, because Debian
> has no sane way to just get the original config file as shipped by the
> package, other than either deleting the files completely and forcing
> unpacking the original config files or unpacking the .deb file manually.
> Neither of these options are really sane.
>
>
>
> Mihai

Yeah, sorry, I was in a hurry.

I think these were the old versions:
https://git.fedorahosted.org/cgit/mock.git/tree/etc/mock?id=mock-1.2.2
(Mock 1.2.2 was released on 2014-11-18).

BTW, an easy solution to this problem is etckeeper + git:
https://packages.debian.org/wheezy/etckeeper

-Mike#2