[X2Go-Dev] Issue with ssh-agent fix for bug #672

[Daryl Clevenger]

Folks,

I run x2go sessions for weeks, so just recently noticed this regression 
after a recent update from ppa:x2go/stable. I'm running

% cat /etc/lsb-release
DISTRIB_ID=LinuxMint
DISTRIB_RELEASE=17
DISTRIB_CODENAME=qiana
DISTRIB_DESCRIPTION="Linux Mint 17 Qiana"

The fix was for http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=672 and 
the commit
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7fdcc5d

The issue is that when starting a new session, the SSH_AUTH_SOCKET is 
always set. As a result, on Linux Mint 17 the following code in 
/etc/x2go/Xsession.d/90x11-common_ssh-agent is bypassed

if has_option use-ssh-agent; then
   if [ -x "$SSHAGENT" ] && [ -z "$SSH_AUTH_SOCK" ] \
      && [ -z "$SSH2_AUTH_SOCK" ]; then
     STARTSSH=yes
     if [ -f /usr/bin/ssh-add1 ] && cmp -s $SSHAGENT /usr/bin/ssh-agent2; then
       # use ssh-agent2's ssh-agent1 compatibility mode
       SSHAGENTARGS=-1
     fi
   fi
fi

since -z "$SSH_AUTH_SOCK" fails.

I have a work around in my ~/.xsessionrc-x2go, but it seems that the 
export should only occur when the symlink is created.

I personally would use &&,

ln -sf "$SSH_AUTH_SOCK" "$X2GOSSH_AUTH_SOCK" && export SSH_AUTH_SOCK="$X2GOSSH_AUTH_SOCK"


but the GNU ln documentation lacks any documentation about exit status 
for ln(1).

-- 
Daryl Clevenger

P.S. I considered replying via  672 at bugs.x2go.org, but did not know if that is appropriate for done/closed, etc. bugs.