[X2Go-Dev] [X2Go-Commits] [nx-libs] 28/52: CVE-2014-0210: unvalidated length fields in fs_read_list() from xorg/lib/libXfont commit 5fa73ac18474be3032ee7af9c6e29deab163ea39

Mihai Moldovan ionic at ionic.de
Mon Feb 16 20:23:23 CET 2015


On 16.02.2015 09:29 AM, Ulrich Sibiller wrote:
> On Sun, Feb 15, 2015 at 10:02 PM, Mihai Moldovan <ionic at ionic.de> wrote:
>> Just as a heads-up: I would have moved this into the for loop condition
>> like so:
> The code might offer a lot of possibilities for improvement. However,
> as all this is derived from the original X11 code I would prefer
> leaving it as is (and fix it upstream). This will make it a lot easier
> to backport later patches and it will also make the nx transition to
> current X11 much easier.  Maybe add FIXME: comments to not forget
> those ideas.
>
> Uli

You're right. That's why I have only changed initialization where
conflicts are easily merged and the 1 MB thing.

Everything else was left in place. I'm just bringing it up so that
people don't follow (bad) examples.


Mihai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20150216/b5db6935/attachment.pgp>


More information about the x2go-dev mailing list