[X2Go-Dev] Bug#642: Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Mike Gabriel
mike.gabriel at das-netzwerkteam.de
Tue Oct 28 08:55:09 CET 2014
Hi George,
On Di 28 Okt 2014 06:15:54 CET, George Trakatelis wrote:
> Hi Michael,
>
> Now that release 4.0.3.0 of x2goclient is out,
> I attach my proposed changes and comment on each one:
>
> 1. conform-to-stricter-type-checking-mingw482.patch
>
> Even mingw's debug build complains about this char *
> not having been declared as ought to be (const char *)
> and suggests using -fpermissive (not recommended).
>
> 2. conform-to-stricter-type-checking-VS2010.patch
>
> a. A type-cast to match one of pow's declarations {float pow(float
> x, int y);}
> b. In pure Windows there's no close() function to close a socket.
> So you have to use closesocket() instead.
> c. Include winsock2.h just before windows.h (also recommended by mingw).
>
> 3. add-libraries-to-build-with-VS2010.patch
>
> a. A new batch file to configure x2goclient for VS2010 build
> (config_win_vs.bat).
> I have just substituted nmake for mingw32-make.
> Please remember to also use 'nmake' or 'nmake debug' when building.
> b. Added necessary win32 libraries.
>
> George
Thanks a lot for providing those patches.
Will applying all those patches provide enough reason/solution to
close this bug (#642)?
Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20141028/6da4ae8c/attachment.pgp>
More information about the x2go-dev
mailing list