[X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mike Gabriel]

Hi Alex,

On  So 29 Jun 2014 20:02:57 CEST, Mihai Moldovan wrote:

> Hi Alex,
>
> * On 27.06.2014 09:36 pm, Oleksandr Shneyder wrote:
>> The list is never empty, it have at least 1. argument - it is always
>> executable name.
>
> args will be empty on OS X and Linux, if no argument has been passed to
> x2goclient.exe.
>
>> I'll leave my solution here, because in a case of linux
>> or mac if x2goclient started without arguments list don't need to be
>> initialized.
>
> Granted, OS and Linux don't currently use args, but what if they did? I don't
> like different behavior based on the OS.
>
> If you really want to differentiate, use
>
> 106     QStringList args;
> 107 #ifdef Q_OS_WIN
> 108     args=app.arguments();
> 109 #else
> 110     if ( argc > 1 )
> 111         args=app.arguments();
> 112 #endif
>
> And lose the copying in lines 154ff.
>
> That will help keep the code readable.
>
> I still strongly suggest not differentiating based on the OS where  
> not necessary, like in this case.

There is one more concern about that commit to X2Go Client code that  
concerns me [1].

We will attempt at building an X2Go Client version without this commit  
[2] and see if the startup speed normalizes without it.

If so, I will remove that commit (and it fixup commit later) for the  
upcoming X2Go Client 4.0.2.1 release and re-add them after the release  
for
more introspection and improvement targetting 4.0.2.2.

Secondly, Mihai's proposal seems to make sense to me (by just having  
read everything that has been written around this issue).


Greets,
Mike


[1] http://bugs.x2go.org/525
[2]  
http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=76777fca627f287f8d721023a44646d13e13accb



-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20140629/9343bd64/attachment.pgp>