[X2Go-Dev] Bug#440: Request for patch review

Oleksandr Shneyder o.shneyder at phoca-gmbh.de
Fri Feb 28 14:23:40 CET 2014


Hi Mike,

it seems good to me. However I can not apply this patch on master branch:

$ git apply --check switch-to-QNetworkAccessManager.patch
error: patch failed: httpbrokerclient.cpp:93
error: httpbrokerclient.cpp: patch does not apply
error: patch failed: httpbrokerclient.h:62
error: httpbrokerclient.h: patch does not apply

please send correct patch for master branch *without* trailing
whitespaces and I'll test and apply it.

regards,
Alex

Am 27.02.2014 16:15, schrieb Mike Gabriel:
> Hi Alex,
> 
> can you please review the proposed patch in #440 [1]?
> 
> Thanks,
> Mike
> 
> [1] http://bugs.x2go.org/440


-- 
----------------------------------------------------
Oleksandr Shneyder  | Email: o.shneyder at phoca-gmbh.de
phoca GmbH          | Tel. : 0911 - 14870374 0
Bräuhausgasse 9     | Fax. : 0911 - 14870374 9
D-82205 Gilching    | Mobil: 0163 - 49 64 461

Geschäftsführung:
Dipl.-Inf. Oleksandr Shneyder

Amtsgericht München | http://www.phoca-gmbh.de
HRB 196 658         | http://www.x2go.org
USt-IdNr.: DE281977973
----------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20140228/9ab62052/attachment.pgp>


More information about the x2go-dev mailing list