[X2Go-Dev] x2goserver: enable PIE completely

[Mike Gabriel]

Hi Jan,

On So 02 Sep 2012 01:30:29 CEST Jan Engelhardt wrote:

> build: enable PIE completely
>
> rpmlint reports: x2goserver.x86_64: E:
> non-position-independent-executable (Badness: 10000)
> /usr/lib/x2go/x2gosqlitewrapper. This executable must be position
> independent. Check that it is built with -fPIE/-fpie in compiler
> flags and -pie in linker flags.
>
> Not only compile with -fPIE, but also pass -pie for the linker
> as LDFLAGS.
>
> ---
>  x2goserver/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: x2goserver-3.1.1.3/x2goserver/Makefile
> ===================================================================
> --- x2goserver-3.1.1.3.orig/x2goserver/Makefile
> +++ x2goserver-3.1.1.3/x2goserver/Makefile
> @@ -37,7 +37,7 @@ build: build-arch build-indep
>  build-arch: build_setgidwrappers
>
>  build_setgidwrappers:
> -	gcc -fPIE -o x2gosqlitewrapper x2gosqlitewrapper.c
> +	gcc -fPIE -pie -o x2gosqlitewrapper x2gosqlitewrapper.c
>
>  build-indep: build_man2html

thanks for another patch... Committed!
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=6b41cef9e10da4dee9f16c36f273c3d723208953

Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20120902/3c7277b2/attachment.pgp>