[X2Go-Dev] Usernames with dashes causes errors?

[Mike Gabriel]

Hi Jan, hi Alex et al.

On Di 21 Feb 2012 13:18:27 CET Jan Engelhardt wrote:

>
> On Tuesday 2012-02-21 12:58, christoffer krakou wrote:
>
>> We had some strange problems, though. We contacted a school, who
>> would help us test the server under daily use, and made some test
>> users for them, called "test-*their name*". When they, and i, tried
>> to log into those users, the client would freeze, no error message
>> or anything. On the server, the x2goagent would run amok, soaking up
>> CPU power. The problem seems to occur only on users with dashes in
>> their names.
>
> Hm, and I would have expected for it to be usernames with spaces to
> go havoc (those occur esp. in winbind-ed environments), since the
> x2go stack has a notorious underquoting of shell variables all over
> the place.
>
> [Exhibit 1]
> ./x2goserver_3.0.99.10/x2goserver/bin/x2gostartagent:
> OUTPUT=`x2godesktopsharing client $X2GO_CLIENT $X2GO_GEOMETRY $X2GO_LINK
> $X2GO_PACK $X2GO_TYPE $X2GO_KBD_LAYOUT $X2GO_KBD_TYPE $X2GO_SET_KBD  
> $X2GO_STYPE
> $X2GO_CMD $USER`

This has been fixed by two of my latest commits to x2goserver.git. The  
shell scripts in the x2goserver package now have many quote pairs  
where useful and sensible.

Greets,
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, dorfstr. 27, 24245 barmissen
fon: +49 (4302) 281418, fax: +49 (4302) 281419

GnuPG Key ID 0xB588399B
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20120221/1e9015a3/attachment.pgp>