[X2Go-Dev] x2godesktopsharing: Full Access not available for other users?

[Mike Gabriel]

Hi Milan,

On So 19 Feb 2012 21:22:29 CET Milan Knížek wrote:

> Oops, made few mistakes in package names, corrected below.
>
> Sorry,
> Milan
>
> V Sun, 19 Feb 2012 21:14:30 +0100
> Milan Knížek <knizek.confy at gmail.com> napsáno:
>
>> Hello list!
>>
>> I am a bit confused re. the discrepancy between wiki and actual
>> behaviour of x2godesktop sharing:
>>
>> x the wiki [1] reads that
>>     With the desktopsharing function of X2go you can have full-access
>>     the desktop from somebody else...
>>
>> x when I (USER_B) connect from a remote machine with x2goclient to
>> "local desktop" (USER_A logged in on tty7 of x2goserver), the
>> USER_A's session is shown in the lists of sessions available for
>> sharing, however the button "Full Access" is greyed-out and cannot be
>> clicked. So USER_B is only allowed to view the USER_A's deskto.
>>
>> x having looked at x2godesktopsharing.git/sharetray.cpp, I can see
>                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>                      x2goclient.git/onmainwindow_part2.cpp
>
>> that this is due to "bShadow->SetEnabled ( user==getCurrentUname()
>> );" and have verified that the following patch removes the limitation:
>>
>> ===
>> --- onmainwindow_part2.cpp<---->2011-11-25 13:08:10.000000000 +0100
>> +++ onmainwindow_part2.cpp_mod<>2012-02-19 19:50:36.200838546 +0100
>> @@ -1132,7 +1132,7 @@
>>                           index.row(),
>>                           D_USER ).data().toString();
>>          bShadowView->setEnabled ( true );
>> -        bShadow->setEnabled ( user==getCurrentUname() );
>> +        bShadow->setEnabled ( true );
>>      }
>>  }
>>
>> ===
>>
>> Is this intentional behaviour due to the potential security issues
>> mentioned here [2] (anyway, the remote user _can_ recompile the
>> x2goagent to get rid of the limitation)?
>   ^^^^^^^^^
>   x2goclient

I have discussed this with Heinz quite a lot. In X2GoClient this  
feature is disabled on purpose. In Python X2Go the shadow session  
feature is also available and it is also possible to have full access  
sessions between different users.

With pyhoca-cli the shadow session support is already available, with  
pyhoca-gui I plan to add it for version 0.1.2.0 (i.e. Git HEAD).

@Heinz+Alex: could you please give a statement on this? Thanks, Mike.

*** Mike would love to see Milan's patch included in x2goclient, but I  
cannot commit it without a go from Heinz+Alex.

Greets,
Mike




-- 

DAS-NETZWERKTEAM
mike gabriel, dorfstr. 27, 24245 barmissen
fon: +49 (4302) 281418, fax: +49 (4302) 281419

GnuPG Key ID 0xB588399B
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20120219/772ae826/attachment.pgp>