[X2Go-Dev] x2go for Fedora packaging issues

[Mike Gabriel]

Hi Orion,

On Mi 12 Dez 2012 00:11:02 CET Orion Poplawski wrote:

> I'm looking at packaging x2go for Fedora and am running into a few  
> issues which I'm hoping to get resolved.
>
> nx-libs:
> - bin/Makefile doesn't support DESTDIR.  The attached   
> nx-libs-destdir.patch partially addresses that.
> - The various nx*/configure.in files do not honor passed in compiler  
> flags. The attached nx-libs-optflags.patch fixes that.  Note also  
> though that CFLAGS is used in some and CPPFLAGS in others.
> - Is there a preferred way to install into /usr rather than  
> /usr/local?  I ended up doing:
>   sed -i -e 's,/usr/local,/usr,' nx-X11/config/cf/site.def
> - It would be very nice if you could support installing into  
> /usr/lib64.  I had to do the following:
>
>   sed -i -e 's,/lib/nx,/%{_lib}/nx,' nx-X11/config/cf/X11.tmpl
>   sed -i -e 's,/usr/lib/,/usr/%{_lib}/,' bin/*
>
>   make install ... USRLIBDIR=/usr/lib64/nx SHLIBDIR=/usr/lib64/nx
>
>   # Make sure x2goagent is linked relative and on 64-bit
>   rm -rf %{buildroot}%{_prefix}/lib/x2go
>   mkdir -p %{buildroot}%{_libdir}/x2go/bin
>   ln -sf ../../nx/bin/nxagent %{buildroot}%{_libdir}/x2go/bin/x2goagent

Can you break this down to a patch against the current nx-libs.git on  
http://git.x2go.org? If yes, then we will apply that patch (after  
testing it).

Please note that Jan Engelhard already contributed a patch that  
addresses flexibility with choosing custom install locations. This  
patch is found in X2Go Server:
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=75798658a1934df1e9f5038ed140235b356b5f5c
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=1fe04071bb1b318dfe43fcbe48e985f554b2fb79

Please base your work on that latest change of code. Also: if  
possible, only send patches against our code in Git.

> x2goserver:
> - Does not honor passed in CFLAGS.  The attached  
> x2goserver-cflags.patch fixes.
> - Again, very hard to use /usr/lib64...

I have forwarded the patch to X2Go BTS [1]. Please read [2] before  
sending more patches. Please use X2Go BTS for reporting bugs, sending  
patches.

[1] http://bugs.x2go.org/83
[2] http://bugs.x2go.org/Reporting.html


> x2goclient:
> - Required the attached x2goclient-include.patch to build.  There is  
> no qt4 prefix on Fedora, and in general that should be specified by  
> -I...

Already in Vcs:
http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=1412f5a6d4031ef191caa5cc1c3f8be870552b30

Greets,
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20121212/cbf77158/attachment.pgp>