[X2Go-Dev] @Alex, @Mike - more info - BUG REPORT - X2Go Client 3.99.2.1-rc2 does not work on Windows XP

[Stefan Baur]

Am 18.04.2012 21:22, schrieb Oleksandr Shneyder:
> Am 18.04.2012 18:25, schrieb Stefan Baur:
>> Am 18.04.2012 18:21, schrieb John A. Sullivan III:
>>> On Wed, 2012-04-18 at 12:57 +0200, Stefan Baur wrote:
>>>> Am 17.04.2012 12:28, schrieb Oleksandr Shneyder:
>>>>
>>> <snip>
>>>> I am unable to start the client on Windows XP (it works on Windows 7 and
>>>> Vista):
>>>>
>>>> ---------------------------
>>>> x2goclient.exe - Fehler in Anwendung
>>>> ---------------------------
>>>> Die Anwendung konnte nicht richtig initialisiert werden (0xc0150002).
>>>> Klicken Sie auf "OK", um die Anwendung zu beenden.
>>>> ---------------------------
>>>> OK
>>>> ---------------------------
>>>>
>>> <snip>
>>> Strange - I successfully installed and ran it on XP yesterday - John
>>
>> This could be because you have the files listed here
>> http://code.x2go.org/gitweb?p=pyhoca-contrib.git;a=tree;f=mswin/ms-vc-runtime;hb=74ed44ebd5f59d0eb28c89ede0beca711416089a
>> elsewhere on the machine... (Assuming it is due to the reason Mike
>> suggested in his reply.)
>>
>> Do you think you could cross-check on a fresh XP Professional SP3
>> install (no other applications installed) and
>> http://code.x2go.org/releases/binary-win32/x2goclient/x2goclient-3.99.2.1-rc2-setup.exe?

> I've build this version on our new build server (W7) installed by
> Mike(thank you once again, Mike). This is a release build, not debug. I
> have no Windows XP to try it.

I experimented a bit:
It takes two files from
http://code.x2go.org/gitweb?p=pyhoca-contrib.git;a=tree;f=mswin/ms-vc-runtime;hb=74ed44ebd5f59d0eb28c89ede0beca711416089a

Microsoft.VC90.CRT.manifest
msvcr90.dll

If I copy these into the x2goclient directory, the new client works (as 
in, starts up - haven't tried connecting yet) on XP, too.

What's strange is that the other two DLL files are not needed even 
though they are referenced in the manifest file.

@Alex + @Mike:
Could you please work this out together?  I'm not sure if all that is 
needed is to include these files into the archive that the installer 
unpacks into the x2goclient folder, or if that is an ugly hack.

Daniel Lindgren wrote:
> No problems running 3.99.2.1-rc2 on Windows XP. I have
> VC2005/VC2008/VC2010 redists all installed.

So I guess the general question is: Can (=legal?) and should (=proper 
way of handling this issue?) we include the DLL/manifest files in the 
installer, or should we require the installation of the VC<something> 
redists/pull their official installer along and run it from within ours? 
  Requiring the redists/forching their install through our installer 
probably will break portable mode, though, as it will install the files 
to the system directory and not the x2go directory...

Further info:
The last installer to run on XP without this hack is:
x2goclient-3.99.2.0-rc2-setup.exe

-Stefan