[X2go-Dev] misleading stderr output when resuming, suspending, terminating a already dead session

[Mike Gabriel]

hi devs,

I have a patch pending here that fixes misleading output to stderr...  
However, I am not sure about the scope in x2goclient (apart from  
avoiding a confusing GUI message).

Maybe we should write a proper error message to stderr here instead???

Need feedback on that, esp. from Alex. THANKS!!!

Greets,
Mike

<quote>
diff --git a/x2goserver/bin/x2goresume-session  
b/x2goserver/bin/x2goresume-session
diff --git a/x2goserver/bin/x2goresume-session  
b/x2goserver/bin/x2goresume-session
index 4c01828..59a8350 100755
--- a/x2goserver/bin/x2goresume-session
+++ b/x2goserver/bin/x2goresume-session
@@ -83,6 +83,6 @@ echo "$NEWOPTIONS" >${SESSION_DIR}/options

  $X2GO_LIB_PATH/x2goresume  $X2GO_CLIENT $SESSION_NAME  > /dev/null

-kill -HUP $X2GO_AGENT_PID &&
+kill -HUP $X2GO_AGENT_PID &>/dev/null &&
         $X2GO_LIB_PATH/x2gosyslog "$0" "notice" "client $X2GO_CLIENT  
successfully resumed session with ID $SESSION_NAME" ||
         $X2GO_LIB_PATH/x2gosyslog "$0" "err" "ERROR: client  
$X2GO_CLIENT failed to resume session with ID $SESSION_NAME"
diff --git a/x2goserver/bin/x2gosuspend-session  
b/x2goserver/bin/x2gosuspend-session
index ca342e4..1ebb272 100755
--- a/x2goserver/bin/x2gosuspend-session
+++ b/x2goserver/bin/x2gosuspend-session
@@ -39,7 +39,7 @@ killall -HUP knotify

  $X2GO_LIB_PATH/x2gochangestatus 'S' $SESSION_NAME  > /dev/null

-kill -HUP $X2GO_AGENT_PID &&
+kill -HUP $X2GO_AGENT_PID &>/dev/null &&
         $X2GO_LIB_PATH/x2gosyslog "$0" "notice" "session with ID  
$SESSION_NAME has successfully been suspended" ||
         $X2GO_LIB_PATH/x2gosyslog "$0" "err" "ERROR: failed to  
suspend session with ID $SESSION_NAME"

diff --git a/x2goserver/bin/x2goterminate-session  
b/x2goserver/bin/x2goterminate-session
index 3d8872e..d1bd2d9 100755
--- a/x2goserver/bin/x2goterminate-session
+++ b/x2goserver/bin/x2goterminate-session
@@ -35,7 +35,7 @@ X2GO_AGENT_PID=`echo "$X2GO_AGENT_PID"| awk {'print $1'}`

  $X2GO_LIB_PATH/x2gochangestatus 'F' $SESSION_NAME  > /dev/null

-kill -TERM $X2GO_AGENT_PID &&
+kill -TERM $X2GO_AGENT_PID &>/dev/null &&
         $X2GO_LIB_PATH/x2gosyslog "$0" "notice" "session with ID  
$SESSION_NAME has successfully been terminated" ||
         $X2GO_LIB_PATH/x2gosyslog "$0" "err" "ERROR: failed to  
terminate session with ID $SESSION_NAME"
</quote>


-- 

DAS-NETZWERKTEAM
mike gabriel, dorfstr. 27, 24245 barmissen
fon: +49 (4302) 281418, fax: +49 (4302) 281419

GnuPG Key ID 0xB588399B
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.x2go.org/pipermail/x2go-dev/attachments/20110913/1503bc71/attachment.pgp>