[X2Go-Commits] [x2goclient] 22/38: Revert "{pyhoca-cli, pyhoca/cli/frontend.py}: Add --ssh-passphrase feature."

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2goclient.

commit c861a11d2df00ca66c139770135a92dac5f97e35
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Fri Sep 16 20:19:21 2022 +0200

    Revert "{pyhoca-cli, pyhoca/cli/frontend.py}: Add --ssh-passphrase feature."
    
    This reverts commit 9eea371075ee1f60e24a980280c4a1d85fa2fed4.
---
 pyhoca-cli             | 5 -----
 pyhoca/cli/frontend.py | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/pyhoca-cli b/pyhoca-cli
index 3651c241..d5356997 100755
--- a/pyhoca-cli
+++ b/pyhoca-cli
@@ -181,7 +181,6 @@ x2go_options =    [
                     {'args':['--force-password'], 'default': False, 'action': 'store_true', 'help': 'enforce username/password authentication', },
                     {'args':['-p','--remote-ssh-port'], 'default': '22', 'help': 'remote SSH port (default: 22)', },
                     {'args':['-i', '-k','--ssh-privkey'], 'default': None, 'help': 'use file \'SSH_PRIVKEY\' as private key for the SSH connection (e.g. ~/.ssh/id_rsa)', },
-                    {'args':['--ssh-passphrase'], 'default': None, 'help': 'use passphrase to unlock private key \'SSH_PRIVKEY\' for the SSH connection.', },
                     {'args':['--add-to-known-hosts'], 'default': False, 'action': 'store_true', 'help': 'add RSA host key fingerprint to ~/.ssh/known_hosts if authenticity of server can\'t be established (default: not set)', },
                     {'args':['--sound'], 'default': 'pulse', 'choices': ('pulse', 'esd', 'none'), 'help': 'X2Go server sound system (default: \'pulse\')', },
                     {'args':['--printing'], 'default': False, 'action': 'store_true', 'help': 'use X2Go printing (default: disabled)', },
@@ -198,7 +197,6 @@ x2go_features =   [ 'COMMAND',
                     'FORCE_PASSWORD',
                     'REMOTE_SSH_PORT',
                     'SSH_PRIVKEY',
-                    'SSH_PASSPHRASE',
                     'ADD_TO_KNOWN_HOSTS',
                     'SOUND',
                     'PRINTING',
@@ -506,9 +504,6 @@ Possible values for the --pack NX option are:
     else:
         a.look_for_keys = True
 
-    if a.ssh_passphrase and not a.ssh_privkey:
-        runtime_error("--ssh-passphrase can only be used in conjunction with --ssh-privkey.", parser=p, exitcode=1)
-
     # hang around the keyboard chaos...
     a.kbd_type   = a.kbd_type.lower()
     a.kbd_layout = a.kbd_layout.lower()
diff --git a/pyhoca/cli/frontend.py b/pyhoca/cli/frontend.py
index d3532334..3b0f1453 100644
--- a/pyhoca/cli/frontend.py
+++ b/pyhoca/cli/frontend.py
@@ -504,7 +504,7 @@ class PyHocaCLI(x2go.X2GoClient):
         else:
             non_interactive = False
 
-        passphrase = self.args.ssh_passphrase
+        passphrase = None
         passphrase_unlock_counter = 3
 
         _username = self.args.username or self._X2GoClient__get_session_username(self.x2go_session_hash)

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goclient.git