[X2Go-Commits] [nx-libs] 336/429: Clipboard.c: rephrase FIXME

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch 3.6.x
in repository nx-libs.

commit bff23cb94bc2fc3befe8d375c761b7e96b16984c
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Mon Oct 12 20:14:16 2020 +0200

    Clipboard.c: rephrase FIXME
---
 nx-X11/programs/Xserver/hw/nxagent/Clipboard.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c
index 30b781590..3e396d2c4 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Clipboard.c
@@ -2533,13 +2533,19 @@ Bool nxagentInitClipboard(WindowPtr pWin)
          * claim the ownership. Note that we report our serverWindow as
          * owner, not the real window!
          */
-         if (IS_INTERNAL_OWNER(index) && lastSelectionOwner[index].window)
-         {
-           XSetSelectionOwner(nxagentDisplay, lastSelectionOwner[index].remSelection, serverWindow, CurrentTime);
-         }
+        if (IS_INTERNAL_OWNER(index) && lastSelectionOwner[index].window)
+        {
+          /* remSelection has already be adjusted above */
+          XSetSelectionOwner(nxagentDisplay, lastSelectionOwner[index].remSelection, serverWindow, CurrentTime);
+        }
+        /*
+         * FIXME: Shouldn't we reset lastServers[index].* and
+         * lastClients[index].* here? Problem is that (internal)
+         * clients might still be waiting for answers. Should reply
+         * with failure then
+         */
       }
     }
-    /* FIXME: Shouldn't we reset lastServers[index].* and lastClients[index].* here? */
   }
   else
   {

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git