[X2Go-Commits] [nx-libs] 232/429: Window.c: add another FIXME

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch 3.6.x
in repository nx-libs.

commit cbd9875e5ca3169d5aaa995e73ec1f67f29ca743
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Wed Feb 3 13:38:59 2021 +0100

    Window.c: add another FIXME
---
 nx-X11/programs/Xserver/hw/nxagent/Window.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/nx-X11/programs/Xserver/hw/nxagent/Window.c b/nx-X11/programs/Xserver/hw/nxagent/Window.c
index ba93c96cb..5f12fd48a 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Window.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Window.c
@@ -3087,6 +3087,11 @@ static void nxagentReconnectWindow(void * param0, XID param1, void * data_buffer
         #endif
 
         /* FIXME: use XAllocSizeHints() */
+        /* FIXME: all this copying is only done because the first
+           element of the XSizeHints struct is a long which is of
+           different size on 32bit vs. 64bit platforms. We should
+           rewrite this to better readable and probably more robust
+           code */
         #ifdef _XSERVER64
         data64 = (unsigned char *) malloc(sizeof(XSizeHints) + 4);
         if (data64)

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git