[X2Go-Commits] [nx-libs] 264/429: shellcheck: Fix SC2230 issue

git-admin at x2go.org git-admin at x2go.org
Mon Oct 18 09:36:46 CEST 2021


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch 3.6.x
in repository nx-libs.

commit 6bada8f63d98128b269fb379194aead1eacbd711
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Mon Jun 7 14:32:08 2021 +0200

    shellcheck: Fix SC2230 issue
    
     ./nx-X11/x-indent.sh line 5:
     INDENT=$(which gnuindent || which gindent || which indent)
              ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.
                                 ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.
                                                  ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.
    
     For more information:
       https://www.shellcheck.net/wiki/SC2230 -- which is non-standard. Use builti...
    
    Signed-off-by: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
---
 nx-X11/x-indent.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nx-X11/x-indent.sh b/nx-X11/x-indent.sh
index 327aa6a4f..4690372e6 100755
--- a/nx-X11/x-indent.sh
+++ b/nx-X11/x-indent.sh
@@ -2,7 +2,7 @@
 
 # We want GNU indent, so first search for gindent to avoid /usr/bin/indent
 # on the BSDs, which won't work for us
-INDENT=$(which gnuindent || which gindent || which indent)
+INDENT=$(command -v gnuindent || command -v gindent || command -v indent)
 
 if [ -z "${INDENT}" ] ; then
     echo "Could not find indent, sorry..." >&2

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git


More information about the x2go-commits mailing list