[X2Go-Commits] [nx-libs] 177/429: Colormap.c: remove unneccessary check

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch 3.6.x
in repository nx-libs.

commit 5735e164e9625137c7d3209428eafab33300df94
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Mon Aug 3 16:40:49 2020 +0200

    Colormap.c: remove unneccessary check
    
    success would always be true at the beginning of the loop as it is part
    of the loop condition.
    
    Finding from PVS Studio: "V560 A part of conditional expression is
    always true: success."
---
 nx-X11/programs/Xserver/hw/nxagent/Colormap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nx-X11/programs/Xserver/hw/nxagent/Colormap.c b/nx-X11/programs/Xserver/hw/nxagent/Colormap.c
index 099c76af4..c173f322c 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Colormap.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Colormap.c
@@ -573,7 +573,7 @@ Bool nxagentReconnectAllColormap(void *p0)
 
   for (int cid = 0; (cid < MAXCLIENTS) && success; cid++)
   {
-    if (clients[cid] && success)
+    if (clients[cid])
     {
       FindClientResourcesByType(clients[cid], RT_COLORMAP, nxagentReconnectColormap, &success);
     }

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git