[X2Go-Commits] [libx2goclient] 16/44: src/x2goclient-network-ssh.c: fix x2goclient_network_ssh_log_std_str (): actual decrease the size counter.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository libx2goclient.

commit 387254cdc3c8f06d943ba7bc9795bf701396bf42
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Fri Jul 31 11:59:54 2020 +0200

    src/x2goclient-network-ssh.c: fix x2goclient_network_ssh_log_std_str (): actual decrease the size counter.
    
    Previously, the function didn't do that (unless the size was INT_MAX),
    so the loop never stopped... until the program crashed due to illegal
    memory accesses.
---
 src/x2goclient-network-ssh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/x2goclient-network-ssh.c b/src/x2goclient-network-ssh.c
index e639bd8..635aecf 100644
--- a/src/x2goclient-network-ssh.c
+++ b/src/x2goclient-network-ssh.c
@@ -936,7 +936,6 @@ static void x2goclient_network_ssh_log_std_str (const gchar * const str, const g
 
       if (INT_MAX < str_size_work) {
         cur_len = INT_MAX;
-        str_size_work -= INT_MAX;
       }
 
       const char *fmt = ">>>%.*s<<<";
@@ -953,6 +952,7 @@ static void x2goclient_network_ssh_log_std_str (const gchar * const str, const g
        * Be extra careful here.
        */
       str_work += cur_len;
+      str_size_work -= cur_len;
 
       cont = TRUE;
     }

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/libx2goclient.git