[X2Go-Commits] [x2goclient] 02/07: src/sshmasterconnection: return false if login check remote command execution failed.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2goclient.

commit e9885b377de71b0364490fe257c36a3c9ee2b0e2
Author: Melroy van den Berg <melroy at melroy.org>
Date:   Wed May 20 08:42:31 2020 +0200

    src/sshmasterconnection: return false if login check remote command execution failed.
---
 debian/changelog            | 2 ++
 src/sshmasterconnection.cpp | 1 +
 2 files changed, 3 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 75cb2ba..98ff8ed 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,6 +18,8 @@ x2goclient (4.1.2.3-0x2go1) UNRELEASED; urgency=medium
   [ Melroy van den Berg ]
   * New upstream version (4.1.2.3):
     - src/sshmasterconnection: send EOF before closing channel.
+    - src/sshmasterconnection: return false if login check remote command
+      execution failed.
 
  -- X2Go Release Manager <git-admin at x2go.org>  Thu, 13 Feb 2020 12:31:20 +0100
 
diff --git a/src/sshmasterconnection.cpp b/src/sshmasterconnection.cpp
index 7adf5d2..30f9a10 100644
--- a/src/sshmasterconnection.cpp
+++ b/src/sshmasterconnection.cpp
@@ -1686,6 +1686,7 @@ bool SshMasterConnection::checkLogin()
         QString errorMsg=tr ( "%1 failed." ).arg ("ssh_channel_request_exec");
         x2goDebug<<errorMsg.left (errorMsg.size () - 1)<<": "<<err<<endl;
         ssh_channel_free(channel);
+        return false;
     }
     else
     {

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goclient.git